All of lore.kernel.org
 help / color / mirror / Atom feed
From: Erik Skultety <eskultet@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/3] Introduce 'rendernode' option for egl-headless display type
Date: Fri, 16 Nov 2018 10:24:30 +0100	[thread overview]
Message-ID: <20181116092430.GA13547@ridgehead> (raw)
In-Reply-To: <20181116084352.t7in4ztnnhkgd37b@sirius.home.kraxel.org>

On Fri, Nov 16, 2018 at 09:43:52AM +0100, Gerd Hoffmann wrote:
> On Thu, Nov 15, 2018 at 09:47:44AM -0600, Eric Blake wrote:
> > On 11/15/18 9:15 AM, Erik Skultety wrote:
> > > Since QEMU always picks the default DRI device, libvirt doesn't know which one
> > > to put into the mount namespace and relabel it accordingly, hence hitting
> > > permission issues, unless admin tweaks the default permissions of the DRI
> > > devices.
> > >
> > > https://bugzilla.redhat.com/show_bug.cgi?id=1648236
> >
> > This is borderline between fixing a bug that gets in the way of libvirt (and
> > thus useful for 3.1) and a feature (thus for 4.0, since we won't have a 3.2
> > release). I'll let Gerd decide.
>
> It's simple enough and we are early in the -rc cycle still, I think it
> would be okay for 3.1.

As far as upstream's concerned, I'm okay with both because libvirt has to add
another version specific capability enum for this anyway. It's been broken
since libvirt 4.6.0 where I added egl-headless graphics type. Luckily, even
though it's far from optimal, a working solution exists, just change the
permissions on the device.

Thanks,
Erik

  reply	other threads:[~2018-11-16  9:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-15 15:15 [Qemu-devel] [PATCH 0/3] Introduce 'rendernode' option for egl-headless display type Erik Skultety
2018-11-15 15:15 ` [Qemu-devel] [PATCH 1/3] qapi: Add "rendernode" display option for egl-headless Erik Skultety
2018-11-15 15:48   ` Eric Blake
2018-11-15 15:15 ` [Qemu-devel] [PATCH 2/3] ui: Allow specifying 'rendernode' " Erik Skultety
2018-11-15 15:15 ` [Qemu-devel] [PATCH 3/3] help: Provide help " Erik Skultety
2018-11-15 15:47 ` [Qemu-devel] [PATCH 0/3] Introduce 'rendernode' option for egl-headless display type Eric Blake
2018-11-16  8:43   ` Gerd Hoffmann
2018-11-16  9:24     ` Erik Skultety [this message]
2018-11-16  9:30       ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181116092430.GA13547@ridgehead \
    --to=eskultet@redhat.com \
    --cc=eblake@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.