From: Cornelia Huck <cohuck@redhat.com>
To: Petr Tesarik <ptesarik@suse.com>
Cc: Tony Krowiak <akrowiak@linux.ibm.com>,
Pierre Morel <pmorel@linux.ibm.com>,
Halil Pasic <pasic@linux.ibm.com>,
Harald Freudenberger <freude@linux.ibm.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] s390: vfio-ap: include <asm/facility> for test_facility()
Date: Fri, 16 Nov 2018 11:58:42 +0100 [thread overview]
Message-ID: <20181116115842.62879dd1.cohuck@redhat.com> (raw)
In-Reply-To: <20181116114748.590dfb45@ezekiel.suse.cz>
On Fri, 16 Nov 2018 11:47:48 +0100
Petr Tesarik <ptesarik@suse.com> wrote:
> The driver uses test_facility(), but does not include the
> corresponding include file explicitly. The driver currently builds
> only thanks to the following include chain:
>
> vfio_ap_drv.c
> <linux/module.h>
> <linux/elf.h>
> <asm/elf.h>
> <linux/compat.h>
> <asm/uaccess.h>
> <asm/facility.h>
>
> Files should not rely on such fragile implicit includes.
>
> Signed-off-by: Petr Tesarik <ptesarik@suse.com>
> ---
> drivers/s390/crypto/vfio_ap_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/s390/crypto/vfio_ap_drv.c b/drivers/s390/crypto/vfio_ap_drv.c
> index 7667b38728f0..31c6c847eaca 100644
> --- a/drivers/s390/crypto/vfio_ap_drv.c
> +++ b/drivers/s390/crypto/vfio_ap_drv.c
> @@ -11,6 +11,7 @@
> #include <linux/mod_devicetable.h>
> #include <linux/slab.h>
> #include <linux/string.h>
> +#include <asm/facility.h>
> #include "vfio_ap_private.h"
>
> #define VFIO_AP_ROOT_NAME "vfio_ap"
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
next prev parent reply other threads:[~2018-11-16 10:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-16 10:47 [PATCH 1/1] s390: vfio-ap: include <asm/facility> for test_facility() Petr Tesarik
2018-11-16 10:58 ` Cornelia Huck [this message]
2018-11-16 11:48 ` Christian Borntraeger
2018-11-16 12:20 ` Halil Pasic
2018-11-16 12:28 ` Petr Tesarik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181116115842.62879dd1.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=akrowiak@linux.ibm.com \
--cc=freude@linux.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pasic@linux.ibm.com \
--cc=pmorel@linux.ibm.com \
--cc=ptesarik@suse.com \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.