From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]) by casper.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gNdrh-0002ng-Nq for ath10k@lists.infradead.org; Fri, 16 Nov 2018 13:08:55 +0000 MIME-Version: 1.0 Subject: Re: [PATCH 4.20] ath10k: don't assume 'vif' is non-NULL in flush() From: Kalle Valo In-Reply-To: <20181108004035.136050-1-briannorris@chromium.org> References: <20181108004035.136050-1-briannorris@chromium.org> Message-Id: <20181116130842.5A01660886@smtp.codeaurora.org> Date: Fri, 16 Nov 2018 13:08:42 +0000 (UTC) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Brian Norris Cc: Grant Grundler , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, ath10k@lists.infradead.org, Wen Gong Brian Norris wrote: > mac80211 may call us with vif == NULL, if the station is not currently > active (e.g., not associated). It is trivially easy to reproduce a crash > by suspending the system when not connected to an AP: > > [ 65.533934] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000000 > ... > [ 65.574521] pc : ath10k_flush+0x30/0xd0 [ath10k_core] > [ 65.574538] lr : __ieee80211_flush_queues+0x180/0x244 [mac80211] > [ 65.599680] Process kworker/u12:1 (pid: 57, stack limit = 0x(____ptrval____)) > [ 65.599682] Call trace: > [ 65.599695] ath10k_flush+0x30/0xd0 [ath10k_core] > [ 65.642064] __ieee80211_flush_queues+0x180/0x244 [mac80211] > [ 65.642079] ieee80211_flush_queues+0x34/0x40 [mac80211] > [ 65.642095] __ieee80211_suspend+0xfc/0x47c [mac80211] > [ 65.658611] ieee80211_suspend+0x30/0x3c [mac80211] > [ 65.658627] wiphy_suspend+0x15c/0x3a8 [cfg80211] > [ 65.672810] dpm_run_callback+0xf0/0x1f0 > [ 65.672814] __device_suspend+0x3ac/0x4f8 > [ 65.672819] async_suspend+0x34/0xbc > [ 65.684096] async_run_entry_fn+0x54/0x104 > [ 65.684099] worker_thread+0x4cc/0x72c > [ 65.684102] kthread+0x134/0x13c > [ 65.684105] ret_from_fork+0x10/0x18 > > Fixes: 9de4162f0999 ("ath10k: add peer flush in ath10k_flush for STATION") > Signed-off-by: Brian Norris Patch applied to wireless-drivers.git, thanks. d987f783a480 ath10k: don't assume 'vif' is non-NULL in flush() -- https://patchwork.kernel.org/patch/10673301/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k