From: Kevin Wolf <kwolf@redhat.com>
To: Alberto Garcia <berto@igalia.com>
Cc: Max Reitz <mreitz@redhat.com>, Qemu-block <qemu-block@nongnu.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Markus Armbruster <armbru@redhat.com>,
"Denis V. Lunev" <den@openvz.org>,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Subject: Re: [Qemu-devel] KVM Forum block no[td]es
Date: Fri, 16 Nov 2018 16:18:34 +0100 [thread overview]
Message-ID: <20181116151834.GA5066@localhost.localdomain> (raw)
In-Reply-To: <w51in0xuksv.fsf@maestria.local.igalia.com>
Am 16.11.2018 um 16:03 hat Alberto Garcia geschrieben:
> > I don't think anything needs a way to generally block graph changes
> > around some node. We only need to prevent changes to very specific
> > sets of edges. This is something that the permission system just
> > cannot do.
>
> But what would you do then?
I agree with you mostly in that I think that most problems that Max
mentioned aren't readl. The only real problem I see with GRAPH_MOD as a
permission on the node level is this overblocking - but that's bad
enough that I feel using permissions to block changes to a whole node is
not a good solution.
So what's the alternative? Max had a possible solution in the first
email in this thread:
> - A property of BdrvChild that can be set by a non-parent seems more
> feasible, e.g. a counter where changing the child is possible only
> if the counter is 0. This also actually makes sense in what it
> means.
The commit job would increment BdrvChild.block_change (or whatever we
would call it) for all bs->backing edges in the subchain.
Kevin
next prev parent reply other threads:[~2018-11-16 15:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-11 22:25 [Qemu-devel] KVM Forum block no[td]es Max Reitz
2018-11-11 23:36 ` [Qemu-devel] [Qemu-block] " Nir Soffer
2018-11-12 15:25 ` Max Reitz
2018-11-12 16:10 ` Nir Soffer
2018-11-21 1:24 ` Vladimir Sementsov-Ogievskiy
2018-11-14 19:38 ` John Snow
2018-11-13 15:12 ` [Qemu-devel] " Alberto Garcia
2018-11-14 17:24 ` Max Reitz
2018-11-15 14:28 ` Alberto Garcia
2018-11-16 12:14 ` Max Reitz
2018-11-16 15:03 ` Alberto Garcia
2018-11-16 15:18 ` Kevin Wolf [this message]
2018-11-16 15:27 ` Max Reitz
2018-11-16 15:51 ` Kevin Wolf
2018-11-16 16:34 ` Max Reitz
2018-11-16 17:13 ` Kevin Wolf
2018-11-16 18:23 ` Max Reitz
2018-11-16 17:16 ` Alberto Garcia
2018-11-19 16:47 ` Alberto Garcia
2018-11-16 15:19 ` Max Reitz
2018-11-16 15:20 ` Alberto Garcia
2018-11-16 7:47 ` Denis V.Lunev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181116151834.GA5066@localhost.localdomain \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=berto@igalia.com \
--cc=den@openvz.org \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.