From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from verein.lst.de ([213.95.11.211]:50739 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728485AbeKQCDV (ORCPT ); Fri, 16 Nov 2018 21:03:21 -0500 Date: Fri, 16 Nov 2018 16:50:26 +0100 From: Christoph Hellwig To: Carlos Maiolino Cc: Andreas Dilger , Linux FS-devel Mailing List , Eric Sandeen , Christoph Hellwig , Dave Chinner , darrick.wong@oracle.com Subject: Re: [PATCH 07/20] fiemap: Move fiemap flags to fiemap_ctx Message-ID: <20181116155026.GE15119@lst.de> References: <20181030131823.29040-1-cmaiolino@redhat.com> <20181030131823.29040-8-cmaiolino@redhat.com> <39BFCB99-F6C2-466F-855A-0AE844D5ECD6@dilger.ca> <20181106083726.itotrjkluv7zxyrd@odin.usersys.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181106083726.itotrjkluv7zxyrd@odin.usersys.redhat.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, Nov 06, 2018 at 09:37:26AM +0100, Carlos Maiolino wrote: > Not really, fiemap_extent_info is removed at the end of the series, and by doing > it directly, I'd need to write a big patch changing all users of > fiemap_extent_info in a single patch, or break the kernel build between patches. > I usually try to avoid a single patch touching several different filesystems, so > that's why I basically slowly replaced fiemap_extent_info, until it get removed > at the end of the series. Sounds sensible. I also always found fiemap_extent_info rather long and cumbersome. > > The other minor nit about this patch series is that "f_ctx" is not a very > > descriptive variable name. How about "fiemap_ctx"? A bit longer, but it > > is immediately clear to the reader what it is. > > I don't really mind, f_ctx, fmap_ctx, etc. having the pointer the same name as > the struct doesn't look good to me, but particularly I don't mind. Just ctx sounds fine to me.