From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from verein.lst.de ([213.95.11.211]:50752 "EHLO newverein.lst.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1728124AbeKQCEa (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
        Fri, 16 Nov 2018 21:04:30 -0500
Date: Fri, 16 Nov 2018 16:51:36 +0100
From: Christoph Hellwig <hch@lst.de>
To: Carlos Maiolino <cmaiolino@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, sandeen@redhat.com, hch@lst.de,
        david@fromorbit.com, darrick.wong@oracle.com
Subject: Re: [PATCH 07/20] fiemap: Move fiemap flags to fiemap_ctx
Message-ID: <20181116155136.GF15119@lst.de>
References: <20181030131823.29040-1-cmaiolino@redhat.com> <20181030131823.29040-8-cmaiolino@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20181030131823.29040-8-cmaiolino@redhat.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

>  struct fiemap_ctx {
> -	unsigned int fc_flags;
> +	unsigned int fc_flags;	/* Flags as passed from user */

If you really need a comment here maybe it should be:

	unsigned int		fc_flags; /* FIEMAP_FLAG_* */

Otherwise this generally looks fine to me.