From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from verein.lst.de ([213.95.11.211]:50762 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728124AbeKQCHV (ORCPT ); Fri, 16 Nov 2018 21:07:21 -0500 Date: Fri, 16 Nov 2018 16:54:25 +0100 From: Christoph Hellwig To: Carlos Maiolino Cc: linux-fsdevel@vger.kernel.org, sandeen@redhat.com, hch@lst.de, david@fromorbit.com, darrick.wong@oracle.com Subject: Re: [PATCH 14/20] fiemap: Use fiemap_ctx as fiemap_fill_next_extent argument Message-ID: <20181116155425.GG15119@lst.de> References: <20181030131823.29040-1-cmaiolino@redhat.com> <20181030131823.29040-15-cmaiolino@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181030131823.29040-15-cmaiolino@redhat.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, Oct 30, 2018 at 02:18:17PM +0100, Carlos Maiolino wrote: > Replace the current fiemap_extent_info argument in > fiemap_fill_next_extent(), by the new fiemap_ctx structure. This way we > remove (almost) all direct usage of fiemap_extent_info outside fiemap > code (except by btrfs). Given that the previous prep patches already touched basically all the fiemap_fill_next_extent I'd be tempted to merge them into this patch for a little less churn.