From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [PATCH v2 2/5] drm/i915/fixed: prefer kernel types over stdint types Date: Fri, 16 Nov 2018 11:27:20 -0800 Message-ID: <20181116192720.GC7549@intel.com> References: <20181116120729.7580-1-jani.nikula@intel.com> <20181116120729.7580-2-jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7827A6E6C6 for ; Fri, 16 Nov 2018 19:27:21 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20181116120729.7580-2-jani.nikula@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBOb3YgMTYsIDIwMTggYXQgMDI6MDc6MjZQTSArMDIwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gV2hpbGUgYXQgaXQsIGNvbmZvcm0gdG8ga2VybmVsIHNwYWNpbmcgKGkuZS4gbm8gc3Bh Y2UpIGFmdGVyIGNhc3QuIE5vCj4gZnVuY3Rpb25hbCBjaGFuZ2VzLgoKY291bGQgd2UgZG8gYSBz ZWQgb3IgY29jaW5lbGxlIHBhdGNoIGZvciBhIG1hc3NpdmUgdXBkYXRlIG9uIHRoaXM/Cgo+IAo+ IFJldmlld2VkLWJ5OiBKb29uYXMgTGFodGluZW4gPGpvb25hcy5sYWh0aW5lbkBsaW51eC5pbnRl bC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNv bT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9maXhlZC5oIHwgNjEgKysrKysr KysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAyOSBp bnNlcnRpb25zKCspLCAzMiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9maXhlZC5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9maXhl ZC5oCj4gaW5kZXggYzk3NGU1MWM2ZDhiLi42YzkxNDk0MGI0YTkgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9maXhlZC5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9maXhlZC5oCj4gQEAgLTcsNyArNyw3IEBACj4gICNkZWZpbmUgX0k5MTVfRklYRURf SF8KPiAgCj4gIHR5cGVkZWYgc3RydWN0IHsKPiAtCXVpbnQzMl90IHZhbDsKPiArCXUzMiB2YWw7 Cj4gIH0gdWludF9maXhlZF8xNl8xNl90Owo+ICAKPiAgI2RlZmluZSBGUF8xNl8xNl9NQVggKHsg XAo+IEBAIC0yMyw3ICsyMyw3IEBAIHN0YXRpYyBpbmxpbmUgYm9vbCBpc19maXhlZDE2X3plcm8o dWludF9maXhlZF8xNl8xNl90IHZhbCkKPiAgCXJldHVybiBmYWxzZTsKPiAgfQo+ICAKPiAtc3Rh dGljIGlubGluZSB1aW50X2ZpeGVkXzE2XzE2X3QgdTMyX3RvX2ZpeGVkMTYodWludDMyX3QgdmFs KQo+ICtzdGF0aWMgaW5saW5lIHVpbnRfZml4ZWRfMTZfMTZfdCB1MzJfdG9fZml4ZWQxNih1MzIg dmFsKQo+ICB7Cj4gIAl1aW50X2ZpeGVkXzE2XzE2X3QgZnA7Cj4gIAo+IEBAIC0zMywxMiArMzMs MTIgQEAgc3RhdGljIGlubGluZSB1aW50X2ZpeGVkXzE2XzE2X3QgdTMyX3RvX2ZpeGVkMTYodWlu dDMyX3QgdmFsKQo+ICAJcmV0dXJuIGZwOwo+ICB9Cj4gIAo+IC1zdGF0aWMgaW5saW5lIHVpbnQz Ml90IGZpeGVkMTZfdG9fdTMyX3JvdW5kX3VwKHVpbnRfZml4ZWRfMTZfMTZfdCBmcCkKPiArc3Rh dGljIGlubGluZSB1MzIgZml4ZWQxNl90b191MzJfcm91bmRfdXAodWludF9maXhlZF8xNl8xNl90 IGZwKQo+ICB7Cj4gIAlyZXR1cm4gRElWX1JPVU5EX1VQKGZwLnZhbCwgMSA8PCAxNik7Cj4gIH0K PiAgCj4gLXN0YXRpYyBpbmxpbmUgdWludDMyX3QgZml4ZWQxNl90b191MzIodWludF9maXhlZF8x Nl8xNl90IGZwKQo+ICtzdGF0aWMgaW5saW5lIHUzMiBmaXhlZDE2X3RvX3UzMih1aW50X2ZpeGVk XzE2XzE2X3QgZnApCj4gIHsKPiAgCXJldHVybiBmcC52YWwgPj4gMTY7Cj4gIH0KPiBAQCAtNjEs ODYgKzYxLDgzIEBAIHN0YXRpYyBpbmxpbmUgdWludF9maXhlZF8xNl8xNl90IG1heF9maXhlZDE2 KHVpbnRfZml4ZWRfMTZfMTZfdCBtYXgxLAo+ICAJcmV0dXJuIG1heDsKPiAgfQo+ICAKPiAtc3Rh dGljIGlubGluZSB1aW50X2ZpeGVkXzE2XzE2X3QgY2xhbXBfdTY0X3RvX2ZpeGVkMTYodWludDY0 X3QgdmFsKQo+ICtzdGF0aWMgaW5saW5lIHVpbnRfZml4ZWRfMTZfMTZfdCBjbGFtcF91NjRfdG9f Zml4ZWQxNih1NjQgdmFsKQo+ICB7Cj4gIAl1aW50X2ZpeGVkXzE2XzE2X3QgZnA7Cj4gIAlXQVJO X09OKHZhbCA+IFUzMl9NQVgpOwo+IC0JZnAudmFsID0gKHVpbnQzMl90KSB2YWw7Cj4gKwlmcC52 YWwgPSAodTMyKXZhbDsKPiAgCXJldHVybiBmcDsKPiAgfQo+ICAKPiAtc3RhdGljIGlubGluZSB1 aW50MzJfdCBkaXZfcm91bmRfdXBfZml4ZWQxNih1aW50X2ZpeGVkXzE2XzE2X3QgdmFsLAo+IC0J CQkJCSAgICB1aW50X2ZpeGVkXzE2XzE2X3QgZCkKPiArc3RhdGljIGlubGluZSB1MzIgZGl2X3Jv dW5kX3VwX2ZpeGVkMTYodWludF9maXhlZF8xNl8xNl90IHZhbCwKPiArCQkJCSAgICAgICB1aW50 X2ZpeGVkXzE2XzE2X3QgZCkKPiAgewo+ICAJcmV0dXJuIERJVl9ST1VORF9VUCh2YWwudmFsLCBk LnZhbCk7Cj4gIH0KPiAgCj4gLXN0YXRpYyBpbmxpbmUgdWludDMyX3QgbXVsX3JvdW5kX3VwX3Uz Ml9maXhlZDE2KHVpbnQzMl90IHZhbCwKPiAtCQkJCQkJdWludF9maXhlZF8xNl8xNl90IG11bCkK PiArc3RhdGljIGlubGluZSB1MzIgbXVsX3JvdW5kX3VwX3UzMl9maXhlZDE2KHUzMiB2YWwsIHVp bnRfZml4ZWRfMTZfMTZfdCBtdWwpCj4gIHsKPiAtCXVpbnQ2NF90IGludGVybWVkaWF0ZV92YWw7 Cj4gKwl1NjQgaW50ZXJtZWRpYXRlX3ZhbDsKPiAgCj4gLQlpbnRlcm1lZGlhdGVfdmFsID0gKHVp bnQ2NF90KSB2YWwgKiBtdWwudmFsOwo+ICsJaW50ZXJtZWRpYXRlX3ZhbCA9ICh1NjQpdmFsICog bXVsLnZhbDsKPiAgCWludGVybWVkaWF0ZV92YWwgPSBESVZfUk9VTkRfVVBfVUxMKGludGVybWVk aWF0ZV92YWwsIDEgPDwgMTYpOwo+ICAJV0FSTl9PTihpbnRlcm1lZGlhdGVfdmFsID4gVTMyX01B WCk7Cj4gLQlyZXR1cm4gKHVpbnQzMl90KSBpbnRlcm1lZGlhdGVfdmFsOwo+ICsJcmV0dXJuICh1 MzIpaW50ZXJtZWRpYXRlX3ZhbDsKPiAgfQo+ICAKPiAgc3RhdGljIGlubGluZSB1aW50X2ZpeGVk XzE2XzE2X3QgbXVsX2ZpeGVkMTYodWludF9maXhlZF8xNl8xNl90IHZhbCwKPiAgCQkJCQkgICAg IHVpbnRfZml4ZWRfMTZfMTZfdCBtdWwpCj4gIHsKPiAtCXVpbnQ2NF90IGludGVybWVkaWF0ZV92 YWw7Cj4gKwl1NjQgaW50ZXJtZWRpYXRlX3ZhbDsKPiAgCj4gLQlpbnRlcm1lZGlhdGVfdmFsID0g KHVpbnQ2NF90KSB2YWwudmFsICogbXVsLnZhbDsKPiArCWludGVybWVkaWF0ZV92YWwgPSAodTY0 KXZhbC52YWwgKiBtdWwudmFsOwo+ICAJaW50ZXJtZWRpYXRlX3ZhbCA9IGludGVybWVkaWF0ZV92 YWwgPj4gMTY7Cj4gIAlyZXR1cm4gY2xhbXBfdTY0X3RvX2ZpeGVkMTYoaW50ZXJtZWRpYXRlX3Zh bCk7Cj4gIH0KPiAgCj4gLXN0YXRpYyBpbmxpbmUgdWludF9maXhlZF8xNl8xNl90IGRpdl9maXhl ZDE2KHVpbnQzMl90IHZhbCwgdWludDMyX3QgZCkKPiArc3RhdGljIGlubGluZSB1aW50X2ZpeGVk XzE2XzE2X3QgZGl2X2ZpeGVkMTYodTMyIHZhbCwgdTMyIGQpCj4gIHsKPiAtCXVpbnQ2NF90IGlu dGVybV92YWw7Cj4gKwl1NjQgaW50ZXJtX3ZhbDsKPiAgCj4gLQlpbnRlcm1fdmFsID0gKHVpbnQ2 NF90KXZhbCA8PCAxNjsKPiArCWludGVybV92YWwgPSAodTY0KXZhbCA8PCAxNjsKPiAgCWludGVy bV92YWwgPSBESVZfUk9VTkRfVVBfVUxMKGludGVybV92YWwsIGQpOwo+ICAJcmV0dXJuIGNsYW1w X3U2NF90b19maXhlZDE2KGludGVybV92YWwpOwo+ICB9Cj4gIAo+IC1zdGF0aWMgaW5saW5lIHVp bnQzMl90IGRpdl9yb3VuZF91cF91MzJfZml4ZWQxNih1aW50MzJfdCB2YWwsCj4gLQkJCQkJCXVp bnRfZml4ZWRfMTZfMTZfdCBkKQo+ICtzdGF0aWMgaW5saW5lIHUzMiBkaXZfcm91bmRfdXBfdTMy X2ZpeGVkMTYodTMyIHZhbCwgdWludF9maXhlZF8xNl8xNl90IGQpCj4gIHsKPiAtCXVpbnQ2NF90 IGludGVybV92YWw7Cj4gKwl1NjQgaW50ZXJtX3ZhbDsKPiAgCj4gLQlpbnRlcm1fdmFsID0gKHVp bnQ2NF90KXZhbCA8PCAxNjsKPiArCWludGVybV92YWwgPSAodTY0KXZhbCA8PCAxNjsKPiAgCWlu dGVybV92YWwgPSBESVZfUk9VTkRfVVBfVUxMKGludGVybV92YWwsIGQudmFsKTsKPiAgCVdBUk5f T04oaW50ZXJtX3ZhbCA+IFUzMl9NQVgpOwo+IC0JcmV0dXJuICh1aW50MzJfdCkgaW50ZXJtX3Zh bDsKPiArCXJldHVybiAodTMyKWludGVybV92YWw7Cj4gIH0KPiAgCj4gLXN0YXRpYyBpbmxpbmUg dWludF9maXhlZF8xNl8xNl90IG11bF91MzJfZml4ZWQxNih1aW50MzJfdCB2YWwsCj4gLQkJCQkJ CSB1aW50X2ZpeGVkXzE2XzE2X3QgbXVsKQo+ICtzdGF0aWMgaW5saW5lIHVpbnRfZml4ZWRfMTZf MTZfdCBtdWxfdTMyX2ZpeGVkMTYodTMyIHZhbCwgdWludF9maXhlZF8xNl8xNl90IG11bCkKPiAg ewo+IC0JdWludDY0X3QgaW50ZXJtZWRpYXRlX3ZhbDsKPiArCXU2NCBpbnRlcm1lZGlhdGVfdmFs Owo+ICAKPiAtCWludGVybWVkaWF0ZV92YWwgPSAodWludDY0X3QpIHZhbCAqIG11bC52YWw7Cj4g KwlpbnRlcm1lZGlhdGVfdmFsID0gKHU2NCl2YWwgKiBtdWwudmFsOwo+ICAJcmV0dXJuIGNsYW1w X3U2NF90b19maXhlZDE2KGludGVybWVkaWF0ZV92YWwpOwo+ICB9Cj4gIAo+ICBzdGF0aWMgaW5s aW5lIHVpbnRfZml4ZWRfMTZfMTZfdCBhZGRfZml4ZWQxNih1aW50X2ZpeGVkXzE2XzE2X3QgYWRk MSwKPiAgCQkJCQkgICAgIHVpbnRfZml4ZWRfMTZfMTZfdCBhZGQyKQo+ICB7Cj4gLQl1aW50NjRf dCBpbnRlcm1fc3VtOwo+ICsJdTY0IGludGVybV9zdW07Cj4gIAo+IC0JaW50ZXJtX3N1bSA9ICh1 aW50NjRfdCkgYWRkMS52YWwgKyBhZGQyLnZhbDsKPiArCWludGVybV9zdW0gPSAodTY0KWFkZDEu dmFsICsgYWRkMi52YWw7Cj4gIAlyZXR1cm4gY2xhbXBfdTY0X3RvX2ZpeGVkMTYoaW50ZXJtX3N1 bSk7Cj4gIH0KPiAgCj4gIHN0YXRpYyBpbmxpbmUgdWludF9maXhlZF8xNl8xNl90IGFkZF9maXhl ZDE2X3UzMih1aW50X2ZpeGVkXzE2XzE2X3QgYWRkMSwKPiAtCQkJCQkJIHVpbnQzMl90IGFkZDIp Cj4gKwkJCQkJCSB1MzIgYWRkMikKPiAgewo+IC0JdWludDY0X3QgaW50ZXJtX3N1bTsKPiArCXU2 NCBpbnRlcm1fc3VtOwo+ICAJdWludF9maXhlZF8xNl8xNl90IGludGVybV9hZGQyID0gdTMyX3Rv X2ZpeGVkMTYoYWRkMik7Cj4gIAo+IC0JaW50ZXJtX3N1bSA9ICh1aW50NjRfdCkgYWRkMS52YWwg KyBpbnRlcm1fYWRkMi52YWw7Cj4gKwlpbnRlcm1fc3VtID0gKHU2NClhZGQxLnZhbCArIGludGVy bV9hZGQyLnZhbDsKPiAgCXJldHVybiBjbGFtcF91NjRfdG9fZml4ZWQxNihpbnRlcm1fc3VtKTsK PiAgfQo+ICAKPiAtLSAKPiAyLjExLjAKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9pbnRlbC1nZngKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vaW50ZWwtZ2Z4Cg==