From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johan Hovold Subject: Re: [PATCH 1/2] phy: core: Add phy_pm_runtime_enabled Date: Sat, 17 Nov 2018 16:38:45 +0100 Message-ID: <20181117153845.GU19900@localhost> References: <20181117133755.9129-1-tony@atomide.com> <20181117133755.9129-2-tony@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20181117133755.9129-2-tony@atomide.com> Sender: linux-kernel-owner@vger.kernel.org To: Tony Lindgren Cc: Kishon Vijay Abraham I , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, Pavel Machek , Sebastian Reichel List-Id: linux-omap@vger.kernel.org On Sat, Nov 17, 2018 at 05:37:54AM -0800, Tony Lindgren wrote: > The phy driver may need to check phy_pm_runtime_enabled() in suspend as > PM runtime for phy may be already disabled when phy power_off() is called. > > Cc: Pavel Machek > Cc: Sebastian Reichel > Signed-off-by: Tony Lindgren > --- > drivers/phy/phy-core.c | 9 +++++++++ > include/linux/phy/phy.h | 6 ++++++ > 2 files changed, 15 insertions(+) > > diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c > --- a/drivers/phy/phy-core.c > +++ b/drivers/phy/phy-core.c > diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h > --- a/include/linux/phy/phy.h > +++ b/include/linux/phy/phy.h > @@ -158,6 +158,7 @@ int phy_pm_runtime_get(struct phy *phy); > int phy_pm_runtime_get_sync(struct phy *phy); > int phy_pm_runtime_put(struct phy *phy); > int phy_pm_runtime_put_sync(struct phy *phy); > +bool phy_pm_runtime_enabled(struct phy *phy); > void phy_pm_runtime_allow(struct phy *phy); > void phy_pm_runtime_forbid(struct phy *phy); > int phy_init(struct phy *phy); > @@ -240,6 +241,11 @@ static inline int phy_pm_runtime_put_sync(struct phy *phy) > return -ENOSYS; > } > > +static inline bool phy_pm_runtime_enabled(struct phy *phy) > +{ > + return false Missing semicolon. > +} > + > static inline void phy_pm_runtime_allow(struct phy *phy) > { > return; Johan From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [1/2] phy: core: Add phy_pm_runtime_enabled From: Johan Hovold Message-Id: <20181117153845.GU19900@localhost> Date: Sat, 17 Nov 2018 16:38:45 +0100 To: Tony Lindgren Cc: Kishon Vijay Abraham I , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, Pavel Machek , Sebastian Reichel List-ID: T24gU2F0LCBOb3YgMTcsIDIwMTggYXQgMDU6Mzc6NTRBTSAtMDgwMCwgVG9ueSBMaW5kZ3JlbiB3 cm90ZToKPiBUaGUgcGh5IGRyaXZlciBtYXkgbmVlZCB0byBjaGVjayBwaHlfcG1fcnVudGltZV9l bmFibGVkKCkgaW4gc3VzcGVuZCBhcwo+IFBNIHJ1bnRpbWUgZm9yIHBoeSBtYXkgYmUgYWxyZWFk eSBkaXNhYmxlZCB3aGVuIHBoeSBwb3dlcl9vZmYoKSBpcyBjYWxsZWQuCj4gCj4gQ2M6IFBhdmVs IE1hY2hlayA8cGF2ZWxAdWN3LmN6Pgo+IENjOiBTZWJhc3RpYW4gUmVpY2hlbCA8c3JlQGtlcm5l bC5vcmc+Cj4gU2lnbmVkLW9mZi1ieTogVG9ueSBMaW5kZ3JlbiA8dG9ueUBhdG9taWRlLmNvbT4K PiAtLS0KPiAgZHJpdmVycy9waHkvcGh5LWNvcmUuYyAgfCA5ICsrKysrKysrKwo+ICBpbmNsdWRl L2xpbnV4L3BoeS9waHkuaCB8IDYgKysrKysrCj4gIDIgZmlsZXMgY2hhbmdlZCwgMTUgaW5zZXJ0 aW9ucygrKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3BoeS9waHktY29yZS5jIGIvZHJpdmVy cy9waHkvcGh5LWNvcmUuYwo+IC0tLSBhL2RyaXZlcnMvcGh5L3BoeS1jb3JlLmMKPiArKysgYi9k cml2ZXJzL3BoeS9waHktY29yZS5jCgo+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2xpbnV4L3BoeS9w aHkuaCBiL2luY2x1ZGUvbGludXgvcGh5L3BoeS5oCj4gLS0tIGEvaW5jbHVkZS9saW51eC9waHkv cGh5LmgKPiArKysgYi9pbmNsdWRlL2xpbnV4L3BoeS9waHkuaAo+IEBAIC0xNTgsNiArMTU4LDcg QEAgaW50IHBoeV9wbV9ydW50aW1lX2dldChzdHJ1Y3QgcGh5ICpwaHkpOwo+ICBpbnQgcGh5X3Bt X3J1bnRpbWVfZ2V0X3N5bmMoc3RydWN0IHBoeSAqcGh5KTsKPiAgaW50IHBoeV9wbV9ydW50aW1l X3B1dChzdHJ1Y3QgcGh5ICpwaHkpOwo+ICBpbnQgcGh5X3BtX3J1bnRpbWVfcHV0X3N5bmMoc3Ry dWN0IHBoeSAqcGh5KTsKPiArYm9vbCBwaHlfcG1fcnVudGltZV9lbmFibGVkKHN0cnVjdCBwaHkg KnBoeSk7Cj4gIHZvaWQgcGh5X3BtX3J1bnRpbWVfYWxsb3coc3RydWN0IHBoeSAqcGh5KTsKPiAg dm9pZCBwaHlfcG1fcnVudGltZV9mb3JiaWQoc3RydWN0IHBoeSAqcGh5KTsKPiAgaW50IHBoeV9p bml0KHN0cnVjdCBwaHkgKnBoeSk7Cj4gQEAgLTI0MCw2ICsyNDEsMTEgQEAgc3RhdGljIGlubGlu ZSBpbnQgcGh5X3BtX3J1bnRpbWVfcHV0X3N5bmMoc3RydWN0IHBoeSAqcGh5KQo+ICAJcmV0dXJu IC1FTk9TWVM7Cj4gIH0KPiAgCj4gK3N0YXRpYyBpbmxpbmUgYm9vbCBwaHlfcG1fcnVudGltZV9l bmFibGVkKHN0cnVjdCBwaHkgKnBoeSkKPiArewo+ICsJcmV0dXJuIGZhbHNlCgpNaXNzaW5nIHNl bWljb2xvbi4KCj4gK30KPiArCj4gIHN0YXRpYyBpbmxpbmUgdm9pZCBwaHlfcG1fcnVudGltZV9h bGxvdyhzdHJ1Y3QgcGh5ICpwaHkpCj4gIHsKPiAgCXJldHVybjsKCkpvaGFuCg==