From: Andrew Lunn <andrew@lunn.ch>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
f.fainelli@gmail.com, mark.rutland@arm.com, robh+dt@kernel.org,
davem@davemloft.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/7] net: phy: icplus: rename IP101A_G_NO_IRQ to IP101A_G_IRQ_ALL_MASK
Date: Sun, 18 Nov 2018 18:06:30 +0100 [thread overview]
Message-ID: <20181118170630.GE5591@lunn.ch> (raw)
In-Reply-To: <20181117182007.14791-6-martin.blumenstingl@googlemail.com>
On Sat, Nov 17, 2018 at 07:20:05PM +0100, Martin Blumenstingl wrote:
> The datasheet uses the name "All Mask" for this bit. Change the name of
> our #define to be consistent with the datasheet. While here also replace
> the tab between the #define and IP101A_G_IRQ_ALL_MASK with a space.
> No functional changes.
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
I think this is the bit which confused Florian. Nice change, it makes
it a lot clearer what is going on.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2018-11-18 17:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-17 18:20 [PATCH 0/7] IP101GR: devicetree based configuration of SEL_INTR32 Martin Blumenstingl
2018-11-17 18:20 ` [PATCH 1/7] dt-bindings: vendor-prefix: add prefix for IC Plus Corp Martin Blumenstingl
2018-11-17 18:20 ` [PATCH 2/7] dt-bindings: net: phy: add bindings for the IC Plus Corp. IP101A/G PHYs Martin Blumenstingl
2018-11-18 17:03 ` Andrew Lunn
2018-11-18 17:29 ` Martin Blumenstingl
2018-11-17 18:20 ` [PATCH 3/7] net: phy: icplus: keep all ip101a_g functions together Martin Blumenstingl
2018-11-18 17:04 ` Andrew Lunn
2018-11-17 18:20 ` [PATCH 4/7] net: phy: icplus: use the BIT macro where possible Martin Blumenstingl
2018-11-18 17:04 ` Andrew Lunn
2018-11-17 18:20 ` [PATCH 5/7] net: phy: icplus: rename IP101A_G_NO_IRQ to IP101A_G_IRQ_ALL_MASK Martin Blumenstingl
2018-11-18 17:06 ` Andrew Lunn [this message]
2018-11-17 18:20 ` [PATCH 6/7] net: phy: icplus: implement .did_interrupt for IP101A/G Martin Blumenstingl
2018-11-18 17:09 ` Andrew Lunn
2018-11-17 18:20 ` [PATCH 7/7] net: phy: icplus: allow configuring the interrupt function on IP101GR Martin Blumenstingl
2018-11-18 17:13 ` Andrew Lunn
2018-11-18 17:30 ` Martin Blumenstingl
2018-11-18 17:45 ` Andrew Lunn
2018-11-18 21:25 ` Martin Blumenstingl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181118170630.GE5591@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.