From: Andreas Kemnade <andreas@kemnade.info>
To: johan@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Discussions about the Letux Kernel <letux-kernel@openphoenux.org>
Cc: Andreas Kemnade <andreas@kemnade.info>
Subject: [PATCH RFC 4/5] gnss: sirf: add a separate supply for a lna
Date: Sun, 18 Nov 2018 22:58:00 +0100 [thread overview]
Message-ID: <20181118215801.12280-5-andreas@kemnade.info> (raw)
In-Reply-To: <20181118215801.12280-1-andreas@kemnade.info>
Devices might have a separate lna between antenna output of the gps
chip and the antenna which might have a separate supply
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
drivers/gnss/sirf.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/drivers/gnss/sirf.c b/drivers/gnss/sirf.c
index 6a0e5c0a2d62..f7573ca2dacd 100644
--- a/drivers/gnss/sirf.c
+++ b/drivers/gnss/sirf.c
@@ -30,6 +30,7 @@ struct sirf_data {
struct serdev_device *serdev;
speed_t speed;
struct regulator *vcc;
+ struct regulator *lna;
struct gpio_desc *on_off;
struct gpio_desc *wakeup;
int irq;
@@ -217,6 +218,7 @@ static int sirf_runtime_suspend(struct device *dev)
if (!data->on_off)
return regulator_disable(data->vcc);
+ regulator_disable(data->lna);
ret = sirf_set_active(data, false);
if (ret)
@@ -245,13 +247,20 @@ static int sirf_runtime_resume(struct device *dev)
if (ret)
goto err_close_serdev;
}
+
+ ret = regulator_enable(data->lna);
+ if (ret)
+ goto err_disable_vcc;
+
ret = sirf_set_active(data, true);
if (!ret)
return 0;
+err_disable_vcc:
if (!data->on_off)
regulator_disable(data->vcc);
+
err_close_serdev:
serdev_device_close(data->serdev);
return ret;
@@ -340,6 +349,12 @@ static int sirf_probe(struct serdev_device *serdev)
goto err_put_device;
}
+ data->lna = devm_regulator_get(dev, "lna");
+ if (IS_ERR(data->lna)) {
+ ret = PTR_ERR(data->lna);
+ goto err_put_device;
+ }
+
data->on_off = devm_gpiod_get_optional(dev, "sirf,onoff",
GPIOD_OUT_LOW);
if (IS_ERR(data->on_off))
--
2.11.0
next prev parent reply other threads:[~2018-11-18 21:58 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-18 21:57 [PATCH 0/5] gnss: sirf: add support for w2sg0004 + lna Andreas Kemnade
2018-11-18 21:57 ` [PATCH 1/5] gnss: sirf: write data to gnss only when the gnss device is open Andreas Kemnade
2018-12-05 14:47 ` Johan Hovold
2018-12-05 20:14 ` Andreas Kemnade
2018-11-18 21:57 ` [PATCH 2/5] gnss: sirf: power on logic for devices without wakeup signal Andreas Kemnade
2018-11-19 8:37 ` H. Nikolaus Schaller
2018-12-05 15:01 ` Johan Hovold
2018-12-05 22:15 ` Andreas Kemnade
2018-11-18 21:57 ` [PATCH 3/5] dt-bindings: gnss: add w2sg0004 compatible string Andreas Kemnade
2018-12-04 22:57 ` Rob Herring
2018-12-05 15:01 ` Johan Hovold
2018-11-18 21:58 ` Andreas Kemnade [this message]
2018-11-19 8:41 ` [Letux-kernel] [PATCH RFC 4/5] gnss: sirf: add a separate supply for a lna H. Nikolaus Schaller
2018-11-27 18:03 ` Pavel Machek
2018-11-30 6:38 ` Andreas Kemnade
2018-11-30 8:43 ` Pavel Machek
2018-12-05 15:06 ` Johan Hovold
2018-11-18 21:58 ` [PATCH RFC 5/5] dt-bindings: gnss: add lna-supply property Andreas Kemnade
2018-12-04 22:59 ` Rob Herring
2018-12-05 15:09 ` Johan Hovold
2018-12-09 19:11 ` Andreas Kemnade
2018-11-19 8:22 ` [Letux-kernel] [PATCH 0/5] gnss: sirf: add support for w2sg0004 + lna H. Nikolaus Schaller
2018-11-19 18:44 ` Andreas Kemnade
2018-11-19 19:05 ` H. Nikolaus Schaller
2018-12-05 15:19 ` [Letux-kernel] " Johan Hovold
2018-12-05 16:01 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181118215801.12280-5-andreas@kemnade.info \
--to=andreas@kemnade.info \
--cc=devicetree@vger.kernel.org \
--cc=johan@kernel.org \
--cc=letux-kernel@openphoenux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.