All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Jiri Kosina <jkosina@suse.cz>,
	Thomas Gleixner <tglx@linutronix.de>,
	Peter Zijlstra <peterz@infradead.org>,
	Josh Poimboeuf <jpoimboe@redhat.com>,
	Andrea Arcangeli <aarcange@redhat.com>,
	David Woodhouse <dwmw@amazon.co.uk>,
	Andi Kleen <ak@linux.intel.com>,
	Tim Chen <tim.c.chen@linux.intel.com>,
	Casey Schaufler <casey.schaufler@intel.com>,
	Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
	the arch/x86 maintainers <x86@kernel.org>,
	stable@vger.kernel.org
Subject: Re: STIBP by default.. Revert?
Date: Mon, 19 Nov 2018 09:38:55 +0100	[thread overview]
Message-ID: <20181119083855.GA129733@gmail.com> (raw)
In-Reply-To: <CAHk-=wg-9FUGU=grF4gKDq1sm1m39Jbs3A_iyLbSSntU47ncwg@mail.gmail.com>


* Linus Torvalds <torvalds@linux-foundation.org> wrote:

> This was marked for stable, and honestly, nowhere in the discussion
> did I see any mention of just *how* bad the performance impact of this
> was.

Yeah. This was an oversight - we'll fix it!

> When performance goes down by 50% on some loads, people need to start
> asking themselves whether it was worth it. It's apparently better to
> just disable SMT entirely, which is what security-conscious people do
> anyway.
> 
> So why do that STIBP slow-down by default when the people who *really*
> care already disabled SMT?
> 
> I think we should use the same logic as for L1TF: we default to
> something that doesn't kill performance. Warn once about it, and let
> the  crazy people say "I'd rather take a 50% performance hit than
> worry about a theoretical issue".

Yeah, absolutely.

We'll also require performance measurements in changelogs enabling any 
sort of mitigation feature from now on - this requirement was implicit 
but 53c613fe6349 flew in under the radar, so it's going to be explicit an 
explicit requirement.

Thanks,

	Ingo

  parent reply	other threads:[~2018-11-19  8:39 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-18 20:36 STIBP by default.. Revert? Linus Torvalds
2018-11-18 21:49 ` Jiri Kosina
2018-11-18 21:59   ` Willy Tarreau
2018-11-18 22:00   ` Linus Torvalds
2018-11-18 22:17     ` Jiri Kosina
2018-11-18 22:35       ` Dave Hansen
2018-11-18 22:36       ` Tony Luck
2018-11-18 22:36       ` Linus Torvalds
2018-11-18 22:55         ` Tim Chen
2018-11-18 23:56         ` Andi Kleen
2018-11-18 22:40       ` Tim Chen
2018-11-18 23:58         ` Andi Kleen
2018-11-19  3:48         ` Willy Tarreau
2018-11-19 12:49         ` Thomas Gleixner
2018-11-18 23:01       ` Jiri Kosina
2018-11-18 23:04     ` Arjan van de Ven
2018-11-20 15:27       ` Jiri Kosina
2018-11-20 23:43         ` Arjan van de Ven
2018-11-19  8:38 ` Ingo Molnar [this message]
2018-11-19  8:43   ` Jiri Kosina
2018-11-20 15:20 ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181119083855.GA129733@gmail.com \
    --to=mingo@kernel.org \
    --cc=aarcange@redhat.com \
    --cc=ak@linux.intel.com \
    --cc=casey.schaufler@intel.com \
    --cc=dwmw@amazon.co.uk \
    --cc=jkosina@suse.cz \
    --cc=jpoimboe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=stable@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=tim.c.chen@linux.intel.com \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.