From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH] drm/fb-helper: Blacklist writeback when adding connectors to fbdev Date: Mon, 19 Nov 2018 10:28:35 +0100 Message-ID: <20181119092835.3y2xqfclwlmk4cww@flea> References: <20181115163248.21168-1-paul.kocialkowski@bootlin.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="adio4floig6atmjq" Return-path: Content-Disposition: inline In-Reply-To: <20181115163248.21168-1-paul.kocialkowski@bootlin.com> Sender: linux-kernel-owner@vger.kernel.org To: Paul Kocialkowski Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maarten Lankhorst , Sean Paul , David Airlie , Thomas Petazzoni , Eric Anholt , Boris Brezillon List-Id: dri-devel@lists.freedesktop.org --adio4floig6atmjq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 15, 2018 at 05:32:48PM +0100, Paul Kocialkowski wrote: > Writeback connectors do not produce any on-screen output and require > special care for use. Such connectors are hidden from enumeration in > DRM resources by default, but they are still picked-up by fbdev. > This makes rather little sense since fbdev is not really adapted for > dealing with writeback. >=20 > Moreover, this is also a source of issues when userspace disables the > CRTC (and associated plane) without detaching the CRTC from the > connector (which is hidden by default). In this case, the connector is > still using the CRTC, leading to am "enabled/connectors mismatch" and > eventually the failure of the associated atomic commit. This situation > happens with VC4 testing under IGT GPU Tools. >=20 > Filter out writeback connectors in the fbdev helper to solve this. >=20 > Signed-off-by: Paul Kocialkowski Reviewed-by: Maxime Ripard Tested-by: Maxime Ripard Thanks! Maxime --=20 Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --adio4floig6atmjq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCW/KCQwAKCRDj7w1vZxhR xY7gAQDZHFvWSxHsx94SaSOhXF1A+fyr4pYzvjdF+nkTKvYM6gD+NdiGWDKqdbIr ACu17Ht3/N6gBG0skZA7KX5lcHQKyQk= =Blv8 -----END PGP SIGNATURE----- --adio4floig6atmjq--