Re: [Qemu-devel] [PATCH] iotests: Drop use of bash keyword 'function'

["Daniel P. Berrangé" <berrange@redhat.com>]

On Fri, Nov 16, 2018 at 03:50:02PM -0600, Eric Blake wrote:
> Bash allows functions to be declared with or without the leading
> keyword 'function'; but including the keyword does not comply with
> POSIX syntax, and is confusing to ksh users where the use of the
> keyword changes the scoping rules for functions.  Stick to the
> POSIX form through iotests.
> 
> Done mechanically with:
>   sed -i 's/^function //' $(git ls-files tests/qemu-iotests)
> 
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|