From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.bootlin.com ([62.4.15.54]:45372 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728701AbeKSXOi (ORCPT ); Mon, 19 Nov 2018 18:14:38 -0500 Date: Mon, 19 Nov 2018 13:51:04 +0100 From: Boris Brezillon To: Fabrizio Castro Cc: Peter Rosin , Archit Taneja , Andrzej Hajda , David Airlie , Laurent Pinchart , dri-devel@lists.freedesktop.org, Simon Horman , Geert Uytterhoeven , Chris Paterson , Biju Das , linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH] drm/bridge: Fix 0-day build error Message-ID: <20181119135104.75a0a075@bbrezillon> In-Reply-To: <1542631463-21177-1-git-send-email-fabrizio.castro@bp.renesas.com> References: <1542631463-21177-1-git-send-email-fabrizio.castro@bp.renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Fabrizio, The prefix should be "drm/bridge/sii902x:" and I'd prefer a short explanation of what is problematic in the subject rather than "Fix 0-day build error". Maybe something like "drm/bridge/sii902x: Add missing dependency on I2C_MUX" On Mon, 19 Nov 2018 12:44:23 +0000 Fabrizio Castro wrote: > kbuild test robot reports: > > >> ERROR: "i2c_mux_add_adapter" [drivers/gpu/drm/bridge/sii902x.ko] > undefined! > >> ERROR: "i2c_mux_alloc" [drivers/gpu/drm/bridge/sii902x.ko] > undefined! > >> ERROR: "i2c_mux_del_adapters" [drivers/gpu/drm/bridge/sii902x.ko] > undefined! > > Quite obviously the driver depends on I2C_MUX, but adding a "depends on" > introduces a recursive dependency, therefore this patch selects I2C_MUX > instead. > You need a fixes tag here: Fixes: 21d808405fe4 ("drm/bridge/sii902x: Fix EDID readback") Thanks, Boris > Signed-off-by: Fabrizio Castro > Link: https://lists.01.org/pipermail/kbuild-all/2018-November/054924.html > --- > drivers/gpu/drm/bridge/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig > index 9eeb8ef..2fee47b 100644 > --- a/drivers/gpu/drm/bridge/Kconfig > +++ b/drivers/gpu/drm/bridge/Kconfig > @@ -95,6 +95,7 @@ config DRM_SII902X > depends on OF > select DRM_KMS_HELPER > select REGMAP_I2C > + select I2C_MUX > ---help--- > Silicon Image sii902x bridge chip driver. > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH] drm/bridge: Fix 0-day build error Date: Mon, 19 Nov 2018 13:51:04 +0100 Message-ID: <20181119135104.75a0a075@bbrezillon> References: <1542631463-21177-1-git-send-email-fabrizio.castro@bp.renesas.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.bootlin.com (mail.bootlin.com [62.4.15.54]) by gabe.freedesktop.org (Postfix) with ESMTP id A0F6D89EB7 for ; Mon, 19 Nov 2018 12:51:05 +0000 (UTC) In-Reply-To: <1542631463-21177-1-git-send-email-fabrizio.castro@bp.renesas.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Fabrizio Castro Cc: Geert Uytterhoeven , David Airlie , Chris Paterson , dri-devel@lists.freedesktop.org, Biju Das , linux-renesas-soc@vger.kernel.org, Simon Horman , Laurent Pinchart , Peter Rosin List-Id: dri-devel@lists.freedesktop.org SGkgRmFicml6aW8sCgpUaGUgcHJlZml4IHNob3VsZCBiZSAiZHJtL2JyaWRnZS9zaWk5MDJ4OiIg YW5kIEknZCBwcmVmZXIgYSBzaG9ydApleHBsYW5hdGlvbiBvZiB3aGF0IGlzIHByb2JsZW1hdGlj IGluIHRoZSBzdWJqZWN0IHJhdGhlciB0aGFuICJGaXgKMC1kYXkgYnVpbGQgZXJyb3IiLiBNYXli ZSBzb21ldGhpbmcgbGlrZQoKImRybS9icmlkZ2Uvc2lpOTAyeDogQWRkIG1pc3NpbmcgZGVwZW5k ZW5jeSBvbiBJMkNfTVVYIgoKT24gTW9uLCAxOSBOb3YgMjAxOCAxMjo0NDoyMyArMDAwMApGYWJy aXppbyBDYXN0cm8gPGZhYnJpemlvLmNhc3Ryb0BicC5yZW5lc2FzLmNvbT4gd3JvdGU6Cgo+IGti dWlsZCB0ZXN0IHJvYm90IHJlcG9ydHM6Cj4gCj4gPj4gRVJST1I6ICJpMmNfbXV4X2FkZF9hZGFw dGVyIiBbZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9zaWk5MDJ4LmtvXSAgCj4gdW5kZWZpbmVkIQo+ ID4+IEVSUk9SOiAiaTJjX211eF9hbGxvYyIgW2RyaXZlcnMvZ3B1L2RybS9icmlkZ2Uvc2lpOTAy eC5rb10gIAo+IHVuZGVmaW5lZCEKPiA+PiBFUlJPUjogImkyY19tdXhfZGVsX2FkYXB0ZXJzIiBb ZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9zaWk5MDJ4LmtvXSAgCj4gdW5kZWZpbmVkIQo+IAo+IFF1 aXRlIG9idmlvdXNseSB0aGUgZHJpdmVyIGRlcGVuZHMgb24gSTJDX01VWCwgYnV0IGFkZGluZyBh ICJkZXBlbmRzIG9uIgo+IGludHJvZHVjZXMgYSByZWN1cnNpdmUgZGVwZW5kZW5jeSwgdGhlcmVm b3JlIHRoaXMgcGF0Y2ggc2VsZWN0cyBJMkNfTVVYCj4gaW5zdGVhZC4KPiAKCllvdSBuZWVkIGEg Zml4ZXMgdGFnIGhlcmU6CgpGaXhlczogMjFkODA4NDA1ZmU0ICgiZHJtL2JyaWRnZS9zaWk5MDJ4 OiBGaXggRURJRCByZWFkYmFjayIpCgpUaGFua3MsCgpCb3JpcwoKPiBTaWduZWQtb2ZmLWJ5OiBG YWJyaXppbyBDYXN0cm8gPGZhYnJpemlvLmNhc3Ryb0BicC5yZW5lc2FzLmNvbT4KPiBMaW5rOiBo dHRwczovL2xpc3RzLjAxLm9yZy9waXBlcm1haWwva2J1aWxkLWFsbC8yMDE4LU5vdmVtYmVyLzA1 NDkyNC5odG1sCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9icmlkZ2UvS2NvbmZpZyB8IDEgKwo+ ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKykKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2JyaWRnZS9LY29uZmlnIGIvZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9LY29uZmln Cj4gaW5kZXggOWVlYjhlZi4uMmZlZTQ3YiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v YnJpZGdlL0tjb25maWcKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL0tjb25maWcKPiBA QCAtOTUsNiArOTUsNyBAQCBjb25maWcgRFJNX1NJSTkwMlgKPiAgCWRlcGVuZHMgb24gT0YKPiAg CXNlbGVjdCBEUk1fS01TX0hFTFBFUgo+ICAJc2VsZWN0IFJFR01BUF9JMkMKPiArCXNlbGVjdCBJ MkNfTVVYCj4gIAktLS1oZWxwLS0tCj4gIAkgIFNpbGljb24gSW1hZ2Ugc2lpOTAyeCBicmlkZ2Ug Y2hpcCBkcml2ZXIuCj4gIAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJp LWRldmVsCg==