From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.bootlin.com ([62.4.15.54]:46147 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729243AbeKSXq2 (ORCPT ); Mon, 19 Nov 2018 18:46:28 -0500 Date: Mon, 19 Nov 2018 14:22:48 +0100 From: Boris Brezillon To: Fabrizio Castro Cc: Peter Rosin , Archit Taneja , Andrzej Hajda , David Airlie , Laurent Pinchart , "dri-devel@lists.freedesktop.org" , Simon Horman , Geert Uytterhoeven , Chris Paterson , Biju Das , "linux-renesas-soc@vger.kernel.org" Subject: Re: [PATCH] drm/bridge: Fix 0-day build error Message-ID: <20181119142248.2135fbda@bbrezillon> In-Reply-To: References: <1542631463-21177-1-git-send-email-fabrizio.castro@bp.renesas.com> <20181119135104.75a0a075@bbrezillon> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: On Mon, 19 Nov 2018 13:09:16 +0000 Fabrizio Castro wrote: > Hi Boris, > > > From: Boris Brezillon > > Sent: 19 November 2018 12:51 > > Subject: Re: [PATCH] drm/bridge: Fix 0-day build error > > > > Hi Fabrizio, > > > > The prefix should be "drm/bridge/sii902x:" and I'd prefer a short > > explanation of what is problematic in the subject rather than "Fix > > 0-day build error". Maybe something like > > > > "drm/bridge/sii902x: Add missing dependency on I2C_MUX" > > > > On Mon, 19 Nov 2018 12:44:23 +0000 > > Fabrizio Castro wrote: > > > > > kbuild test robot reports: > > > > > > >> ERROR: "i2c_mux_add_adapter" [drivers/gpu/drm/bridge/sii902x.ko] > > > undefined! > > > >> ERROR: "i2c_mux_alloc" [drivers/gpu/drm/bridge/sii902x.ko] > > > undefined! > > > >> ERROR: "i2c_mux_del_adapters" [drivers/gpu/drm/bridge/sii902x.ko] > > > undefined! > > > > > > Quite obviously the driver depends on I2C_MUX, but adding a "depends on" > > > introduces a recursive dependency, therefore this patch selects I2C_MUX > > > instead. > > > > > > > You need a fixes tag here: > > > > Fixes: 21d808405fe4 ("drm/bridge/sii902x: Fix EDID readback") > > Thank you for spotting this, I'll send a v2 right away. Looks like you didn't change the subject in your v2. > > Cheers, > Fab > > > > > Thanks, > > > > Boris > > > > > Signed-off-by: Fabrizio Castro > > > Link: https://lists.01.org/pipermail/kbuild-all/2018-November/054924.html > > > --- > > > drivers/gpu/drm/bridge/Kconfig | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig > > > index 9eeb8ef..2fee47b 100644 > > > --- a/drivers/gpu/drm/bridge/Kconfig > > > +++ b/drivers/gpu/drm/bridge/Kconfig > > > @@ -95,6 +95,7 @@ config DRM_SII902X > > > depends on OF > > > select DRM_KMS_HELPER > > > select REGMAP_I2C > > > +select I2C_MUX > > > ---help--- > > > Silicon Image sii902x bridge chip driver. > > > > > > > > Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH] drm/bridge: Fix 0-day build error Date: Mon, 19 Nov 2018 14:22:48 +0100 Message-ID: <20181119142248.2135fbda@bbrezillon> References: <1542631463-21177-1-git-send-email-fabrizio.castro@bp.renesas.com> <20181119135104.75a0a075@bbrezillon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.bootlin.com (mail.bootlin.com [62.4.15.54]) by gabe.freedesktop.org (Postfix) with ESMTP id 5D9DA89A76 for ; Mon, 19 Nov 2018 13:22:50 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Fabrizio Castro Cc: Geert Uytterhoeven , David Airlie , Chris Paterson , "dri-devel@lists.freedesktop.org" , Biju Das , "linux-renesas-soc@vger.kernel.org" , Simon Horman , Laurent Pinchart , Peter Rosin List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCAxOSBOb3YgMjAxOCAxMzowOToxNiArMDAwMApGYWJyaXppbyBDYXN0cm8gPGZhYnJp emlvLmNhc3Ryb0BicC5yZW5lc2FzLmNvbT4gd3JvdGU6Cgo+IEhpIEJvcmlzLAo+IAo+ID4gRnJv bTogQm9yaXMgQnJlemlsbG9uIDxib3Jpcy5icmV6aWxsb25AYm9vdGxpbi5jb20+Cj4gPiBTZW50 OiAxOSBOb3ZlbWJlciAyMDE4IDEyOjUxCj4gPiBTdWJqZWN0OiBSZTogW1BBVENIXSBkcm0vYnJp ZGdlOiBGaXggMC1kYXkgYnVpbGQgZXJyb3IKPiA+Cj4gPiBIaSBGYWJyaXppbywKPiA+Cj4gPiBU aGUgcHJlZml4IHNob3VsZCBiZSAiZHJtL2JyaWRnZS9zaWk5MDJ4OiIgYW5kIEknZCBwcmVmZXIg YSBzaG9ydAo+ID4gZXhwbGFuYXRpb24gb2Ygd2hhdCBpcyBwcm9ibGVtYXRpYyBpbiB0aGUgc3Vi amVjdCByYXRoZXIgdGhhbiAiRml4Cj4gPiAwLWRheSBidWlsZCBlcnJvciIuIE1heWJlIHNvbWV0 aGluZyBsaWtlCj4gPgo+ID4gImRybS9icmlkZ2Uvc2lpOTAyeDogQWRkIG1pc3NpbmcgZGVwZW5k ZW5jeSBvbiBJMkNfTVVYIgo+ID4KPiA+IE9uIE1vbiwgMTkgTm92IDIwMTggMTI6NDQ6MjMgKzAw MDAKPiA+IEZhYnJpemlvIENhc3RybyA8ZmFicml6aW8uY2FzdHJvQGJwLnJlbmVzYXMuY29tPiB3 cm90ZToKPiA+ICAKPiA+ID4ga2J1aWxkIHRlc3Qgcm9ib3QgcmVwb3J0czoKPiA+ID4gIAo+ID4g PiA+PiBFUlJPUjogImkyY19tdXhfYWRkX2FkYXB0ZXIiIFtkcml2ZXJzL2dwdS9kcm0vYnJpZGdl L3NpaTkwMngua29dICAKPiA+ID4gdW5kZWZpbmVkISAgCj4gPiA+ID4+IEVSUk9SOiAiaTJjX211 eF9hbGxvYyIgW2RyaXZlcnMvZ3B1L2RybS9icmlkZ2Uvc2lpOTAyeC5rb10gIAo+ID4gPiB1bmRl ZmluZWQhICAKPiA+ID4gPj4gRVJST1I6ICJpMmNfbXV4X2RlbF9hZGFwdGVycyIgW2RyaXZlcnMv Z3B1L2RybS9icmlkZ2Uvc2lpOTAyeC5rb10gIAo+ID4gPiB1bmRlZmluZWQhCj4gPiA+Cj4gPiA+ IFF1aXRlIG9idmlvdXNseSB0aGUgZHJpdmVyIGRlcGVuZHMgb24gSTJDX01VWCwgYnV0IGFkZGlu ZyBhICJkZXBlbmRzIG9uIgo+ID4gPiBpbnRyb2R1Y2VzIGEgcmVjdXJzaXZlIGRlcGVuZGVuY3ks IHRoZXJlZm9yZSB0aGlzIHBhdGNoIHNlbGVjdHMgSTJDX01VWAo+ID4gPiBpbnN0ZWFkLgo+ID4g PiAgCj4gPgo+ID4gWW91IG5lZWQgYSBmaXhlcyB0YWcgaGVyZToKPiA+Cj4gPiBGaXhlczogMjFk ODA4NDA1ZmU0ICgiZHJtL2JyaWRnZS9zaWk5MDJ4OiBGaXggRURJRCByZWFkYmFjayIpICAKPiAK PiBUaGFuayB5b3UgZm9yIHNwb3R0aW5nIHRoaXMsIEknbGwgc2VuZCBhIHYyIHJpZ2h0IGF3YXku CgpMb29rcyBsaWtlIHlvdSBkaWRuJ3QgY2hhbmdlIHRoZSBzdWJqZWN0IGluIHlvdXIgdjIuCgo+ IAo+IENoZWVycywKPiBGYWIKPiAKPiA+Cj4gPiBUaGFua3MsCj4gPgo+ID4gQm9yaXMKPiA+ICAK PiA+ID4gU2lnbmVkLW9mZi1ieTogRmFicml6aW8gQ2FzdHJvIDxmYWJyaXppby5jYXN0cm9AYnAu cmVuZXNhcy5jb20+Cj4gPiA+IExpbms6IGh0dHBzOi8vbGlzdHMuMDEub3JnL3BpcGVybWFpbC9r YnVpbGQtYWxsLzIwMTgtTm92ZW1iZXIvMDU0OTI0Lmh0bWwKPiA+ID4gLS0tCj4gPiA+ICBkcml2 ZXJzL2dwdS9kcm0vYnJpZGdlL0tjb25maWcgfCAxICsKPiA+ID4gIDEgZmlsZSBjaGFuZ2VkLCAx IGluc2VydGlvbigrKQo+ID4gPgo+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2Jy aWRnZS9LY29uZmlnIGIvZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9LY29uZmlnCj4gPiA+IGluZGV4 IDllZWI4ZWYuLjJmZWU0N2IgMTAwNjQ0Cj4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9icmlk Z2UvS2NvbmZpZwo+ID4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL0tjb25maWcKPiA+ ID4gQEAgLTk1LDYgKzk1LDcgQEAgY29uZmlnIERSTV9TSUk5MDJYCj4gPiA+ICBkZXBlbmRzIG9u IE9GCj4gPiA+ICBzZWxlY3QgRFJNX0tNU19IRUxQRVIKPiA+ID4gIHNlbGVjdCBSRUdNQVBfSTJD Cj4gPiA+ICtzZWxlY3QgSTJDX01VWAo+ID4gPiAgLS0taGVscC0tLQo+ID4gPiAgICBTaWxpY29u IEltYWdlIHNpaTkwMnggYnJpZGdlIGNoaXAgZHJpdmVyLgo+ID4gPiAgCj4gCj4gCj4gCj4gCj4g UmVuZXNhcyBFbGVjdHJvbmljcyBFdXJvcGUgTHRkLCBEdWtlcyBNZWFkb3csIE1pbGxib2FyZCBS b2FkLCBCb3VybmUgRW5kLCBCdWNraW5naGFtc2hpcmUsIFNMOCA1RkgsIFVLLiBSZWdpc3RlcmVk IGluIEVuZ2xhbmQgJiBXYWxlcyB1bmRlciBSZWdpc3RlcmVkIE5vLiAwNDU4NjcwOS4KCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWls aW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=