From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Roberto Sassu <roberto.sassu@huawei.com>
Cc: zohar@linux.ibm.com, david.safford@ge.com, monty.wiseman@ge.com,
linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, silviu.vlasceanu@huawei.com
Subject: Re: [PATCH v5 7/7] tpm: pass an array of tpm_bank_list structures to tpm_pcr_extend()
Date: Mon, 19 Nov 2018 16:42:56 +0200 [thread overview]
Message-ID: <20181119144256.GI8755@linux.intel.com> (raw)
In-Reply-To: <5dd9fc97-2fb8-0e17-9ae0-88ce8db83903@huawei.com>
On Mon, Nov 19, 2018 at 09:22:32AM +0100, Roberto Sassu wrote:
> On 11/18/2018 8:29 AM, Jarkko Sakkinen wrote:
> > On Fri, Nov 16, 2018 at 04:55:36PM +0100, Roberto Sassu wrote:
> > > I understood from a previous email that you want to include all API
> > > changes for crypto agility in the same patch set.
> >
> > Hmm.. maybe there is some misunderstading. Can you point me to the
> > comment? Thanks.
>
> ---
> On Thu, Nov 08, 2018 at 03:24:46PM +0100, Roberto Sassu wrote:
> > Should I include the patch for tpm_pcr_extend() in this patch set, even
> > if the set fixes the digest size issue?
>
> Just add some note to the cover letter. Makes sense here to have a
> prequel patch for that because otherwise the implementation will be
> a bit messy and half-baked.
Ok, I guess it is OK as long as IMA (namely Mimi) gives that patch
reviewed-by. It is not a huge change.
PS. I noticed that earlier patches have postfixes like '_struct' and
'_ptr' for function arguments. Can you remove them in the next version?
/Jarkko
prev parent reply other threads:[~2018-11-19 14:43 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-14 15:31 [PATCH v5 0/7] tpm: retrieve digest size of unknown algorithms from TPM Roberto Sassu
2018-11-14 15:31 ` [PATCH v5 1/7] tpm: dynamically allocate the allocated_banks array Roberto Sassu
2018-11-16 13:36 ` Jarkko Sakkinen
2018-11-14 15:31 ` [PATCH v5 2/7] tpm: remove definition of TPM2_ACTIVE_PCR_BANKS Roberto Sassu
2018-11-16 13:38 ` Jarkko Sakkinen
2018-11-28 7:50 ` Roberto Sassu
2018-11-28 12:17 ` Roberto Sassu
2018-11-29 12:04 ` Roberto Sassu
2018-11-30 19:41 ` Jarkko Sakkinen
2018-11-30 19:45 ` Jarkko Sakkinen
2018-11-30 22:18 ` Jarkko Sakkinen
2018-12-03 9:59 ` Roberto Sassu
2018-12-03 17:31 ` Jarkko Sakkinen
2018-11-14 15:31 ` [PATCH v5 3/7] tpm: rename and export tpm2_digest and tpm2_algorithms Roberto Sassu
2018-11-14 15:31 ` [PATCH v5 4/7] tpm: modify tpm_pcr_read() definition to pass a TPM hash algorithm Roberto Sassu
2018-11-16 13:41 ` Jarkko Sakkinen
2018-11-14 15:31 ` [PATCH v5 5/7] tpm: retrieve digest size of unknown algorithms with PCR read Roberto Sassu
2018-11-14 15:31 ` [PATCH v5 6/7] tpm: ensure that the output of PCR read contains the correct digest size Roberto Sassu
2018-11-16 13:41 ` Jarkko Sakkinen
2018-11-16 16:06 ` Roberto Sassu
2018-11-18 7:32 ` Jarkko Sakkinen
2018-11-19 8:14 ` Roberto Sassu
2018-11-19 14:33 ` Jarkko Sakkinen
2018-11-19 15:09 ` Roberto Sassu
2018-11-19 16:07 ` Jarkko Sakkinen
2018-11-28 8:40 ` Roberto Sassu
2018-11-28 19:19 ` Jarkko Sakkinen
2018-11-14 15:31 ` [PATCH v5 7/7] tpm: pass an array of tpm_bank_list structures to tpm_pcr_extend() Roberto Sassu
2018-11-16 15:03 ` Jarkko Sakkinen
2018-11-16 15:55 ` Roberto Sassu
2018-11-18 7:27 ` Jarkko Sakkinen
2018-11-19 4:57 ` Mimi Zohar
2018-11-19 8:16 ` Roberto Sassu
2018-11-19 14:33 ` Mimi Zohar
2018-11-19 14:39 ` Jarkko Sakkinen
2018-11-18 7:29 ` Jarkko Sakkinen
2018-11-19 8:22 ` Roberto Sassu
2018-11-19 14:42 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181119144256.GI8755@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=david.safford@ge.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=monty.wiseman@ge.com \
--cc=roberto.sassu@huawei.com \
--cc=silviu.vlasceanu@huawei.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.