From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a5d:6089:0:0:0:0:0 with SMTP id w9csp988253wrt; Mon, 19 Nov 2018 07:31:39 -0800 (PST) X-Google-Smtp-Source: AJdET5cXj7oKrK7NM1jDvWRGqri541cg5dHGdlbl//XRlUtBC8htsF/0/GDkz15tIWbsi4fpnN/l X-Received: by 2002:a81:3753:: with SMTP id e80mr11788522ywa.505.1542641499365; Mon, 19 Nov 2018 07:31:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542641499; cv=none; d=google.com; s=arc-20160816; b=ecH+7Qv6eU3DjH5KGE7mmUNvYaVUTyKJ8jlqPk1XwmOvtl8TVr9jeK9d3w4wP2rXs9 SgFP5UjCn5w7r7P9FPmTZPJzN1TJoFfb0leiwzFiYY2LlL7+TpdVPbnGBVolevM1wsVh A7R/vcigQU0/PTtLCNHlFvpM8LQJhhsJT/rbckRtOpy0VBtB7Co9r0FY6GBRtWXcMKN8 9HWIcPDgnSpARdY8lNsgOi4yJVFk1WiJaZe/0iprq6NZw2Rd7dBvZ5LFo5Aan6iYjTNz c/PGCnDwbf3vgrmTP5YPABfb7mDAfA09Il4qmA/ycV6lP4IK4ImHQ+sjfqmfPfYPO7dH O9bQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:to:from:date; bh=sP5zpnyU+5T97IC7TXYTj0TbRfsd2fXF0WWJEY+BRDI=; b=TtjqLpXi53LrHaVWSZi6noEXISwQDaS8Au6fobdrVHEA3IMehkWIo3cc8qM64zQj1A yegRKSRhZ96Rd46p6sAtS1KWEPwmrysGF6tVdqIc9w7yhSmcWMuqNg5KejMlTqL/Ppju M2GBbyqDowPPV95i3JRvXJatRCzdrc0UVmaDKqeIyxfT1MC0gJJ9jJ1QmhlaFvX+0KK+ Og6YLABsNvOJ/S1vL5UidbXWvJrlxI0kgE8IDcwZI+jCfBfI0NiaChudi3Y/+jA6Cvph uTgdAB4Fd1kJCnBdGA7flYqrdN5tZFJY2udq8ds6bMM4Pk9P7fPSrQV5y2OrCk9EpXA9 nxrw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id c10-v6si24641768ybm.200.2018.11.19.07.31.39 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 19 Nov 2018 07:31:39 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:57225 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gOlWU-0003mC-Q4 for alex.bennee@linaro.org; Mon, 19 Nov 2018 10:31:38 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36106) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gOlWG-0003lF-8X for qemu-arm@nongnu.org; Mon, 19 Nov 2018 10:31:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gOlWA-0006DV-HH for qemu-arm@nongnu.org; Mon, 19 Nov 2018 10:31:24 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48404) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gOlWA-0006D5-95; Mon, 19 Nov 2018 10:31:18 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D643E3082A33; Mon, 19 Nov 2018 15:31:16 +0000 (UTC) Received: from localhost (unknown [10.43.2.182]) by smtp.corp.redhat.com (Postfix) with ESMTP id 62402177B0; Mon, 19 Nov 2018 15:31:12 +0000 (UTC) Date: Mon, 19 Nov 2018 16:31:10 +0100 From: Igor Mammedov To: Paolo Bonzini Message-ID: <20181119163110.2f357f40@redhat.com> In-Reply-To: References: <20181105014047.26447-1-sameo@linux.intel.com> <20181116172919.43f3e27d@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Mon, 19 Nov 2018 15:31:17 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-arm] [Qemu-devel] [PATCH v5 00/24] ACPI reorganization for hardware-reduced API addition X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Stefano Stabellini , Samuel Ortiz , "Michael S. Tsirkin" , qemu-devel@nongnu.org, Shannon Zhao , qemu-arm@nongnu.org, Anthony Perard , xen-devel@lists.xenproject.org, Richard Henderson , Eduardo Habkost Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: +q4j2xF5bUWB On Fri, 16 Nov 2018 17:37:54 +0100 Paolo Bonzini wrote: > On 16/11/18 17:29, Igor Mammedov wrote: > > General suggestions for this series: > > 1. Preferably don't do multiple changes within a patch > > neither post huge patches (unless it's pure code movement). > > (it's easy to squash patches later it necessary) > > 2. Start small, pick a table generalize it and send as > > one small patchset. Tables are often independent > > and it's much easier on both author/reviewer to agree upon > > changes and rewrite it if necessary. > > How would that be done? This series is on the bigger side, agreed, but > most of it is really just code movement. It's a starting point, having > a generic ACPI library is way beyond what this is trying to do. I've tried to give suggestions how to restructure series on per patch basis. In my opinion it quite possible to split series in several smaller ones and it should really help with making series cleaner and easier/faster to review/amend/merge vs what we have in v5. (it's more frustrating to rework large series vs smaller one) If something isn't clear, it's easy to reach out to me here or directly (email/irc/github) for clarification/feed back. > > Paolo > > > 3. when you think about refactoring acpi into a generic API > > think about it as routines that go into a separate library > > (pure acpi spec code) and qemu/acpi glue routines and > > divide them correspondingly. > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Igor Mammedov Subject: Re: [Qemu-devel] [PATCH v5 00/24] ACPI reorganization for hardware-reduced API addition Date: Mon, 19 Nov 2018 16:31:10 +0100 Message-ID: <20181119163110.2f357f40@redhat.com> References: <20181105014047.26447-1-sameo@linux.intel.com> <20181116172919.43f3e27d@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1gOlWA-0000FF-Th for xen-devel@lists.xenproject.org; Mon, 19 Nov 2018 15:31:18 +0000 In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Paolo Bonzini Cc: Peter Maydell , Stefano Stabellini , Samuel Ortiz , "Michael S. Tsirkin" , qemu-devel@nongnu.org, Shannon Zhao , qemu-arm@nongnu.org, Anthony Perard , xen-devel@lists.xenproject.org, Richard Henderson , Eduardo Habkost List-Id: xen-devel@lists.xenproject.org T24gRnJpLCAxNiBOb3YgMjAxOCAxNzozNzo1NCArMDEwMApQYW9sbyBCb256aW5pIDxwYm9uemlu aUByZWRoYXQuY29tPiB3cm90ZToKCj4gT24gMTYvMTEvMTggMTc6MjksIElnb3IgTWFtbWVkb3Yg d3JvdGU6Cj4gPiBHZW5lcmFsIHN1Z2dlc3Rpb25zIGZvciB0aGlzIHNlcmllczoKPiA+ICAgMS4g UHJlZmVyYWJseSBkb24ndCBkbyBtdWx0aXBsZSBjaGFuZ2VzIHdpdGhpbiBhIHBhdGNoCj4gPiAg ICAgIG5laXRoZXIgcG9zdCBodWdlIHBhdGNoZXMgKHVubGVzcyBpdCdzIHB1cmUgY29kZSBtb3Zl bWVudCkuCj4gPiAgICAgIChpdCdzIGVhc3kgdG8gc3F1YXNoIHBhdGNoZXMgbGF0ZXIgaXQgbmVj ZXNzYXJ5KQo+ID4gICAyLiBTdGFydCBzbWFsbCwgcGljayBhIHRhYmxlIGdlbmVyYWxpemUgaXQg YW5kIHNlbmQgYXMKPiA+ICAgICAgb25lIHNtYWxsIHBhdGNoc2V0LiBUYWJsZXMgYXJlIG9mdGVu IGluZGVwZW5kZW50Cj4gPiAgICAgIGFuZCBpdCdzIG11Y2ggZWFzaWVyIG9uIGJvdGggYXV0aG9y L3Jldmlld2VyIHRvIGFncmVlIHVwb24KPiA+ICAgICAgY2hhbmdlcyBhbmQgcmV3cml0ZSBpdCBp ZiBuZWNlc3NhcnkuICAKPiAKPiBIb3cgd291bGQgdGhhdCBiZSBkb25lPyAgVGhpcyBzZXJpZXMg aXMgb24gdGhlIGJpZ2dlciBzaWRlLCBhZ3JlZWQsIGJ1dAo+IG1vc3Qgb2YgaXQgaXMgcmVhbGx5 IGp1c3QgY29kZSBtb3ZlbWVudC4gIEl0J3MgYSBzdGFydGluZyBwb2ludCwgaGF2aW5nCj4gYSBn ZW5lcmljIEFDUEkgbGlicmFyeSBpcyB3YXkgYmV5b25kIHdoYXQgdGhpcyBpcyB0cnlpbmcgdG8g ZG8uCkkndmUgdHJpZWQgdG8gZ2l2ZSBzdWdnZXN0aW9ucyBob3cgdG8gcmVzdHJ1Y3R1cmUgc2Vy aWVzCm9uIHBlciBwYXRjaCBiYXNpcy4gSW4gbXkgb3BpbmlvbiBpdCBxdWl0ZSBwb3NzaWJsZSB0 byBzcGxpdApzZXJpZXMgaW4gc2V2ZXJhbCBzbWFsbGVyIG9uZXMgYW5kIGl0IHNob3VsZCByZWFs bHkgaGVscCB3aXRoCm1ha2luZyBzZXJpZXMgY2xlYW5lciBhbmQgZWFzaWVyL2Zhc3RlciB0byBy ZXZpZXcvYW1lbmQvbWVyZ2UKdnMgd2hhdCB3ZSBoYXZlIGluIHY1LgooaXQncyBtb3JlIGZydXN0 cmF0aW5nIHRvIHJld29yayBsYXJnZSBzZXJpZXMgdnMgc21hbGxlciBvbmUpCgpJZiBzb21ldGhp bmcgaXNuJ3QgY2xlYXIsIGl0J3MgZWFzeSB0byByZWFjaCBvdXQgdG8gbWUgaGVyZQpvciBkaXJl Y3RseSAoZW1haWwvaXJjL2dpdGh1YikgZm9yIGNsYXJpZmljYXRpb24vZmVlZCBiYWNrLgoKPiAK PiBQYW9sbwo+IAo+ID4gICAzLiB3aGVuIHlvdSB0aGluayBhYm91dCByZWZhY3RvcmluZyBhY3Bp IGludG8gYSBnZW5lcmljIEFQSQo+ID4gICAgICB0aGluayBhYm91dCBpdCBhcyByb3V0aW5lcyB0 aGF0IGdvIGludG8gYSBzZXBhcmF0ZSBsaWJyYXJ5Cj4gPiAgICAgIChwdXJlIGFjcGkgc3BlYyBj b2RlKSBhbmQgcWVtdS9hY3BpIGdsdWUgcm91dGluZXMgYW5kCj4gPiAgICAgICBkaXZpZGUgdGhl bSBjb3JyZXNwb25kaW5nbHkuICAKPiAKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54 ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGlu Zm8veGVuLWRldmVs From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36143) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gOlWM-0003nW-JY for qemu-devel@nongnu.org; Mon, 19 Nov 2018 10:31:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gOlWH-0006H9-5A for qemu-devel@nongnu.org; Mon, 19 Nov 2018 10:31:30 -0500 Date: Mon, 19 Nov 2018 16:31:10 +0100 From: Igor Mammedov Message-ID: <20181119163110.2f357f40@redhat.com> In-Reply-To: References: <20181105014047.26447-1-sameo@linux.intel.com> <20181116172919.43f3e27d@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 00/24] ACPI reorganization for hardware-reduced API addition List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Samuel Ortiz , qemu-devel@nongnu.org, Peter Maydell , Stefano Stabellini , Eduardo Habkost , "Michael S. Tsirkin" , Shannon Zhao , qemu-arm@nongnu.org, Anthony Perard , xen-devel@lists.xenproject.org, Richard Henderson On Fri, 16 Nov 2018 17:37:54 +0100 Paolo Bonzini wrote: > On 16/11/18 17:29, Igor Mammedov wrote: > > General suggestions for this series: > > 1. Preferably don't do multiple changes within a patch > > neither post huge patches (unless it's pure code movement). > > (it's easy to squash patches later it necessary) > > 2. Start small, pick a table generalize it and send as > > one small patchset. Tables are often independent > > and it's much easier on both author/reviewer to agree upon > > changes and rewrite it if necessary. > > How would that be done? This series is on the bigger side, agreed, but > most of it is really just code movement. It's a starting point, having > a generic ACPI library is way beyond what this is trying to do. I've tried to give suggestions how to restructure series on per patch basis. In my opinion it quite possible to split series in several smaller ones and it should really help with making series cleaner and easier/faster to review/amend/merge vs what we have in v5. (it's more frustrating to rework large series vs smaller one) If something isn't clear, it's easy to reach out to me here or directly (email/irc/github) for clarification/feed back. > > Paolo > > > 3. when you think about refactoring acpi into a generic API > > think about it as routines that go into a separate library > > (pure acpi spec code) and qemu/acpi glue routines and > > divide them correspondingly. >