From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH v2 2/3] drm/i915: Make EDP PSR flags not
 depend on enum values
Date: Mon, 19 Nov 2018 22:58:35 +0200
Message-ID: <20181119205835.GQ9144@intel.com>
References: <20181119144109.12994-2-imre.deak@intel.com>
 <20181119204637.6748-1-imre.deak@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 904766E27D
 for <intel-gfx@lists.freedesktop.org>; Mon, 19 Nov 2018 20:58:39 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20181119204637.6748-1-imre.deak@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Imre Deak <imre.deak@intel.com>
Cc: intel-gfx@lists.freedesktop.org, Lucas De Marchi <lucas.demarchi@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

T24gTW9uLCBOb3YgMTksIDIwMTggYXQgMTA6NDY6MzdQTSArMDIwMCwgSW1yZSBEZWFrIHdyb3Rl
Ogo+IERlcGVuZGluZyBvbiB0aGUgdHJhbnNjb2RlciBlbnVtIHZhbHVlcyB0byB0cmFuc2xhdGUg
ZnJvbSB0cmFuc2NvZGVyCj4gdG8gRURQIFBTUiBmbGFncyBjYW4gZWFzaWx5IGJyZWFrIGlmIHdl
IGFkZCBhIG5ldyB0cmFuc2NvZGVyLiBTbyByZW1vdmUKPiB0aGUgZGVwZW5kZW5jeSBieSB1c2lu
ZyBhbiBleHBsaWNpdCBtYXBwaW5nLgo+IAo+IFdoaWxlIGF0IGl0IGFsc28gYWRkIGEgV0FSTiBm
b3IgdW5leHBlY3RlZCB0cmFuY29kZXJzLgo+IAo+IHYyOgo+IC0gU2ltcGxpZnkgdGhpbmdzIGJ5
IGRlZmluaW5nIGZsYWcgc2hpZnQgdmFsdWVzIGluc3RlYWQgb2YgaW5kaWNlcy4KPiAtIHMvdHJh
bnMvY3B1X3RyYW5zY29kZXIvIChWaWxsZSkKPiAKPiBDYzogVmlsbGUgU3lyasOkbMOkIDx2aWxs
ZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiBDYzogTHVjYXMgRGUgTWFyY2hpIDxsdWNhcy5k
ZW1hcmNoaUBpbnRlbC5jb20+Cj4gQ2M6IE1pa2EgS2Fob2xhIDxtaWthLmthaG9sYUBpbnRlbC5j
b20+Cj4gU2lnbmVkLW9mZi1ieTogSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwuY29tPgo+IC0t
LQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oICB8IDEwICsrKysrLS0tCj4gIGRy
aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5jIHwgNTUgKysrKysrKysrKysrKysrKysrKysr
KysrKysrLS0tLS0tLS0tLS0tLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDQ0IGluc2VydGlvbnMoKyks
IDIxIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p
OTE1X3JlZy5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaAo+IGluZGV4IGVkYjU4
YWYxZTkwMy4uZjgwYjE2ZTNmZjMzIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1
L2k5MTVfcmVnLmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oCj4gQEAg
LTQxNTAsOSArNDE1MCwxMyBAQCBlbnVtIHsKPiAgLyogQnNwZWMgY2xhaW1zIHRob3NlIGFyZW4n
dCBzaGlmdGVkIGJ1dCBzdGF5IGF0IDB4NjQ4MDAgKi8KPiAgI2RlZmluZSBFRFBfUFNSX0lNUgkJ
CQlfTU1JTygweDY0ODM0KQo+ICAjZGVmaW5lIEVEUF9QU1JfSUlSCQkJCV9NTUlPKDB4NjQ4Mzgp
Cj4gLSNkZWZpbmUgICBFRFBfUFNSX0VSUk9SKHRyYW5zKQkJCSgxIDw8ICgoKHRyYW5zKSAqIDgg
KyAxMCkgJiAzMSkpCj4gLSNkZWZpbmUgICBFRFBfUFNSX1BPU1RfRVhJVCh0cmFucykJCSgxIDw8
ICgoKHRyYW5zKSAqIDggKyA5KSAmIDMxKSkKPiAtI2RlZmluZSAgIEVEUF9QU1JfUFJFX0VOVFJZ
KHRyYW5zKQkJKDEgPDwgKCgodHJhbnMpICogOCArIDgpICYgMzEpKQo+ICsjZGVmaW5lICAgRURQ
X1BTUl9FUlJPUihzaGlmdCkJCQkoNCA8PCAoc2hpZnQpKQo+ICsjZGVmaW5lICAgRURQX1BTUl9Q
T1NUX0VYSVQoc2hpZnQpCQkoMiA8PCAoc2hpZnQpKQo+ICsjZGVmaW5lICAgRURQX1BTUl9QUkVf
RU5UUlkoc2hpZnQpCQkoMSA8PCAoc2hpZnQpKQoKVGhlIDEsMiw0IHN1Z2dlc3QgdGhhdCB0aGVz
ZSBhcmUgdmFsdWVzIGZvciB0aGUgc2FtZSBiaXRmaWVsZCwgd2hpY2gKdGhleSBhcmUgbm90LiBT
byBJIHdvdWxkIHByZWZlciAxPDwoKHNoaWZ0KStuKSBldGMuIGluc3RlYWQuCgpSZXZpZXdlZC1i
eTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KCj4gKyNk
ZWZpbmUgICBFRFBfUFNSX1RSQU5TQ09ERVJfQ19TSElGVAkJMjQKPiArI2RlZmluZSAgIEVEUF9Q
U1JfVFJBTlNDT0RFUl9CX1NISUZUCQkxNgo+ICsjZGVmaW5lICAgRURQX1BTUl9UUkFOU0NPREVS
X0FfU0hJRlQJCTgKPiArI2RlZmluZSAgIEVEUF9QU1JfVFJBTlNDT0RFUl9FRFBfU0hJRlQJCTAK
PiAgCj4gICNkZWZpbmUgRURQX1BTUl9BVVhfQ1RMCQkJCV9NTUlPKGRldl9wcml2LT5wc3JfbW1p
b19iYXNlICsgMHgxMCkKPiAgI2RlZmluZSAgIEVEUF9QU1JfQVVYX0NUTF9USU1FX09VVF9NQVNL
CQkoMyA8PCAyNikKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNy
LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wc3IuYwo+IGluZGV4IDQ4ZGYxNmEwMmZh
Yy4uMjYyOTI5NjFkNjkzIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs
X3Bzci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMKPiBAQCAtODMs
MjUgKzgzLDQyIEBAIHN0YXRpYyBib29sIGludGVsX3BzcjJfZW5hYmxlZChzdHJ1Y3QgZHJtX2k5
MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAl9Cj4gIH0KPiAgCj4gK3N0YXRpYyBpbnQgZWRwX3Bz
cl9zaGlmdChlbnVtIHRyYW5zY29kZXIgY3B1X3RyYW5zY29kZXIpCj4gK3sKPiArCXN3aXRjaCAo
Y3B1X3RyYW5zY29kZXIpIHsKPiArCWNhc2UgVFJBTlNDT0RFUl9BOgo+ICsJCXJldHVybiBFRFBf
UFNSX1RSQU5TQ09ERVJfQV9TSElGVDsKPiArCWNhc2UgVFJBTlNDT0RFUl9COgo+ICsJCXJldHVy
biBFRFBfUFNSX1RSQU5TQ09ERVJfQl9TSElGVDsKPiArCWNhc2UgVFJBTlNDT0RFUl9DOgo+ICsJ
CXJldHVybiBFRFBfUFNSX1RSQU5TQ09ERVJfQ19TSElGVDsKPiArCWRlZmF1bHQ6Cj4gKwkJTUlT
U0lOR19DQVNFKGNwdV90cmFuc2NvZGVyKTsKPiArCQkvKiBmYWxsdGhyb3VnaCAqLwo+ICsJY2Fz
ZSBUUkFOU0NPREVSX0VEUDoKPiArCQlyZXR1cm4gRURQX1BTUl9UUkFOU0NPREVSX0VEUF9TSElG
VDsKPiArCX0KPiArfQo+ICsKPiAgdm9pZCBpbnRlbF9wc3JfaXJxX2NvbnRyb2woc3RydWN0IGRy
bV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LCB1MzIgZGVidWcpCj4gIHsKPiAgCXUzMiBkZWJ1Z19t
YXNrLCBtYXNrOwo+ICsJZW51bSB0cmFuc2NvZGVyIGNwdV90cmFuc2NvZGVyOwo+ICsJdTMyIHRy
YW5zY29kZXJzID0gQklUKFRSQU5TQ09ERVJfRURQKTsKPiAgCj4gLQltYXNrID0gRURQX1BTUl9F
UlJPUihUUkFOU0NPREVSX0VEUCk7Cj4gLQlkZWJ1Z19tYXNrID0gRURQX1BTUl9QT1NUX0VYSVQo
VFJBTlNDT0RFUl9FRFApIHwKPiAtCQkgICAgIEVEUF9QU1JfUFJFX0VOVFJZKFRSQU5TQ09ERVJf
RURQKTsKPiAtCj4gLQlpZiAoSU5URUxfR0VOKGRldl9wcml2KSA+PSA4KSB7Cj4gLQkJbWFzayB8
PSBFRFBfUFNSX0VSUk9SKFRSQU5TQ09ERVJfQSkgfAo+IC0JCQlFRFBfUFNSX0VSUk9SKFRSQU5T
Q09ERVJfQikgfAo+IC0JCQlFRFBfUFNSX0VSUk9SKFRSQU5TQ09ERVJfQyk7Cj4gLQo+IC0JCWRl
YnVnX21hc2sgfD0gRURQX1BTUl9QT1NUX0VYSVQoVFJBTlNDT0RFUl9BKSB8Cj4gLQkJCSAgICAg
IEVEUF9QU1JfUFJFX0VOVFJZKFRSQU5TQ09ERVJfQSkgfAo+IC0JCQkgICAgICBFRFBfUFNSX1BP
U1RfRVhJVChUUkFOU0NPREVSX0IpIHwKPiAtCQkJICAgICAgRURQX1BTUl9QUkVfRU5UUlkoVFJB
TlNDT0RFUl9CKSB8Cj4gLQkJCSAgICAgIEVEUF9QU1JfUE9TVF9FWElUKFRSQU5TQ09ERVJfQykg
fAo+IC0JCQkgICAgICBFRFBfUFNSX1BSRV9FTlRSWShUUkFOU0NPREVSX0MpOwo+ICsJaWYgKElO
VEVMX0dFTihkZXZfcHJpdikgPj0gOCkKPiArCQl0cmFuc2NvZGVycyB8PSBCSVQoVFJBTlNDT0RF
Ul9BKSB8Cj4gKwkJCSAgICAgICBCSVQoVFJBTlNDT0RFUl9CKSB8Cj4gKwkJCSAgICAgICBCSVQo
VFJBTlNDT0RFUl9DKTsKPiArCj4gKwlkZWJ1Z19tYXNrID0gMDsKPiArCW1hc2sgPSAwOwo+ICsJ
Zm9yX2VhY2hfY3B1X3RyYW5zY29kZXJfbWFza2VkKGRldl9wcml2LCBjcHVfdHJhbnNjb2Rlciwg
dHJhbnNjb2RlcnMpIHsKPiArCQlpbnQgc2hpZnQgPSBlZHBfcHNyX3NoaWZ0KGNwdV90cmFuc2Nv
ZGVyKTsKPiArCj4gKwkJbWFzayB8PSBFRFBfUFNSX0VSUk9SKHNoaWZ0KTsKPiArCQlkZWJ1Z19t
YXNrIHw9IEVEUF9QU1JfUE9TVF9FWElUKHNoaWZ0KSB8Cj4gKwkJCSAgICAgIEVEUF9QU1JfUFJF
X0VOVFJZKHNoaWZ0KTsKPiAgCX0KPiAgCj4gIAlpZiAoZGVidWcgJiBJOTE1X1BTUl9ERUJVR19J
UlEpCj4gQEAgLTE1OSwxOCArMTc2LDIwIEBAIHZvaWQgaW50ZWxfcHNyX2lycV9oYW5kbGVyKHN0
cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwgdTMyIHBzcl9paXIpCj4gIAkJCSAgICAg
ICBCSVQoVFJBTlNDT0RFUl9DKTsKPiAgCj4gIAlmb3JfZWFjaF9jcHVfdHJhbnNjb2Rlcl9tYXNr
ZWQoZGV2X3ByaXYsIGNwdV90cmFuc2NvZGVyLCB0cmFuc2NvZGVycykgewo+ICsJCWludCBzaGlm
dCA9IGVkcF9wc3Jfc2hpZnQoY3B1X3RyYW5zY29kZXIpOwo+ICsKPiAgCQkvKiBGSVhNRTogRXhp
dCBQU1IgYW5kIGxpbmsgdHJhaW4gbWFudWFsbHkgd2hlbiB0aGlzIGhhcHBlbnMuICovCj4gLQkJ
aWYgKHBzcl9paXIgJiBFRFBfUFNSX0VSUk9SKGNwdV90cmFuc2NvZGVyKSkKPiArCQlpZiAocHNy
X2lpciAmIEVEUF9QU1JfRVJST1Ioc2hpZnQpKQo+ICAJCQlEUk1fREVCVUdfS01TKCJbdHJhbnNj
b2RlciAlc10gUFNSIGF1eCBlcnJvclxuIiwKPiAgCQkJCSAgICAgIHRyYW5zY29kZXJfbmFtZShj
cHVfdHJhbnNjb2RlcikpOwo+ICAKPiAtCQlpZiAocHNyX2lpciAmIEVEUF9QU1JfUFJFX0VOVFJZ
KGNwdV90cmFuc2NvZGVyKSkgewo+ICsJCWlmIChwc3JfaWlyICYgRURQX1BTUl9QUkVfRU5UUlko
c2hpZnQpKSB7Cj4gIAkJCWRldl9wcml2LT5wc3IubGFzdF9lbnRyeV9hdHRlbXB0ID0gdGltZV9u
czsKPiAgCQkJRFJNX0RFQlVHX0tNUygiW3RyYW5zY29kZXIgJXNdIFBTUiBlbnRyeSBhdHRlbXB0
IGluIDIgdmJsYW5rc1xuIiwKPiAgCQkJCSAgICAgIHRyYW5zY29kZXJfbmFtZShjcHVfdHJhbnNj
b2RlcikpOwo+ICAJCX0KPiAgCj4gLQkJaWYgKHBzcl9paXIgJiBFRFBfUFNSX1BPU1RfRVhJVChj
cHVfdHJhbnNjb2RlcikpIHsKPiArCQlpZiAocHNyX2lpciAmIEVEUF9QU1JfUE9TVF9FWElUKHNo
aWZ0KSkgewo+ICAJCQlkZXZfcHJpdi0+cHNyLmxhc3RfZXhpdCA9IHRpbWVfbnM7Cj4gIAkJCURS
TV9ERUJVR19LTVMoIlt0cmFuc2NvZGVyICVzXSBQU1IgZXhpdCBjb21wbGV0ZWRcbiIsCj4gIAkJ
CQkgICAgICB0cmFuc2NvZGVyX25hbWUoY3B1X3RyYW5zY29kZXIpKTsKPiAtLSAKPiAyLjEzLjIK
Ci0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMu
ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz
dGluZm8vaW50ZWwtZ2Z4Cg==