From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1gP6Cr-0005ZD-Uy for mharc-grub-devel@gnu.org; Tue, 20 Nov 2018 08:36:45 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44144) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gP3Wq-0003Do-S4 for grub-devel@gnu.org; Tue, 20 Nov 2018 05:45:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gP3Wn-0006gI-NI for grub-devel@gnu.org; Tue, 20 Nov 2018 05:45:12 -0500 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]:55886) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gP3Wn-0006as-8w for grub-devel@gnu.org; Tue, 20 Nov 2018 05:45:09 -0500 Received: by mail-wm1-x32a.google.com with SMTP id y139so1610431wmc.5 for ; Tue, 20 Nov 2018 02:45:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=pVFvPQLGI+17nYa5dLNr/pDt8XZhOiYkE1FkBmVV2BY=; b=avnJV8ByhvRAovg0rN6spEC2MLtSIi6aN4QegndQ8e/TnZnwVcldS0j+EHEuRb37Af a9A9q0f1Rlbb34jWDJ6q+eOUnP6Y89omyJzeWuDtuDwZoC73Qck4ims3dF7V2Q5IlKOI PH1AAmfOe0aAjM+CK3101g05xdzwgn8M3MhVY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=pVFvPQLGI+17nYa5dLNr/pDt8XZhOiYkE1FkBmVV2BY=; b=VxzIfsNWYowWSfnCEO7pgsZYKZ5rZ4NXfL3aZgGfNQDEdqQEm5LACAeUDySZgKQleL 9SUInlJW7zuhYzvhsLsoMPhsCksITB4qBqONPcP+Oalu1nvSeoqlxKgmtmSGudtTiUKe +grJbsJzejp952XcDiFIfrY/4Fy1vmkU1W6Z9JLbpwavB4bIhRZEgf3+h8niuS4Jn7dA X0kq0YubSwBkZfNd8YdEXYWlF1gzeUTZ0KQx3dHr7o867Xr7q7moXiPQeX4oHcp9/owW Zf1etUNjN22TonO2Ov6YLN0eniB4oKWm8v3PTMWDqBztbzbrQs9l6QwK0avvtNSADM1f RB+A== X-Gm-Message-State: AA+aEWYGA0QurR1hzh0aIGTpxlHH2ip1hpHoAKAlqYwHEeuqJzv8hBnp vaOwnc/bIRfqBVAykecGvmAI8A== X-Google-Smtp-Source: AJdET5fM4dwpUzotgf24iSZcgbnoS4TR+5qlp+pmCCr8CjkdTcGWSxl9hKbGH/RGEcU8C9X/Nc5b/A== X-Received: by 2002:a1c:3506:: with SMTP id c6-v6mr1659219wma.39.1542710707572; Tue, 20 Nov 2018 02:45:07 -0800 (PST) Received: from dell ([2.31.167.205]) by smtp.gmail.com with ESMTPSA id l15sm19915117wrw.4.2018.11.20.02.45.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 20 Nov 2018 02:45:06 -0800 (PST) Date: Tue, 20 Nov 2018 10:45:04 +0000 From: Lee Jones To: Daniel Kiper Cc: Fu Wei Fu , Leif Lindholm , The development of GNU GRUB , Julien Grall Subject: arm64/xen: Fix too few =?utf-8?Q?arguments?= =?utf-8?B?IHRvIGZ1bmN0aW9uIOKAmGdydWJfY3JlYXRlX2xvYWRlcl9jbWRsaW5l4oCZ?= Message-ID: <20181120104504.GM3513@dell> References: <20181114192919.24655-1-leif.lindholm@linaro.org> <20181116140737.wuox7v63y6lt2ymt@tomti.i.net-space.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20181116140737.wuox7v63y6lt2ymt@tomti.i.net-space.pl> User-Agent: Mutt/1.9.4 (2018-02-28) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::32a X-Mailman-Approved-At: Tue, 20 Nov 2018 08:36:40 -0500 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Nov 2018 10:45:18 -0000 From: Lee Jones arm64/xen: Fix too few arguments to function ‘grub_create_loader_cmdline’ Without this fix, building xen_boot.c omits: loader/arm64/xen_boot.c: In function ‘xen_boot_binary_load’: loader/arm64/xen_boot.c:370:7: error: too few arguments to function ‘grub_create_loader_cmdline’ grub_create_loader_cmdline (argc - 1, argv + 1, binary->cmdline, ^~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from loader/arm64/xen_boot.c:36:0: ../include/grub/lib/cmdline.h:29:12: note: declared here grub_err_t grub_create_loader_cmdline (int argc, char *argv[], char *buf, Signed-off-by: Lee Jones diff --git a/grub-core/loader/arm64/xen_boot.c b/grub-core/loader/arm64/xen_boot.c index 1003a0b99..33a855df4 100644 --- a/grub-core/loader/arm64/xen_boot.c +++ b/grub-core/loader/arm64/xen_boot.c @@ -368,7 +368,8 @@ xen_boot_binary_load (struct xen_boot_binary *binary, grub_file_t file, return; } grub_create_loader_cmdline (argc - 1, argv + 1, binary->cmdline, - binary->cmdline_size); + binary->cmdline_size, + GRUB_VERIFY_KERNEL_CMDLINE); grub_dprintf ("xen_loader", "Xen_boot cmdline @ %p %s, size: %d\n", binary->cmdline, binary->cmdline, binary->cmdline_size);