From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1gP6Cn-0005UY-9Y for mharc-grub-devel@gnu.org; Tue, 20 Nov 2018 08:36:41 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45277) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gP3aN-0004no-UM for grub-devel@gnu.org; Tue, 20 Nov 2018 05:48:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gP3aH-0005Hp-Tb for grub-devel@gnu.org; Tue, 20 Nov 2018 05:48:51 -0500 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]:50580) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gP3aH-0005DR-Lv for grub-devel@gnu.org; Tue, 20 Nov 2018 05:48:45 -0500 Received: by mail-wm1-x32b.google.com with SMTP id 125so1658639wmh.0 for ; Tue, 20 Nov 2018 02:48:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=RtTXPtXRXQiElWeCB7XEtJcMlfpS2++RxGEzOG8diM8=; b=hqTsBndzFt2uMnZYIlTdVKRpnWmuEoqSOqy0WuD7DFNdF5QC/Tlbb3rU2rJtlx4263 /Oj2IfpbuqWqY0ie8E3F5q7AjxxmQylVEFbpHkhzuet5sLzxpR6MWbHsavFse+r0la9u J3e10rWzDMz8P209Ch4Z+fJoBa2Lsm9lYg6pM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=RtTXPtXRXQiElWeCB7XEtJcMlfpS2++RxGEzOG8diM8=; b=mGKvPoSui9aRpYTdSiNOq7aaxAcuLX7PAcihzjYOSrlMJQ8+DMwWk1ss6mXL1CIsVz q1hW21LVadQrbMfC7zYh3BSEPaH5GZMhNRUlwFyfOH4mPoUD4it+XPXfHVJMMiIDlTa6 fQDzIy6Ft8myy1j7qJU1nwVhYNzQsbnm4Epqyu8/Lu+I2UJ+hssbE29Ud+nq+kNvkjRk Pqrjlhae2410L/cyBWTWkeptIb2Nqm6KSIUXzypWogNInyIMt1meOT5I95Y6AnujnQru bIfLZ3lBRTEt4e+3lJ4D1yfhz4O3II6NrVahD1GTII9ulndfySHD+ie1hqk39zZYtyvo x5iw== X-Gm-Message-State: AA+aEWYBGBUV1azxiq2c+gXPLo6FSupxpItlDXRB4q5+kmpZaBW56Bbm LT2ITQSe5w1q5XhijARgsfEGww== X-Google-Smtp-Source: AFSGD/VEvmUTZWtbvCyfoAIZfI82o+c8Cl5n2Q4VsIjcLzHAjIZnxI6jhT+sZ/OfIZDCbDnZU/0JkQ== X-Received: by 2002:a1c:6408:: with SMTP id y8mr1714690wmb.0.1542710922821; Tue, 20 Nov 2018 02:48:42 -0800 (PST) Received: from dell ([2.31.167.205]) by smtp.gmail.com with ESMTPSA id q2sm24276899wru.56.2018.11.20.02.48.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 20 Nov 2018 02:48:42 -0800 (PST) Date: Tue, 20 Nov 2018 10:48:40 +0000 From: Lee Jones To: Daniel Kiper Cc: Fu Wei Fu , Leif Lindholm , The development of GNU GRUB , Julien Grall Subject: arm64/xen: Fix too few =?utf-8?Q?arguments?= =?utf-8?B?IHRvIGZ1bmN0aW9uIOKAmGdydWJfZmlsZV9vcGVu4oCZ?= Message-ID: <20181120104840.GO3513@dell> References: <20181114192919.24655-1-leif.lindholm@linaro.org> <20181116140737.wuox7v63y6lt2ymt@tomti.i.net-space.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20181116140737.wuox7v63y6lt2ymt@tomti.i.net-space.pl> User-Agent: Mutt/1.9.4 (2018-02-28) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::32b X-Mailman-Approved-At: Tue, 20 Nov 2018 08:36:40 -0500 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Nov 2018 10:48:53 -0000 From: Lee Jones arm64/xen: Fix too few arguments to function ‘grub_file_open’ Without this fix xen_boot.c omits: loader/arm64/xen_boot.c: In function ‘grub_cmd_xen_module’: loader/arm64/xen_boot.c:424:10: error: too few arguments to function ‘grub_file_open’ file = grub_file_open (argv[0]); ^~~~~~~~~~~~~~ In file included from ../include/grub/cache.h:23:0, from loader/arm64/xen_boot.c:19: ../include/grub/file.h:204:25: note: declared here grub_file_t EXPORT_FUNC(grub_file_open) (const char *name, enum grub_file_type type); ^ ../include/grub/symbol.h:68:25: note: in definition of macro ‘EXPORT_FUNC’ # define EXPORT_FUNC(x) x ^ loader/arm64/xen_boot.c: In function ‘grub_cmd_xen_hypervisor’: loader/arm64/xen_boot.c:456:10: error: too few arguments to function ‘grub_file_open’ file = grub_file_open (argv[0]); ^~~~~~~~~~~~~~ Signed-off-by: Lee Jones diff --git a/grub-core/loader/arm64/xen_boot.c b/grub-core/loader/arm64/xen_boot.c index 5820412e8..1f49e3278 100644 --- a/grub-core/loader/arm64/xen_boot.c +++ b/grub-core/loader/arm64/xen_boot.c @@ -421,7 +421,7 @@ grub_cmd_xen_module (grub_command_t cmd __attribute__((unused)), grub_dprintf ("xen_loader", "Init module and node info\n"); - file = grub_file_open (argv[0]); + file = grub_file_open (argv[0], GRUB_FILE_TYPE_NONE); if (!file) goto fail; @@ -453,7 +453,7 @@ grub_cmd_xen_hypervisor (grub_command_t cmd __attribute__ ((unused)), goto fail; } - file = grub_file_open (argv[0]); + file = grub_file_open (argv[0], GRUB_FILE_TYPE_NONE); if (!file) goto fail;