From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1gP6Cs-0005Zk-D6 for mharc-grub-devel@gnu.org; Tue, 20 Nov 2018 08:36:46 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55849) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gP47G-00011a-LE for grub-devel@gnu.org; Tue, 20 Nov 2018 06:22:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gP47B-0006xH-NR for grub-devel@gnu.org; Tue, 20 Nov 2018 06:22:50 -0500 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]:56158) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gP47B-0006oi-H7 for grub-devel@gnu.org; Tue, 20 Nov 2018 06:22:45 -0500 Received: by mail-wm1-x32f.google.com with SMTP id y139so1727315wmc.5 for ; Tue, 20 Nov 2018 03:22:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=lXz7P8twP7q6s73MBDsSTHS0vcmW473+pm51YyabGTw=; b=chcMDRpOraHPlRdOuCSck9/rxX4FQSZ4XIdg3U06JLO8GxniU5o9dNREXu53SkP9AI r9hw0msLd+8tn2rqPSO15fUdpd0cb9I2vvGd4U/qAVCXXklaCznDQYzNJp9ULn2lJP2s HcR2SSMqOQQBZ8cXBnCckuEUaMFqwihryB2x0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=lXz7P8twP7q6s73MBDsSTHS0vcmW473+pm51YyabGTw=; b=leWRqT8+bepVHOVkRy/DeFJHx7JrG2BDrdu+TfBdzyfM/Yxu3GZ5SVbJ615n3UAem5 nCBAN4lfU/aTHAxXJBIAACtJi2TZvgubsOtnMGei1TVwND/vRSE/FHNvcRVKCd/Y8zyI e8FfzukETGmq+2vxUF3/hkLv7LqIRu2yCUfW/fbBhLiOkmHdF5aTes7seds4VsmWpMWy xPCHULNGkE9XOcI0b5n9DZ/4fak4s0WAqTc+W3R2KbosKpMDwtL3dppXmv56K9j+xI5w VftgjHn8uKrR2gVarAycaoS4jGTN9Rlsix8UOmeguR1EDHydndhfmr4a/ReBVaTGwdpT EvEA== X-Gm-Message-State: AGRZ1gLaHRy3mmc2tlw+uX1AVNaJRqUVYwSbJYP3H+8gEndK8vh3cKKy bT7Q4PqokCFxgv8Bk+cV4O+k3w== X-Google-Smtp-Source: AFSGD/UKauLe0mZItXDG37BD1Dr9qHdS1MEbEKgcpknX3oXVpkwT6EPkafCM6B+ZcJb0wRAmuFhE8w== X-Received: by 2002:a1c:8d86:: with SMTP id p128-v6mr1938328wmd.48.1542712964166; Tue, 20 Nov 2018 03:22:44 -0800 (PST) Received: from dell ([2.31.167.205]) by smtp.gmail.com with ESMTPSA id g129sm16270005wmf.39.2018.11.20.03.22.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 20 Nov 2018 03:22:43 -0800 (PST) Date: Tue, 20 Nov 2018 11:22:41 +0000 From: Lee Jones To: Julien Grall Cc: Daniel Kiper , Fu Wei Fu , Leif Lindholm , The development of GNU GRUB Subject: Re: arm64/xen: Fix implicit =?utf-8?Q?decl?= =?utf-8?Q?aration_of_function_=E2=80=98grub=5Ffile=5Ffilter=5Fdisable=5Fc?= =?utf-8?Q?ompression?= Message-ID: <20181120112241.GQ3513@dell> References: <20181114192919.24655-1-leif.lindholm@linaro.org> <20181116140737.wuox7v63y6lt2ymt@tomti.i.net-space.pl> <20181120104656.GN3513@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::32f X-Mailman-Approved-At: Tue, 20 Nov 2018 08:36:40 -0500 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Nov 2018 11:22:51 -0000 On Tue, 20 Nov 2018, Julien Grall wrote: > On 20/11/2018 10:46, Lee Jones wrote: > > From: Lee Jones > > > > arm64/xen: Fix implicit declaration of function ‘grub_file_filter_disable_compression > > This patch seems to drop support for --nounzip. Can you explain why? It only seemed to serve the invocation of grub_file_filter_disable_compression() which was removed in this patch. On closer inspection, I do see that argv/argc still needs to be shifted though. I will fix that. > Note that the option added on Arm64 to keep the compatibility with x86 > multiboot loading. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog