From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1gP6Cv-0005aB-EL for mharc-grub-devel@gnu.org; Tue, 20 Nov 2018 08:36:49 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60852) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gP4L9-0004xj-Le for grub-devel@gnu.org; Tue, 20 Nov 2018 06:37:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gP4L5-0005id-Nj for grub-devel@gnu.org; Tue, 20 Nov 2018 06:37:11 -0500 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]:38728) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gP4L5-0005hz-H0 for grub-devel@gnu.org; Tue, 20 Nov 2018 06:37:07 -0500 Received: by mail-wr1-x430.google.com with SMTP id e3-v6so1607373wrs.5 for ; Tue, 20 Nov 2018 03:37:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=q1xfoLs6rj+C66212gvJIj+lORQ3+kKj8tK+G5wP8jY=; b=fHC7PGH4EebNNqK/g7LMlMLrfpuJ/rDttp4mPgHDkEiuAA1Hdo5mkg8A8rvvLJ+m1o 2dJ82NznUvQtVXIKQVv376k7tej9JBGY+B61epyKWet0Yqoxx5V0xFxYybwiwQ8NatLt /YR9ziXr9mY70naq/+xIOy2DvcA723iaKD9Y0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=q1xfoLs6rj+C66212gvJIj+lORQ3+kKj8tK+G5wP8jY=; b=LfOryqg92khWEkNLbIWxcZYs8PbfDlHUpNcXcNviufbV3CZjArG8IUiZhsSZxjqksy dpNxJnoYEhj6KWrQHLNQpV6Z2ydkfky+1gTDjohlZfiYF94nWKtMtu/cJE8sbUrn8KU7 vGt9MpYsZSlESZ+0kq+kMCgsor2j/cc2caa7dh9kLsMp8GgJiJZlhJ3cTMd5kmHiN5ai BZKGxcOHYJQRe96dOyWfCYEZuqGmSpcUrMSrJpCaXDhVpdmLgeaRPky2HulkaAAIPeQl Bg9nhpXxSZ+aJf71VZeWBuqCKJus/otVLt2OSUeihbeLbhYMStLienF2VOo++IgNsMDU 63nQ== X-Gm-Message-State: AA+aEWZ07UWtH1/gSfJ8kzob9UiFIxhacXENCyPENwjcOsdLbGrqED4i 2jCJCKMSCU6SIJOma5BDBS6kVA== X-Google-Smtp-Source: AFSGD/WnpZrxaGuKQwg2yvj9Wm5JVvOWCXtKwQpacgTyEoRibMZAUe0piyygDOcyUGya7jl/tAIpCA== X-Received: by 2002:adf:d4c9:: with SMTP id w9mr1640447wrk.119.1542713825964; Tue, 20 Nov 2018 03:37:05 -0800 (PST) Received: from dell ([2.31.167.205]) by smtp.gmail.com with ESMTPSA id w2-v6sm9254529wrr.78.2018.11.20.03.37.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 20 Nov 2018 03:37:05 -0800 (PST) Date: Tue, 20 Nov 2018 11:37:03 +0000 From: Lee Jones To: Daniel Kiper Cc: Fu Wei Fu , Leif Lindholm , The development of GNU GRUB , Julien Grall Subject: arm64/xen: Remove duplicate check for arguments Message-ID: <20181120113703.GR3513@dell> References: <20181114192919.24655-1-leif.lindholm@linaro.org> <20181116140737.wuox7v63y6lt2ymt@tomti.i.net-space.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181116140737.wuox7v63y6lt2ymt@tomti.i.net-space.pl> User-Agent: Mutt/1.9.4 (2018-02-28) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::430 X-Mailman-Approved-At: Tue, 20 Nov 2018 08:36:40 -0500 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Nov 2018 11:37:12 -0000 From: Lee Jones arm64/xen: Remove duplicate check for arguments Signed-off-by: Lee Jones diff --git a/grub-core/loader/arm64/xen_boot.c b/grub-core/loader/arm64/xen_boot.c index 1b1dd8c65..5af15c70d 100644 --- a/grub-core/loader/arm64/xen_boot.c +++ b/grub-core/loader/arm64/xen_boot.c @@ -404,12 +404,6 @@ grub_cmd_xen_module (grub_command_t cmd __attribute__((unused)), argc--; } - if (!argc) - { - grub_error (GRUB_ERR_BAD_ARGUMENT, N_("filename expected")); - goto fail; - } - if (!loaded) { grub_error (GRUB_ERR_BAD_ARGUMENT,