From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1gP6Cv-0005az-Ph for mharc-grub-devel@gnu.org; Tue, 20 Nov 2018 08:36:49 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33388) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gP4Nj-0006k6-E2 for grub-devel@gnu.org; Tue, 20 Nov 2018 06:39:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gP4Nf-0007QV-0j for grub-devel@gnu.org; Tue, 20 Nov 2018 06:39:51 -0500 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]:37557) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gP4Nd-0007P3-R3 for grub-devel@gnu.org; Tue, 20 Nov 2018 06:39:46 -0500 Received: by mail-wm1-x341.google.com with SMTP id p2-v6so1864295wmc.2 for ; Tue, 20 Nov 2018 03:39:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=nsZaHNZcd+XZ3liWBvQVUTL7GS4T+WbHRMchr8A6lAs=; b=JA0FWwN0aaw9x9lQQl6HlKBShB4K74FZmf1OUKHpqbEqH7tjbK9NV/3Rv7Ola6uJ6H VhHFK9Qi3c5Bg3axnaJMysPc0i2INaUxZbVMGOnR4c1s3a+PrS0LEC+lRTsxGxt0qZkr 17oolWbWuFYgw01xdrbxgwOTVB7c8QIyrti80= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=nsZaHNZcd+XZ3liWBvQVUTL7GS4T+WbHRMchr8A6lAs=; b=X+3vNDVwolW/+ygSeu1QHxpLLbhKStRxVOEyIM2kO7T+xy3S/uL3d4D4YaBBE/cjF1 NUBZHrwhq3FPd+BHhzaMr3kaRy3hFRywOU8dUhu2VipZLjSdk2BcAjnQRpR+oNVI1K7K Yp8LiehXLEX5brHw8UeV0o1umnKpDu9AxifDTDVh1jRrEeLQNVC2O9xojRdPfju7exT3 a6iLEwhBh/z5u4T0BcybQyRkD64qNAakSTI15TPRhBytAvAbiaWfE3hjePQxUkP2GS7C hoSFewq0774xn+gxwQIxj/v/4XUhfE4buGBzdbBN1kvlIOBPki4V7m6jO5gTMsLam3Aw EjTw== X-Gm-Message-State: AGRZ1gKVJVlp8+/S9eokEeVzrw3/VFfnBHcp5Ts7Q3EvhLpTaAHe28EP 13LZ5fqG62EL2ojIPKTbkK3ggA== X-Google-Smtp-Source: AJdET5f1w/cK0qGcMVRqxqvo9+X/bqiaeIvlJjKmxZcvEKcj4wzJHC4YvfGrTpRj9Ni5kDwuJaPhTw== X-Received: by 2002:a1c:1c86:: with SMTP id c128mr1797836wmc.107.1542713984482; Tue, 20 Nov 2018 03:39:44 -0800 (PST) Received: from dell ([2.31.167.205]) by smtp.gmail.com with ESMTPSA id x142-v6sm82152329wmd.20.2018.11.20.03.39.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 20 Nov 2018 03:39:43 -0800 (PST) Date: Tue, 20 Nov 2018 11:39:42 +0000 From: Lee Jones To: Daniel Kiper Cc: Fu Wei Fu , Leif Lindholm , The development of GNU GRUB , Julien Grall Subject: [PATCH v2] arm64/xen: Fix too =?utf-8?Q?fe?= =?utf-8?Q?w_arguments_to_function_=E2=80=98grub=5Ffile=5Fopen=E2=80=99?= Message-ID: <20181120113942.GT3513@dell> References: <20181114192919.24655-1-leif.lindholm@linaro.org> <20181116140737.wuox7v63y6lt2ymt@tomti.i.net-space.pl> <20181120104840.GO3513@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20181120104840.GO3513@dell> User-Agent: Mutt/1.9.4 (2018-02-28) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::341 X-Mailman-Approved-At: Tue, 20 Nov 2018 08:36:40 -0500 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Nov 2018 11:39:52 -0000 From: Lee Jones arm64/xen: Fix too few arguments to function ‘grub_file_open’ Without this fix xen_boot.c omits: loader/arm64/xen_boot.c: In function ‘grub_cmd_xen_module’: loader/arm64/xen_boot.c:424:10: error: too few arguments to function ‘grub_file_open’ file = grub_file_open (argv[0]); ^~~~~~~~~~~~~~ In file included from ../include/grub/cache.h:23:0, from loader/arm64/xen_boot.c:19: ../include/grub/file.h:204:25: note: declared here grub_file_t EXPORT_FUNC(grub_file_open) (const char *name, enum grub_file_type type); ^ ../include/grub/symbol.h:68:25: note: in definition of macro ‘EXPORT_FUNC’ # define EXPORT_FUNC(x) x ^ loader/arm64/xen_boot.c: In function ‘grub_cmd_xen_hypervisor’: loader/arm64/xen_boot.c:456:10: error: too few arguments to function ‘grub_file_open’ file = grub_file_open (argv[0]); ^~~~~~~~~~~~~~ Signed-off-by: Lee Jones diff --git a/grub-core/loader/arm64/xen_boot.c b/grub-core/loader/arm64/xen_boot.c index 117293fb9..1b1dd8c65 100644 --- a/grub-core/loader/arm64/xen_boot.c +++ b/grub-core/loader/arm64/xen_boot.c @@ -427,7 +427,7 @@ grub_cmd_xen_module (grub_command_t cmd __attribute__((unused)), grub_dprintf ("xen_loader", "Init module and node info\n"); - file = grub_file_open (argv[0]); + file = grub_file_open (argv[0], GRUB_FILE_TYPE_LINUX_KERNEL); if (!file) goto fail; @@ -459,7 +459,7 @@ grub_cmd_xen_hypervisor (grub_command_t cmd __attribute__ ((unused)), goto fail; } - file = grub_file_open (argv[0]); + file = grub_file_open (argv[0], GRUB_FILE_TYPE_LINUX_KERNEL); if (!file) goto fail;