From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [PATCH v3 3/3] ALSA: hda: add support for Huawei WMI micmute LED Date: Tue, 20 Nov 2018 12:51:59 +0100 Message-ID: <20181120115159.GG16916@amd> References: <20181108171701.4444-1-ayman.bagabas@gmail.com> <20181108171701.4444-4-ayman.bagabas@gmail.com> <20181119235713.GB7367@amd> <20181120091039.GA16916@amd> <20181120093610.GF16916@amd> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="2E/hm+v6kSLEYT3h" Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Takashi Iwai Cc: Ayman Bagabas , alsa-devel@alsa-project.org, Hui Wang , Andy Shevchenko , Darren Hart , Jaroslav Kysela , Kailang Yang , linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org List-Id: alsa-devel@alsa-project.org --2E/hm+v6kSLEYT3h Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > > You have general-purpose LED, yet you are treating it as "something > > special". That means ugly code (quoted above) and lack of flexibility. > >=20 > > For example, if my notebook lacks HDD LED, I can use scrollock LED for > > that instead. Or, in reverse way, maybe "mic mute" LED is not useful > > for me, and I'd like to use it for notifications instead. >=20 > I'm not against adding the LEDs device implementation for any exotic > usage. >=20 > But for the audio mute LED features, you'll need really lots of other > works if it were implemented via leds device. That's the hardest > part, and a few lines of hooks solves it easily in the kernel side. > That's all about it. >=20 > If you are ready for submitting the real solutions in user-space side > (patching PulseAudio and whatever all existing sound daemons, and > creating yet another daemon for non-PA systems (another footprint, > lovely), and so on), we can happily delete such in-kernel hooks :) I'm not saying we should move it to the userspace. I'm saying this should be "normal" led. drivers/leds/led-huawei-acpi.c, or something. Perhaps this acpi stuff is so similar you don't really need .c code. And then there should be a "mic muted" trigger. Similar to drivers/leds/trigger/ledtrig-disk.c. That should give us the flexibility, and should not be really much different from current implementation... Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --2E/hm+v6kSLEYT3h Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlvz9V8ACgkQMOfwapXb+vKyHACglkVaz0F7V5/vwEW8M2vG5q9G FKYAmwS3NlL+jtvD0eBkxD3Onq79P7q0 =B6u7 -----END PGP SIGNATURE----- --2E/hm+v6kSLEYT3h--