All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH next 2/2] package/luarocks: rework configuration file for per-package folders
Date: Tue, 20 Nov 2018 12:02:40 +0100	[thread overview]
Message-ID: <20181120120240.53e43cce@windsurf> (raw)
In-Reply-To: <CAB0FRstV2av9OfDwr5DyKb=kyxSrk=eJ9fSuUp=LK-RXWGdtSA@mail.gmail.com>

Hello Fran?ois,

On Mon, 19 Nov 2018 21:57:35 +0100, Fran?ois Perrad wrote:

> In fact, this patch is useless, the sandbox environment contains a field
> `os_getenv`.
> Just use `os_getenv` instead of `getenv` in luarocks-br-config.lua.
> 
> Another point, without defining a lot variables, the command
> `somewhere_host/bin/luarocks --help` fails
> with the message : attemps to concatenate a nil value (when loading the
> config file)
> 
> So, add something like this, on the top of luarocks-br-config.lua :
>     local function getenv (name) return os_getenv(name) or '' end

Thanks for the feedback! I will send an updated version soon.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-11-20 11:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-19 10:32 [Buildroot] [PATCH next 0/2] Adjust Luarocks support to per-package folder Thomas Petazzoni
2018-11-19 10:32 ` [Buildroot] [PATCH next 1/2] package/pkg-luarocks: drop flock at installation time Thomas Petazzoni
2018-11-19 20:28   ` François Perrad
2018-11-19 20:46   ` Thomas Petazzoni
2018-11-19 10:32 ` [Buildroot] [PATCH next 2/2] package/luarocks: rework configuration file for per-package folders Thomas Petazzoni
2018-11-19 20:57   ` François Perrad
2018-11-20 11:02     ` Thomas Petazzoni [this message]
2018-11-21  8:23   ` François Perrad

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181120120240.53e43cce@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.