From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1gP6Cr-0005Yp-K4 for mharc-grub-devel@gnu.org; Tue, 20 Nov 2018 08:36:45 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46002) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gP57J-0007A6-Im for grub-devel@gnu.org; Tue, 20 Nov 2018 07:26:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gP57G-0000iJ-FP for grub-devel@gnu.org; Tue, 20 Nov 2018 07:26:57 -0500 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]:34186) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gP57G-0000hz-9Q for grub-devel@gnu.org; Tue, 20 Nov 2018 07:26:54 -0500 Received: by mail-wr1-x42a.google.com with SMTP id j2so1785056wrw.1 for ; Tue, 20 Nov 2018 04:26:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=TOE3k7ViN2gXGi44CZW14PNjrM/yTsSObVjMl9kKPHg=; b=N5ACd4RN+QkhDKnnWHWT5FqkCR7tZ6IxQ1YjlK8IbAvCwnq20UHwtEQ3YI307q/ivZ I9BKWmBvu9z3xUBbTtWPjCgAPN9gDOUdq/2180Qwxdp3fpxyKDMr7dKRIaM5cG23lRin EIQK4ufIsCK48d3IoxnRLsApwZWYV/RUWt2pw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=TOE3k7ViN2gXGi44CZW14PNjrM/yTsSObVjMl9kKPHg=; b=We5yjzEHbS9Bze1q7+a6WxhOp+VFHDMCWa3pW/lfzjAGqCQXKJ139lpty0+2FnYbuR G+d0DelOXvp3WIS2Go88C9xKAMRJ1m+/WHyXTLSdr6tVY6d+B55E/986go6ae/+55LVu 6MHIja1b+G3VjpgFPw/rI84iomphneB4u4xmrwshnwGc993r3hoLOrF2UgJfy/BJovQX 3K8Babapbf/0VWT5pHeTSmUGPgl81C7vY7dAP+EzYVkq+DYqVfUuJQBgCwUufaTvi8qh 3X27XsQ4Wje6Ecwsduoy/bu4lWNUhL6EE5HBpR69A3Mtz4eLy/OOomzbfIp4s5S00rLW 7bEQ== X-Gm-Message-State: AA+aEWaajplh2owI/THvAfazbvFNTIkffnNVIj5UzrZ4g9UiruEHXPHL +psIV1j0rmaCaUkMJ1T9JVM5fg== X-Google-Smtp-Source: AFSGD/Ww3o0NIbkxAagrCAGCWL5CVVAYJJag3F/05rX4FMZONe8jkzf3qhitTB5XQr4XwB/9qcNIEw== X-Received: by 2002:adf:ca09:: with SMTP id o9-v6mr1786151wrh.148.1542716812708; Tue, 20 Nov 2018 04:26:52 -0800 (PST) Received: from dell ([2.31.167.205]) by smtp.gmail.com with ESMTPSA id 60sm16265789wrb.81.2018.11.20.04.26.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 20 Nov 2018 04:26:51 -0800 (PST) Date: Tue, 20 Nov 2018 12:26:50 +0000 From: Lee Jones To: Julien Grall Cc: Daniel Kiper , Fu Wei Fu , Leif Lindholm , The development of GNU GRUB Subject: Re: arm64/xen: Fix implicit =?utf-8?Q?decl?= =?utf-8?Q?aration_of_function_=E2=80=98grub=5Ffile=5Ffilter=5Fdisable=5Fc?= =?utf-8?Q?ompression?= Message-ID: <20181120122650.GU3513@dell> References: <20181114192919.24655-1-leif.lindholm@linaro.org> <20181116140737.wuox7v63y6lt2ymt@tomti.i.net-space.pl> <20181120104656.GN3513@dell> <20181120112241.GQ3513@dell> <1956f6fa-a0e1-0e6b-24b2-e3f040a2ee67@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1956f6fa-a0e1-0e6b-24b2-e3f040a2ee67@arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::42a X-Mailman-Approved-At: Tue, 20 Nov 2018 08:36:40 -0500 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Nov 2018 12:26:58 -0000 On Tue, 20 Nov 2018, Julien Grall wrote: > Hi, > > On 20/11/2018 11:22, Lee Jones wrote: > > On Tue, 20 Nov 2018, Julien Grall wrote: > > > On 20/11/2018 10:46, Lee Jones wrote: > > > > From: Lee Jones > > > > > > > > arm64/xen: Fix implicit declaration of function ‘grub_file_filter_disable_compression > > > > > > This patch seems to drop support for --nounzip. Can you explain why? > > > > It only seemed to serve the invocation of grub_file_filter_disable_compression() > > which was removed in this patch. > > But --nounzip will not work as expected after this patch. Looking at GRUB, > it seems the call to that function was replaced by passing > GRUB_FILE_TYPE_NO_DECOMPRESSION to grub_file_open. Ah yes, I see. Please bear with me. I need to split this patch too. > Is there any reason to not use it for Arm? -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog