All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Radu Rendec <radu.rendec@gmail.com>
Cc: linux-kernel@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 1/1] Improve kernfs_notify() poll notification latency
Date: Tue, 20 Nov 2018 08:14:19 -0800	[thread overview]
Message-ID: <20181120161419.GS2509588@devbig004.ftw2.facebook.com> (raw)
In-Reply-To: <20181116020954.24924-2-radu.rendec@gmail.com>

On Thu, Nov 15, 2018 at 09:09:54PM -0500, Radu Rendec wrote:
> kernfs_notify() does two notifications: poll and fsnotify. Originally,
> both notifications were done from scheduled work context and all that
> kernfs_notify() did was schedule the work.
> 
> This patch simply moves the poll notification from the scheduled work
> handler to kernfs_notify(). The fsnotify notification still needs to be
> done from scheduled work context because it can sleep (it needs to lock
> a mutex).
> 
> If the poll notification is time critical (the notified thread needs to
> wake as quickly as possible), it's better to do it from kernfs_notify()
> directly. One example is calling sysfs_notify_dirent() from a hardware
> interrupt handler to wake up a thread and handle the interrupt in user
> space.
> 
> Signed-off-by: Radu Rendec <radu.rendec@gmail.com>

Acked-by: Tejun Heo <tj@kernel.org>

Greg, can you please route this one?

Thanks.

-- 
tejun

  reply	other threads:[~2018-11-20 16:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-16  2:09 [PATCH 0/1] kernfs_notify() poll latency Radu Rendec
2018-11-16  2:09 ` [PATCH 1/1] Improve kernfs_notify() poll notification latency Radu Rendec
2018-11-20 16:14   ` Tejun Heo [this message]
2018-11-20 16:58     ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181120161419.GS2509588@devbig004.ftw2.facebook.com \
    --to=tj@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=radu.rendec@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.