Re: [PATCH 5/5] xfs: precalculate cluster alignment in inodes and blocks

[Brian Foster <bfoster@redhat.com>]

On Thu, Nov 08, 2018 at 03:20:39PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> Store the inode cluster alignment information in units of inodes and
> blocks in the mount data so that we don't have to keep recalculating
> them.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
>  fs/xfs/libxfs/xfs_ialloc.c |    8 ++++----
>  fs/xfs/libxfs/xfs_types.c  |    5 ++---
>  fs/xfs/scrub/ialloc.c      |    2 +-
>  fs/xfs/xfs_mount.c         |    2 ++
>  fs/xfs/xfs_mount.h         |    2 ++
>  5 files changed, 11 insertions(+), 8 deletions(-)
> 
> 
...
> diff --git a/fs/xfs/xfs_mount.h b/fs/xfs/xfs_mount.h
> index 58a037bfac22..0ad025e7f3cf 100644
> --- a/fs/xfs/xfs_mount.h
> +++ b/fs/xfs/xfs_mount.h
> @@ -103,6 +103,8 @@ typedef struct xfs_mount {
>  	uint			m_inode_cluster_size;/* min inode buf size */
>  	unsigned int		m_inodes_per_cluster;
>  	unsigned int		m_blocks_per_cluster;
> +	unsigned int		m_cluster_align;
> +	unsigned int		m_cluster_align_inodes;

The m_cluster_align change looks fine:

Reviewed-by: Brian Foster <bfoster@redhat.com>

... but no users of m_cluster_align_inodes?

>  	uint			m_blockmask;	/* sb_blocksize-1 */
>  	uint			m_blockwsize;	/* sb_blocksize in words */
>  	uint			m_blockwmask;	/* blockwsize-1 */
>