From: Kevin Wolf <kwolf@redhat.com>
To: Alberto Garcia <berto@igalia.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v5 00/16] Don't pass flags to bdrv_reopen_queue()
Date: Tue, 20 Nov 2018 19:21:21 +0100 [thread overview]
Message-ID: <20181120182121.GE7513@localhost.localdomain> (raw)
In-Reply-To: <cover.1542031058.git.berto@igalia.com>
Am 12.11.2018 um 15:00 hat Alberto Garcia geschrieben:
> Hi all,
>
> when reopening a BlockDriverState using bdrv_reopen() and friends the
> new options can be specified either with a QDict or with flags. Both
> methods overlap and that makes the semantics and the implementation
> unnecessarily complicated.
>
> This series removes the 'flags' parameter from these functions, so
> from now on all option changes must be specified using a QDict. Apart
> from simplifying the API, a few bugs are fixed along the way. See the
> individual patches for more details.
>
> This was tested with the current master (460f0236c12a86a38692c12d9bf).
Looks good to me, except for that one s/int/bool/ that I could do while
applying.
The only remaining question is - is all of this for 3.1, or which parts
are? It's a long series, but there are also a few bug fixes in there.
Kevin
next prev parent reply other threads:[~2018-11-20 18:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-12 14:00 [Qemu-devel] [PATCH v5 00/16] Don't pass flags to bdrv_reopen_queue() Alberto Garcia
2018-11-12 14:00 ` [Qemu-devel] [PATCH v5 01/16] block: Add bdrv_reopen_set_read_only() Alberto Garcia
2018-11-12 14:00 ` [Qemu-devel] [PATCH v5 02/16] block: Use bdrv_reopen_set_read_only() in bdrv_backing_update_filename() Alberto Garcia
2018-11-12 14:00 ` [Qemu-devel] [PATCH v5 03/16] block: Use bdrv_reopen_set_read_only() in commit_start/complete() Alberto Garcia
2018-11-12 14:00 ` [Qemu-devel] [PATCH v5 04/16] block: Use bdrv_reopen_set_read_only() in bdrv_commit() Alberto Garcia
2018-11-12 14:00 ` [Qemu-devel] [PATCH v5 05/16] block: Use bdrv_reopen_set_read_only() in stream_start/complete() Alberto Garcia
2018-11-20 18:00 ` Kevin Wolf
2018-11-20 18:31 ` Alberto Garcia
2018-11-12 14:00 ` [Qemu-devel] [PATCH v5 06/16] block: Use bdrv_reopen_set_read_only() in qmp_change_backing_file() Alberto Garcia
2018-11-12 14:00 ` [Qemu-devel] [PATCH v5 07/16] block: Use bdrv_reopen_set_read_only() in external_snapshot_commit() Alberto Garcia
2018-11-12 14:00 ` [Qemu-devel] [PATCH v5 08/16] block: Use bdrv_reopen_set_read_only() in the mirror driver Alberto Garcia
2018-11-12 14:00 ` [Qemu-devel] [PATCH v5 09/16] block: Drop bdrv_reopen() Alberto Garcia
2018-11-12 14:00 ` [Qemu-devel] [PATCH v5 10/16] qemu-io: Put flag changes in the options QDict in reopen_f() Alberto Garcia
2018-11-12 14:00 ` [Qemu-devel] [PATCH v5 11/16] block: Clean up reopen_backing_file() in block/replication.c Alberto Garcia
2018-11-12 14:00 ` [Qemu-devel] [PATCH v5 12/16] block: Remove flags parameter from bdrv_reopen_queue() Alberto Garcia
2018-11-12 14:00 ` [Qemu-devel] [PATCH v5 13/16] block: Stop passing flags to bdrv_reopen_queue_child() Alberto Garcia
2018-11-12 14:00 ` [Qemu-devel] [PATCH v5 14/16] block: Remove assertions from update_flags_from_options() Alberto Garcia
2018-11-12 14:00 ` [Qemu-devel] [PATCH v5 15/16] block: Assert that flags are up-to-date in bdrv_reopen_prepare() Alberto Garcia
2018-11-12 14:00 ` [Qemu-devel] [PATCH v5 16/16] block: Fix update of BDRV_O_AUTO_RDONLY in update_flags_from_options() Alberto Garcia
2018-11-20 18:21 ` Kevin Wolf [this message]
2018-11-20 18:33 ` [Qemu-devel] [PATCH v5 00/16] Don't pass flags to bdrv_reopen_queue() Alberto Garcia
2018-11-21 16:14 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181120182121.GE7513@localhost.localdomain \
--to=kwolf@redhat.com \
--cc=berto@igalia.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.