From: Andrew Lunn <andrew@lunn.ch>
To: Bryan Whitehead <Bryan.Whitehead@microchip.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
UNGLinuxDriver@microchip.com
Subject: Re: [PATCH v1 net] lan743x: fix return value for lan743x_tx_napi_poll
Date: Tue, 20 Nov 2018 20:30:54 +0100 [thread overview]
Message-ID: <20181120193054.GE2649@lunn.ch> (raw)
In-Reply-To: <1542738403-23034-1-git-send-email-Bryan.Whitehead@microchip.com>
On Tue, Nov 20, 2018 at 01:26:43PM -0500, Bryan Whitehead wrote:
> It has been noticed that under stress the lan743x driver will
> sometimes hang or cause a kernel panic. It has been noticed
> that returning '0' instead of 'weight' fixes this issue.
>
> fixes: rare kernel panic under heavy traffic load.
> Signed-off-by: Bryan Whitehead <Bryan.Whitehead@microchip.com>
Hi Bryan
This sounds like a band aid over something which is broken, not a real
fix.
Can you show us the stack trace from the panic?
Andrew
next prev parent reply other threads:[~2018-11-21 6:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 18:26 [PATCH v1 net] lan743x: fix return value for lan743x_tx_napi_poll Bryan Whitehead
2018-11-20 19:30 ` Andrew Lunn [this message]
2018-11-20 21:39 ` Bryan.Whitehead
2018-11-20 21:55 ` Andrew Lunn
2018-11-20 22:11 ` Florian Fainelli
2018-11-21 2:13 ` Tristram.Ha
2018-11-21 3:12 ` David Miller
2018-11-21 16:47 ` Bryan.Whitehead
2018-11-21 16:44 ` Bryan.Whitehead
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181120193054.GE2649@lunn.ch \
--to=andrew@lunn.ch \
--cc=Bryan.Whitehead@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.