All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Sven Strickroth <email@cs-ware.de>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] .mailmap: record canonical email address for Sven Strickroth
Date: Tue, 20 Nov 2018 13:58:03 -0800	[thread overview]
Message-ID: <20181120215803.GA149929@google.com> (raw)
In-Reply-To: <15b7df69-25d8-c168-dd43-a43b7fee23d2@cs-ware.de>

Hi,

Sven Strickroth wrote:

> Subject: .mailmap: record canonical email address for Sven Strickroth
>
> Signed-off-by: Sven Strickroth <email@cs-ware.de>
> ---
>  .mailmap | 2 ++
>  1 file changed, 2 insertions(+)

Thanks for taking care of it.

[...]
> --- a/.mailmap
> +++ b/.mailmap
> @@ -235,6 +235,8 @@ Steven Grimm <koreth@midwinter.com> <sgrimm@sgrimm-mbp.local>
>  Steven Grimm <koreth@midwinter.com> koreth@midwinter.com
>  Steven Walter <stevenrwalter@gmail.com> <swalter@lexmark.com>
>  Steven Walter <stevenrwalter@gmail.com> <swalter@lpdev.prtdev.lexmark.com>
> +Sven Strickroth <email@cs-ware.de> <sven@cs-ware.de>

Is the above line needed?  It's not clear to me from the commit message
what it does.

> +Sven Strickroth <email@cs-ware.de> <sven.strickroth@tu-clausthal.de>

This line looks good.

>  Sven Verdoolaege <skimo@kotnet.org> <Sven.Verdoolaege@cs.kuleuven.ac.be>
>  Sven Verdoolaege <skimo@kotnet.org> <skimo@liacs.nl>
>  SZEDER G??bor <szeder.dev@gmail.com> <szeder@ira.uka.de>

This line does not seem to have survived mailing.  Fortunately it's a
context line, but thought I should mention it for the future.

Thanks and hope that helps,
Jonathan

  reply	other threads:[~2018-11-20 21:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-20 19:40 [PATCH] .mailmap: record canonical email address for Sven Strickroth Sven Strickroth
2018-11-20 21:58 ` Jonathan Nieder [this message]
2018-11-21  0:00   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181120215803.GA149929@google.com \
    --to=jrnieder@gmail.com \
    --cc=email@cs-ware.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.