From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915: Re-enable fastset by default
Date: Tue, 20 Nov 2018 14:29:00 -0800 [thread overview]
Message-ID: <20181120222900.GC2515@intel.com> (raw)
In-Reply-To: <20181120134049.17112-2-maarten.lankhorst@linux.intel.com>
On Tue, Nov 20, 2018 at 02:40:49PM +0100, Maarten Lankhorst wrote:
> Now that we've solved the backlight issue, I think it's time to enable
> this again by default. We've enabled it in the past, but backlight
> issues prevented us from enabling it by default.
>
> Our hardware readout is pretty complete, and with all of the connector
> state moved to atomic I'm hoping we finally have enough capability to
> re-enable fastset by default.
>
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_params.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h
> index 7e56c516c815..149ab592a695 100644
> --- a/drivers/gpu/drm/i915/i915_params.h
> +++ b/drivers/gpu/drm/i915/i915_params.h
> @@ -57,7 +57,7 @@ struct drm_printer;
> /* leave bools at the end to not create holes */ \
> param(bool, alpha_support, IS_ENABLED(CONFIG_DRM_I915_ALPHA_SUPPORT)) \
> param(bool, enable_hangcheck, true) \
> - param(bool, fastboot, false) \
> + param(bool, fastboot, true) \
Do we know the impact of this on PSR, FBC and DRRS?
Last time that I checked a while ago this would break
this features since they just get enabled right after pipe
getting enabled.
> param(bool, prefault_disable, false) \
> param(bool, load_detect_test, false) \
> param(bool, force_reset_modeset_test, false) \
> --
> 2.19.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-11-20 22:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 13:40 [PATCH 1/2] drm/i915: Enable fastset for non-boot modesets Maarten Lankhorst
2018-11-20 13:40 ` [PATCH 2/2] drm/i915: Re-enable fastset by default Maarten Lankhorst
2018-11-20 22:29 ` Rodrigo Vivi [this message]
2018-11-20 15:42 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: Enable fastset for non-boot modesets Patchwork
2018-11-20 16:03 ` ✓ Fi.CI.BAT: success " Patchwork
2018-11-21 0:50 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181120222900.GC2515@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=maarten.lankhorst@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.