From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [PATCH 2/7] drm/i915: Check PSR errors instead of retrain while PSR is enabled Date: Tue, 20 Nov 2018 14:38:57 -0800 Message-ID: <20181120223857.GD2515@intel.com> References: <20181109202016.18920-1-jose.souza@intel.com> <20181109202016.18920-2-jose.souza@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id B3CDA6E48A for ; Tue, 20 Nov 2018 22:38:58 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20181109202016.18920-2-jose.souza@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?iso-8859-1?Q?Jos=E9?= Roberto de Souza Cc: intel-gfx@lists.freedesktop.org, Dhinakaran Pandiyan List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBOb3YgMDksIDIwMTggYXQgMTI6MjA6MTFQTSAtMDgwMCwgSm9zw6kgUm9iZXJ0byBk ZSBTb3V6YSB3cm90ZToKPiBXaGVuIGEgUFNSIGVycm9yIGhhcHBlbnMgc2luayBzZXRzIHRoZSBQ U1IgZXJyb3JzIHJlZ2lzdGVyIGFuZCBhbHNvCj4gc2V0IHRoZSBsaW5rIHRvIGEgZXJyb3Igc3Rh dHVzLgo+IFNvIGluIHRoZSBzaG9ydCBwdWxzZSBoYW5kbGluZyBpdCB3YXMgcmV0dXJuaW5nIGVh cmxpZXIgYW5kIGRvaW5nIGEKPiBmdWxsIGRldGVjdGlvbiBhbmQgYXR0ZW1wdGluZyB0byByZXRy YWluIGJ1dCBpdCBmYWlscyBhcyBQU1IgSFcgaXMKPiBpbiBjaGFuZ2Ugb2YgdGhlIG1haW4tbGlu ay4KPiAKPiBKdXN0IGNhbGwgaW50ZWxfcHNyX3Nob3J0X3B1bHNlKCkgYmVmb3JlCj4gaW50ZWxf ZHBfbmVlZHNfbGlua19yZXRyYWluKCkgaXMgbm90IHRoZSByaWdodCBmaXggYXMKPiBpbnRlbF9k cF9uZWVkc19saW5rX3JldHJhaW4oKSB3b3VsZCByZXR1cm4gdHJ1ZSBhbmQgdHJpZ2dlciBhIGZ1 bGwKPiBkZXRlY3Rpb24gd2hpbGUgUFNSIEhXIGlzIHN0aWxsIGluIGNoYW5nZSBvZiBtYWluLWxp bmsuCj4gCj4gQ2hlY2sgZm9yIFBTUiBhY3RpdmUgaXMgYWxzbyBub3Qgc2FmZSBhcyBpdCBjb3Vs ZCBiZSBpbmFjdGl2ZSBkdWUgYQo+IGZyb250YnVmZmVyIGludmFsaWRhdGUgYW5kIHN0aWxsIGRv aW5nIHRoZSBQU1IgZXhpdCBzZXF1ZW5jZS4KPiAKPiB2MzogYWRkZWQgY29tbWVudCBpbiBpbnRl bF9kcF9uZWVkc19saW5rX3JldHJhaW4oKQo+IAo+IENjOiBEaGluYWthcmFuIFBhbmRpeWFuIDxk aGluYWthcmFuLnBhbmRpeWFuQGludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBKb3PDqSBSb2Jl cnRvIGRlIFNvdXphIDxqb3NlLnNvdXphQGludGVsLmNvbT4KCkkgd29uZGVyIGlmIHdlIHNob3Vs ZG4ndCBkaXNhYmxlIHBzciBhbmQgdGhlbiBtb3ZlIHdpdGgKbGluayB0cmFpbmluZyBvbiBzaXR1 YXRpb25zIGxpa2UgdGhpcyBpbnN0ZWFkIG9mIGRyb3BwaW5nIHNvbWUKbGluayB0cmFpbmluZ3Mu Li4gTm90IHN1cmUgaWYgSSB0cnVzdCBQU1IgbW9yZSB0byB0YWtlIGNhcmUgb2YKdGhpcyBjYXNl LiBCdXQgd2VsbCwgbWF5YmUgdGhpcyBjYXNlIGlzIG9ubHkgaGFwcGVuaW5nIG9uCnJlY292ZXJh YmxlIFBTUiBlcnJvcnMgd2hlcmUgaHBkIHB1bHNlcyBlbmQgdXAgaGFwcGVuaW5nIHNvCnRoaXMg c2hvdWxkIGJlIG9rLgoKTGV0J3MgdHJ5IHRoaXMgYXBwcm9hY2gsIGJ1dCBwbGVhc2UgY29uc2lk ZXIgdGhlIG9wdGlvbgp0byBkaXNhYmxlIHBzciBpbnN0ZWFkIGlmIHdlIGZhY2Ugc29tZSBpc3N1 ZXMgYXJvdW5kIGhlcmUuLi4KClJldmlld2VkLWJ5OiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28udml2 aUBpbnRlbC5jb20+Cgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jICB8 IDExICsrKysrKysrKysrCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oIHwgIDEg Kwo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wc3IuYyB8IDE1ICsrKysrKysrKysrKysr Kwo+ICAzIGZpbGVzIGNoYW5nZWQsIDI3IGluc2VydGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2RwLmMKPiBpbmRleCA1NzdjMTY2ZjY0ODMuLjE1OGM2ZjI1ZDJlMiAxMDA2NDQKPiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZHAuYwo+IEBAIC00MzgzLDYgKzQzODMsMTcgQEAgaW50ZWxfZHBfbmVlZHNf bGlua19yZXRyYWluKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHApCj4gIAlpZiAoIWludGVsX2Rw LT5saW5rX3RyYWluZWQpCj4gIAkJcmV0dXJuIGZhbHNlOwo+ICAKPiArCS8qCj4gKwkgKiBXaGls ZSBQU1Igc291cmNlIEhXIGlzIGVuYWJsZWQsIGl0IHdpbGwgY29udHJvbCBtYWluLWxpbmsgc2Vu ZGluZwo+ICsJICogZnJhbWVzLCBlbmFibGluZyBhbmQgZGlzYWJsaW5nIGl0IHNvIHRyeWluZyB0 byBkbyBhIHJldHJhaW4gd2lsbCBmYWlsCj4gKwkgKiBhcyB0aGUgbGluayB3b3VsZCBvciBub3Qg YmUgb24gb3IgaXQgY291bGQgbWl4IHRyYWluaW5nIHBhdHRlcm5zCj4gKwkgKiBhbmQgZnJhbWUg ZGF0YSBhdCB0aGUgc2FtZSB0aW1lIGNhdXNpbmcgcmV0cmFpbiB0byBmYWlsLgo+ICsJICogQWxz byB3aGVuIGV4aXRpbmcgUFNSLCBIVyB3aWxsIHJldHJhaW4gdGhlIGxpbmsgYW55d2F5cyBmaXhp bmcKPiArCSAqIGFueSBsaW5rIHN0YXR1cyBlcnJvci4KPiArCSAqLwo+ICsJaWYgKGludGVsX3Bz cl9lbmFibGVkKGludGVsX2RwKSkKPiArCQlyZXR1cm4gZmFsc2U7Cj4gKwo+ICAJaWYgKCFpbnRl bF9kcF9nZXRfbGlua19zdGF0dXMoaW50ZWxfZHAsIGxpbmtfc3RhdHVzKSkKPiAgCQlyZXR1cm4g ZmFsc2U7Cj4gIAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYu aCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gaW5kZXggY2M3ZmFiMmI2MWY0 Li4xMmY5NjI5NzI5OWUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZHJ2LmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+IEBAIC0yMDQ2 LDYgKzIwNDYsNyBAQCB2b2lkIGludGVsX3Bzcl9pcnFfaGFuZGxlcihzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSAqZGV2X3ByaXYsIHUzMiBwc3JfaWlyKTsKPiAgdm9pZCBpbnRlbF9wc3Jfc2hvcnRf cHVsc2Uoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCk7Cj4gIGludCBpbnRlbF9wc3Jfd2FpdF9m b3JfaWRsZShjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqbmV3X2NydGNfc3RhdGUsCj4g IAkJCSAgICB1MzIgKm91dF92YWx1ZSk7Cj4gK2Jvb2wgaW50ZWxfcHNyX2VuYWJsZWQoc3RydWN0 IGludGVsX2RwICppbnRlbF9kcCk7Cj4gIAo+ICAvKiBpbnRlbF9xdWlya3MuYyAqLwo+ICB2b2lk IGludGVsX2luaXRfcXVpcmtzKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdik7Cj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5jIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMKPiBpbmRleCA0OGRmMTZhMDJmYWMuLmY5NDAzMDViNzJl NCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wc3IuYwo+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5jCj4gQEAgLTExMDcsMyArMTEwNywxOCBA QCB2b2lkIGludGVsX3Bzcl9zaG9ydF9wdWxzZShzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwKQo+ ICBleGl0Ogo+ICAJbXV0ZXhfdW5sb2NrKCZwc3ItPmxvY2spOwo+ICB9Cj4gKwo+ICtib29sIGlu dGVsX3Bzcl9lbmFibGVkKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHApCj4gK3sKPiArCXN0cnVj dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGRwX3RvX2k5MTUoaW50ZWxfZHApOwo+ICsJ Ym9vbCByZXQ7Cj4gKwo+ICsJaWYgKCFDQU5fUFNSKGRldl9wcml2KSB8fCAhaW50ZWxfZHBfaXNf ZWRwKGludGVsX2RwKSkKPiArCQlyZXR1cm4gZmFsc2U7Cj4gKwo+ICsJbXV0ZXhfbG9jaygmZGV2 X3ByaXYtPnBzci5sb2NrKTsKPiArCXJldCA9IChkZXZfcHJpdi0+cHNyLmRwID09IGludGVsX2Rw ICYmIGRldl9wcml2LT5wc3IuZW5hYmxlZCk7Cj4gKwltdXRleF91bmxvY2soJmRldl9wcml2LT5w c3IubG9jayk7Cj4gKwo+ICsJcmV0dXJuIHJldDsKPiArfQo+IC0tIAo+IDIuMTkuMQo+IAo+IF9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeApfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGlu ZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK