From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a5d:6089:0:0:0:0:0 with SMTP id w9csp1809474wrt; Wed, 21 Nov 2018 04:36:04 -0800 (PST) X-Google-Smtp-Source: AJdET5fKcpee13W0AIkWXrrxv1RhtlEe8ZAgKbOMykohFhCbfm9/ytskGs7/kad8RedlmjPPr0dH X-Received: by 2002:a81:27cc:: with SMTP id n195mr6147177ywn.243.1542803764393; Wed, 21 Nov 2018 04:36:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542803764; cv=none; d=google.com; s=arc-20160816; b=mzvgctMqaDvh4rTvLGFw0IvTWbmrblFdsviCxR02WjTVco8YB77KgZiKhINwRZh3CJ xBeNj9s44DP8p9L+YkSK24JuvDvwg92qveqn255hvJmHl8eo3qf/HV3HTXvnBWuqZdWw BZ6t/YudVNFoc23XUiecTJlx1kfi6JcTCDhbKU2O0mPfiEwP7nu9vhHeY/CG1xY8ASyc mJJCyiyttKt4r1fHeKyaPsb9it/Vh6jbw5hyBeZbjc3aW2AugIwGtuaRz3+WRBwMcmL4 G6g2v9dNkEHTcQrTZr8g8WvBqIQFnt9i1qHJLB/afSgjHUg9QHGinKiSA3PPDuoMMxDL vwAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:in-reply-to :content-disposition:mime-version:references:message-id:to:from:date; bh=Ppq4NdIpNpNzwMRjifesghd5dd12vpt8XfSWDq+4Jvo=; b=DN6rTW4kg5utlYcel1s28ruC7WXsm13svFxg9Dv4TJL6h6D3s+qrh2vC4ihvSu5aga NC1AdWeP5MYAHeQzMw2ekX7Yi/fIm3NOYLqOutAa52mfIlkHIUN4gTTyYcWPqgP/rwkW ESpe75rZ2kuCWO5IZo8RooZvmxi47DvWek/yvk2wSz3v81/87v5nSbAHfL3/s9F/QO+P pE/T8Qj8ZI1TSJTVy0KrZccISM773QwZraq5nLf59BIhxiE7u3Tm7drsdUriCrijEMry y7rt9xfiLzOZ7+5y00468nPaQiCUaL3zWHi1cOb+8qrqIKwhJGqR+zQTFLmIZS3LweQP D2QQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id t4-v6si28049289ybo.253.2018.11.21.04.36.04 for (version=TLS1 cipher=AES128-SHA bits=128/128); Wed, 21 Nov 2018 04:36:04 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:38805 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gPRjf-0004S2-Ri for alex.bennee@linaro.org; Wed, 21 Nov 2018 07:36:03 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44495) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gPRjX-0004Rm-8y for qemu-arm@nongnu.org; Wed, 21 Nov 2018 07:35:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gPRjT-00072I-Af for qemu-arm@nongnu.org; Wed, 21 Nov 2018 07:35:55 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41852) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gPRjT-000729-5c; Wed, 21 Nov 2018 07:35:51 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 33B163086272; Wed, 21 Nov 2018 12:35:50 +0000 (UTC) Received: from redhat.com (ovpn-120-136.rdu2.redhat.com [10.10.120.136]) by smtp.corp.redhat.com (Postfix) with SMTP id 868BE60565; Wed, 21 Nov 2018 12:35:47 +0000 (UTC) Date: Wed, 21 Nov 2018 07:35:47 -0500 From: "Michael S. Tsirkin" To: Igor Mammedov Message-ID: <20181121072954-mutt-send-email-mst@kernel.org> References: <20181105014047.26447-1-sameo@linux.intel.com> <20181116172919.43f3e27d@redhat.com> <20181119163110.2f357f40@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181119163110.2f357f40@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Wed, 21 Nov 2018 12:35:50 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-arm] [Qemu-devel] [PATCH v5 00/24] ACPI reorganization for hardware-reduced API addition X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Stefano Stabellini , Samuel Ortiz , qemu-devel@nongnu.org, Shannon Zhao , qemu-arm@nongnu.org, xen-devel@lists.xenproject.org, Anthony Perard , Paolo Bonzini , Richard Henderson , Eduardo Habkost Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: iMqVA1BGxkUC On Mon, Nov 19, 2018 at 04:31:10PM +0100, Igor Mammedov wrote: > On Fri, 16 Nov 2018 17:37:54 +0100 > Paolo Bonzini wrote: > > > On 16/11/18 17:29, Igor Mammedov wrote: > > > General suggestions for this series: > > > 1. Preferably don't do multiple changes within a patch > > > neither post huge patches (unless it's pure code movement). > > > (it's easy to squash patches later it necessary) > > > 2. Start small, pick a table generalize it and send as > > > one small patchset. Tables are often independent > > > and it's much easier on both author/reviewer to agree upon > > > changes and rewrite it if necessary. > > > > How would that be done? This series is on the bigger side, agreed, but > > most of it is really just code movement. It's a starting point, having > > a generic ACPI library is way beyond what this is trying to do. > I've tried to give suggestions how to restructure series > on per patch basis. In my opinion it quite possible to split > series in several smaller ones and it should really help with > making series cleaner and easier/faster to review/amend/merge > vs what we have in v5. > (it's more frustrating to rework large series vs smaller one) > > If something isn't clear, it's easy to reach out to me here > or directly (email/irc/github) for clarification/feed back. I assume the #1 goal is to add reduced HW support. So another option to speed up merging is to just go ahead and duplicate a bunch of code e.g. in pc_virt.c acpi/reduced.c or in any other file. This way it might be easier to see what's common code and what isn't. And I think offline Igor said he might prefer that way. Right Igor? > > > > Paolo > > > > > 3. when you think about refactoring acpi into a generic API > > > think about it as routines that go into a separate library > > > (pure acpi spec code) and qemu/acpi glue routines and > > > divide them correspondingly. > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [Qemu-devel] [PATCH v5 00/24] ACPI reorganization for hardware-reduced API addition Date: Wed, 21 Nov 2018 07:35:47 -0500 Message-ID: <20181121072954-mutt-send-email-mst@kernel.org> References: <20181105014047.26447-1-sameo@linux.intel.com> <20181116172919.43f3e27d@redhat.com> <20181119163110.2f357f40@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1gPRjT-0006Ey-Se for xen-devel@lists.xenproject.org; Wed, 21 Nov 2018 12:35:51 +0000 Content-Disposition: inline In-Reply-To: <20181119163110.2f357f40@redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Igor Mammedov Cc: Peter Maydell , Stefano Stabellini , Samuel Ortiz , qemu-devel@nongnu.org, Shannon Zhao , qemu-arm@nongnu.org, xen-devel@lists.xenproject.org, Anthony Perard , Paolo Bonzini , Richard Henderson , Eduardo Habkost List-Id: xen-devel@lists.xenproject.org T24gTW9uLCBOb3YgMTksIDIwMTggYXQgMDQ6MzE6MTBQTSArMDEwMCwgSWdvciBNYW1tZWRvdiB3 cm90ZToKPiBPbiBGcmksIDE2IE5vdiAyMDE4IDE3OjM3OjU0ICswMTAwCj4gUGFvbG8gQm9uemlu aSA8cGJvbnppbmlAcmVkaGF0LmNvbT4gd3JvdGU6Cj4gCj4gPiBPbiAxNi8xMS8xOCAxNzoyOSwg SWdvciBNYW1tZWRvdiB3cm90ZToKPiA+ID4gR2VuZXJhbCBzdWdnZXN0aW9ucyBmb3IgdGhpcyBz ZXJpZXM6Cj4gPiA+ICAgMS4gUHJlZmVyYWJseSBkb24ndCBkbyBtdWx0aXBsZSBjaGFuZ2VzIHdp dGhpbiBhIHBhdGNoCj4gPiA+ICAgICAgbmVpdGhlciBwb3N0IGh1Z2UgcGF0Y2hlcyAodW5sZXNz IGl0J3MgcHVyZSBjb2RlIG1vdmVtZW50KS4KPiA+ID4gICAgICAoaXQncyBlYXN5IHRvIHNxdWFz aCBwYXRjaGVzIGxhdGVyIGl0IG5lY2Vzc2FyeSkKPiA+ID4gICAyLiBTdGFydCBzbWFsbCwgcGlj ayBhIHRhYmxlIGdlbmVyYWxpemUgaXQgYW5kIHNlbmQgYXMKPiA+ID4gICAgICBvbmUgc21hbGwg cGF0Y2hzZXQuIFRhYmxlcyBhcmUgb2Z0ZW4gaW5kZXBlbmRlbnQKPiA+ID4gICAgICBhbmQgaXQn cyBtdWNoIGVhc2llciBvbiBib3RoIGF1dGhvci9yZXZpZXdlciB0byBhZ3JlZSB1cG9uCj4gPiA+ ICAgICAgY2hhbmdlcyBhbmQgcmV3cml0ZSBpdCBpZiBuZWNlc3NhcnkuICAKPiA+IAo+ID4gSG93 IHdvdWxkIHRoYXQgYmUgZG9uZT8gIFRoaXMgc2VyaWVzIGlzIG9uIHRoZSBiaWdnZXIgc2lkZSwg YWdyZWVkLCBidXQKPiA+IG1vc3Qgb2YgaXQgaXMgcmVhbGx5IGp1c3QgY29kZSBtb3ZlbWVudC4g IEl0J3MgYSBzdGFydGluZyBwb2ludCwgaGF2aW5nCj4gPiBhIGdlbmVyaWMgQUNQSSBsaWJyYXJ5 IGlzIHdheSBiZXlvbmQgd2hhdCB0aGlzIGlzIHRyeWluZyB0byBkby4KPiBJJ3ZlIHRyaWVkIHRv IGdpdmUgc3VnZ2VzdGlvbnMgaG93IHRvIHJlc3RydWN0dXJlIHNlcmllcwo+IG9uIHBlciBwYXRj aCBiYXNpcy4gSW4gbXkgb3BpbmlvbiBpdCBxdWl0ZSBwb3NzaWJsZSB0byBzcGxpdAo+IHNlcmll cyBpbiBzZXZlcmFsIHNtYWxsZXIgb25lcyBhbmQgaXQgc2hvdWxkIHJlYWxseSBoZWxwIHdpdGgK PiBtYWtpbmcgc2VyaWVzIGNsZWFuZXIgYW5kIGVhc2llci9mYXN0ZXIgdG8gcmV2aWV3L2FtZW5k L21lcmdlCj4gdnMgd2hhdCB3ZSBoYXZlIGluIHY1Lgo+IChpdCdzIG1vcmUgZnJ1c3RyYXRpbmcg dG8gcmV3b3JrIGxhcmdlIHNlcmllcyB2cyBzbWFsbGVyIG9uZSkKPiAKPiBJZiBzb21ldGhpbmcg aXNuJ3QgY2xlYXIsIGl0J3MgZWFzeSB0byByZWFjaCBvdXQgdG8gbWUgaGVyZQo+IG9yIGRpcmVj dGx5IChlbWFpbC9pcmMvZ2l0aHViKSBmb3IgY2xhcmlmaWNhdGlvbi9mZWVkIGJhY2suCgpJIGFz c3VtZSB0aGUgIzEgZ29hbCBpcyB0byBhZGQgcmVkdWNlZCBIVyBzdXBwb3J0LiAgU28gYW5vdGhl cgpvcHRpb24gdG8gc3BlZWQgdXAgbWVyZ2luZyBpcyB0byBqdXN0IGdvIGFoZWFkIGFuZCBkdXBs aWNhdGUgYQpidW5jaCBvZiBjb2RlIGUuZy4gaW4gcGNfdmlydC5jIGFjcGkvcmVkdWNlZC5jIG9y IGluIGFueSBvdGhlcgpmaWxlLgpUaGlzIHdheSBpdCBtaWdodCBiZSBlYXNpZXIgdG8gc2VlIHdo YXQncyBjb21tb24gY29kZSBhbmQgd2hhdCBpc24ndC4KQW5kIEkgdGhpbmsgb2ZmbGluZSBJZ29y IHNhaWQgaGUgbWlnaHQgcHJlZmVyIHRoYXQgd2F5LiBSaWdodCBJZ29yPwoKPiA+IAo+ID4gUGFv bG8KPiA+IAo+ID4gPiAgIDMuIHdoZW4geW91IHRoaW5rIGFib3V0IHJlZmFjdG9yaW5nIGFjcGkg aW50byBhIGdlbmVyaWMgQVBJCj4gPiA+ICAgICAgdGhpbmsgYWJvdXQgaXQgYXMgcm91dGluZXMg dGhhdCBnbyBpbnRvIGEgc2VwYXJhdGUgbGlicmFyeQo+ID4gPiAgICAgIChwdXJlIGFjcGkgc3Bl YyBjb2RlKSBhbmQgcWVtdS9hY3BpIGdsdWUgcm91dGluZXMgYW5kCj4gPiA+ICAgICAgIGRpdmlk ZSB0aGVtIGNvcnJlc3BvbmRpbmdseS4gIAo+ID4gCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBs aXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4v bGlzdGluZm8veGVuLWRldmVs From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44513) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gPRja-0004SE-85 for qemu-devel@nongnu.org; Wed, 21 Nov 2018 07:35:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gPRjY-00079c-Fa for qemu-devel@nongnu.org; Wed, 21 Nov 2018 07:35:58 -0500 Date: Wed, 21 Nov 2018 07:35:47 -0500 From: "Michael S. Tsirkin" Message-ID: <20181121072954-mutt-send-email-mst@kernel.org> References: <20181105014047.26447-1-sameo@linux.intel.com> <20181116172919.43f3e27d@redhat.com> <20181119163110.2f357f40@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181119163110.2f357f40@redhat.com> Subject: Re: [Qemu-devel] [PATCH v5 00/24] ACPI reorganization for hardware-reduced API addition List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: Paolo Bonzini , Samuel Ortiz , qemu-devel@nongnu.org, Peter Maydell , Stefano Stabellini , Eduardo Habkost , Shannon Zhao , qemu-arm@nongnu.org, Anthony Perard , xen-devel@lists.xenproject.org, Richard Henderson On Mon, Nov 19, 2018 at 04:31:10PM +0100, Igor Mammedov wrote: > On Fri, 16 Nov 2018 17:37:54 +0100 > Paolo Bonzini wrote: > > > On 16/11/18 17:29, Igor Mammedov wrote: > > > General suggestions for this series: > > > 1. Preferably don't do multiple changes within a patch > > > neither post huge patches (unless it's pure code movement). > > > (it's easy to squash patches later it necessary) > > > 2. Start small, pick a table generalize it and send as > > > one small patchset. Tables are often independent > > > and it's much easier on both author/reviewer to agree upon > > > changes and rewrite it if necessary. > > > > How would that be done? This series is on the bigger side, agreed, but > > most of it is really just code movement. It's a starting point, having > > a generic ACPI library is way beyond what this is trying to do. > I've tried to give suggestions how to restructure series > on per patch basis. In my opinion it quite possible to split > series in several smaller ones and it should really help with > making series cleaner and easier/faster to review/amend/merge > vs what we have in v5. > (it's more frustrating to rework large series vs smaller one) > > If something isn't clear, it's easy to reach out to me here > or directly (email/irc/github) for clarification/feed back. I assume the #1 goal is to add reduced HW support. So another option to speed up merging is to just go ahead and duplicate a bunch of code e.g. in pc_virt.c acpi/reduced.c or in any other file. This way it might be easier to see what's common code and what isn't. And I think offline Igor said he might prefer that way. Right Igor? > > > > Paolo > > > > > 3. when you think about refactoring acpi into a generic API > > > think about it as routines that go into a separate library > > > (pure acpi spec code) and qemu/acpi glue routines and > > > divide them correspondingly. > >