From: Stephen Hemminger <stephen@networkplumber.org>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: netdev@vger.kernel.org, dsahern@gmail.com, joe@wand.net.nz,
daniel@iogearbox.net
Subject: Re: [PATCH iproute2] ipnetns: parse nsid as a signed integer
Date: Wed, 21 Nov 2018 09:37:42 -0800 [thread overview]
Message-ID: <20181121093742.47755677@xeon-e3> (raw)
In-Reply-To: <20181121094427.19007-1-nicolas.dichtel@6wind.com>
On Wed, 21 Nov 2018 10:44:27 +0100
Nicolas Dichtel <nicolas.dichtel@6wind.com> wrote:
> Don't confuse the user, nsid is a signed integer, this kind of command
> should return an error: 'ip netns set foo 0xffffffff'.
>
> Also, a valid value is a positive value. To let the kernel chooses a value,
> the keyword 'auto' must be used.
>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Thanks for catching this. Next time add a Fixes: tag if possible.
Applied.
prev parent reply other threads:[~2018-11-22 4:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-19 3:26 netns_id in bpf_sk_lookup_{tcp,udp} David Ahern
2018-11-19 18:36 ` Joe Stringer
2018-11-19 18:39 ` David Ahern
2018-11-19 19:47 ` Joe Stringer
2018-11-19 19:54 ` David Ahern
2018-11-19 20:28 ` Nicolas Dichtel
2018-11-19 20:54 ` Joe Stringer
2018-11-19 21:59 ` Joe Stringer
2018-11-19 23:46 ` David Ahern
2018-11-20 9:05 ` Nicolas Dichtel
2018-11-20 15:46 ` David Ahern
2018-11-20 16:03 ` Nicolas Dichtel
2018-11-21 5:12 ` David Ahern
2018-11-21 9:44 ` [PATCH iproute2] ipnetns: parse nsid as a signed integer Nicolas Dichtel
2018-11-21 17:37 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181121093742.47755677@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=daniel@iogearbox.net \
--cc=dsahern@gmail.com \
--cc=joe@wand.net.nz \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.