From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/wolfssl: bump to version 3.15.5
Date: Wed, 21 Nov 2018 09:40:48 +0100 [thread overview]
Message-ID: <20181121094048.4fc2e0c6@windsurf> (raw)
In-Reply-To: <20181120173801.15024-1-sergio.prado@e-labworks.com>
Hello Sergio,
On Tue, 20 Nov 2018 15:38:01 -0200, Sergio Prado wrote:
> Also enable ARMv8 hardware acceleration (tested with
> qemu_aarch64_virt_defconfig).
Could be done in two separate patches (bump and ARMv8 HW acceleration
enabling).
> -# build fails when ARMv8 hardware acceleration is enabled
> +# enable ARMv8 hardware acceleration
> +ifeq ($(BR2_ARM_CPU_ARMV8A),y)
> +WOLFSSL_CONF_OPTS += --enable-armasm CPPFLAGS=-mstrict-align
Why is -mstrict-align needed ? A comment above, or at least in the
commit log would be useful. Also, don't override CPPFLAGS like this,
something like that would be preferred:
WOLFSSL_CONF_ENV += CPPFLAGS="$(TARGET_CPPFLAGS) -mstrict-align"
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2018-11-21 8:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 17:38 [Buildroot] [PATCH] package/wolfssl: bump to version 3.15.5 Sergio Prado
2018-11-21 8:40 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181121094048.4fc2e0c6@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.