From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/atomic: Fix the early return in drm_atomic_set_mode_for_crtc() Date: Wed, 21 Nov 2018 13:15:24 +0200 Message-ID: <20181121111524.GY9144@intel.com> References: <20181120175542.26083-1-ville.syrjala@linux.intel.com> <20181121095956.GQ4266@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20181121095956.GQ4266@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBOb3YgMjEsIDIwMTggYXQgMTA6NTk6NTZBTSArMDEwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBPbiBUdWUsIE5vdiAyMCwgMjAxOCBhdCAwNzo1NTo0MlBNICswMjAwLCBWaWxsZSBT eXJqYWxhIHdyb3RlOgo+ID4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxp bnV4LmludGVsLmNvbT4KPiA+IAo+ID4gVGhlIGVhcmx5IHJldHVybiBpbiBkcm1fYXRvbWljX3Nl dF9tb2RlX2Zvcl9jcnRjKCkgaXNuJ3QgcXVpdGUKPiA+IHJpZ2h0LiBJdCB3b3VsZCBtaXN0YWtl bmx5IHJldHVybiBhbmQgZmFpbCB0byB1cGRhdGUKPiA+IGNydGNfc3RhdGUtPmVuYWJsZSBpZiBz b21lb25lIGFjdHVhbGx5IHRyaWVkIHRvIHNldCBhIHplcm9lZAo+ID4gbW9kZSBvbiBhIGN1cnJl bnRseSBkaXNhYmxlZCBjcnRjLiBJIHN1cHBvc2UgdGhhdCBzaG91bGQgbmV2ZXIKPiA+IGhhcHBl biBidXQgYmV0dGVyIHNhZmUgdGhhbiBzb3JyeS4KPiA+IAo+ID4gQWRkaXRpb25hbGx5IHRoZSBl YXJseSByZXR1cm4gd2lsbCBub3QgYmUgdGFrZW4gaWYgd2UncmUgdHJ5aW5nIHRvCj4gPiBkaXNh YmxlIGFuIGFscmVhZHkgZGlzYWJsZSBjcnRjLiBXaGlsZSB0aGF0IGlzIG5vdCBhY3R1YWxseSBo YXJtZnVsCj4gPiBpdCBpcyBpbmNvbnNpc3RlbnQsIHNvIGxldCdzIGhhbmRsZSB0aGF0IGNhc2Ug YXMgd2VsbC4KPiA+IAo+ID4gU2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5z eXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiAKPiBEbyB3ZSBoYXZlIGFuIGlndCBmb3IgdGhpcz8g SS5lLiB0cnlpbmcgdG8gc2V0IGEgYWxsLTAgbW9kZSBmb3IgYSBkaXNhYmxlZAo+IENSVEMgYW5k IHNlZWluZyB3aGF0IGhhcHBlbnMgLi4uCgpJdCBzaG91bGQgZ2V0IHJlamVjdGVkIGJ5IGRybV9t b2RlX2NvbnZlcnRfdW1vZGUoKS0+ZHJtX21vZGVfdmFsaWRhdGVfYmFzaWMoKQpzbyBwcmVzdW1h Ymx5IHlvdSBzaG91bGRuJ3QgYmUgYWJsZSB0byBkbyB0aGlzIGZyb20gdXNlcnNwYWNlLiBJbiBr ZXJuZWwKdXNlcnMgY291bGQgYnlwYXNzIHRoYXQgY2hlY2sgYW5kIHNuZWFrIHNvbWV0aGluZyBs aWtlIHRoaXMgaW4gaG93ZXZlci4KCkJ1dCBJIGd1ZXNzIGhhdmluZyBhbiBpZ3QgdG8gdmVyaWZ5 IHRoYXQgd2UgZG8gaW5kZWVkIHJlamVjdCBiYWQgbW9kZXMKd291bGQgYSBkZWNlbnQgaWRlYS4g TG9va3MgbGlrZSBjdXJyZW50bHkgd2Ugb25seSBoYXZlCmttc19pbnZhbGlkX2RvdGNsb2NrLgoK PiAKPiBQYXRjaCBpdHNlbGYgbG9va3MgZmluZSwgaGFzIG15IHItYiBpZiB0aGUgaWd0IG1hdGVy aWFsaXplcy4KPiAtRGFuaWVsCj4gCj4gPiAtLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2F0 b21pY191YXBpLmMgfCA5ICsrKysrKystLQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlv bnMoKyksIDIgZGVsZXRpb25zKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vZHJtX2F0b21pY191YXBpLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY191YXBpLmMK PiA+IGluZGV4IDg2YWMzMzkyMmIwOS4uZWQwZWE4MmU4YTFkIDEwMDY0NAo+ID4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2RybV9hdG9taWNfdWFwaS5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v ZHJtX2F0b21pY191YXBpLmMKPiA+IEBAIC02OCw4ICs2OCwxMyBAQCBpbnQgZHJtX2F0b21pY19z ZXRfbW9kZV9mb3JfY3J0YyhzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKnN0YXRlLAo+ID4gIAlzdHJ1 Y3QgZHJtX21vZGVfbW9kZWluZm8gdW1vZGU7Cj4gPiAgCj4gPiAgCS8qIEVhcmx5IHJldHVybiBm b3Igbm8gY2hhbmdlLiAqLwo+ID4gLQlpZiAobW9kZSAmJiBtZW1jbXAoJnN0YXRlLT5tb2RlLCBt b2RlLCBzaXplb2YoKm1vZGUpKSA9PSAwKQo+ID4gLQkJcmV0dXJuIDA7Cj4gPiArCWlmIChzdGF0 ZS0+ZW5hYmxlKSB7Cj4gPiArCQlpZiAobW9kZSAmJiBtZW1jbXAoJnN0YXRlLT5tb2RlLCBtb2Rl LCBzaXplb2YoKm1vZGUpKSA9PSAwKQo+ID4gKwkJCXJldHVybiAwOwo+ID4gKwl9IGVsc2Ugewo+ ID4gKwkJaWYgKCFtb2RlKQo+ID4gKwkJCXJldHVybiAwOwo+ID4gKwl9Cj4gPiAgCj4gPiAgCWRy bV9wcm9wZXJ0eV9ibG9iX3B1dChzdGF0ZS0+bW9kZV9ibG9iKTsKPiA+ICAJc3RhdGUtPm1vZGVf YmxvYiA9IE5VTEw7Cj4gPiAtLSAKPiA+IDIuMTguMQo+ID4gCj4gPiBfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ID4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlz dAo+ID4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4gaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKPiAKPiAtLSAKPiBEYW5p ZWwgVmV0dGVyCj4gU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCj4gaHR0cDov L2Jsb2cuZmZ3bGwuY2gKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJ bnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==