Re: [Qemu-devel] [PATCH] migration/migration.c: Add COLO dependency checks

["Dr. David Alan Gilbert" <dgilbert@redhat.com>]

* Zhang Chen (chen.zhang@intel.com) wrote:
> From: Zhang Chen <chen.zhang@intel.com>
> 
> Current COLO mode(independent disk mode) need replication module work
> together. Suggested by Dr. David Alan Gilbert <dgilbert@redhat.com>.
> 
> Signed-off-by: Zhang Chen <chen.zhang@intel.com>

Queued

> ---
>  migration/migration.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/migration/migration.c b/migration/migration.c
> index b261c1e4ce..49ffb9997a 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -918,6 +918,15 @@ static bool migrate_caps_check(bool *cap_list,
>      }
>  #endif
>  
> +#ifndef CONFIG_REPLICATION
> +    if (cap_list[MIGRATION_CAPABILITY_X_COLO]) {
> +        error_setg(errp, "QEMU compiled without replication module"
> +                   " can't enable COLO");
> +        error_append_hint(errp, "Please enable replication before COLO.\n");
> +        return false;
> +    }
> +#endif
> +
>      if (cap_list[MIGRATION_CAPABILITY_POSTCOPY_RAM]) {
>          if (cap_list[MIGRATION_CAPABILITY_COMPRESS]) {
>              /* The decompression threads asynchronously write into RAM
> -- 
> 2.17.GIT
> 
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK