From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Pavel Popa <pashinho1990@gmail.com>
Cc: David Ahern <dsahern@gmail.com>,
xdp-newbies@vger.kernel.org, jasowang@redhat.com,
brouer@redhat.com, Daniel Borkmann <borkmann@iogearbox.net>
Subject: Re: qemu-kvm XDP forwarding with virtio_net
Date: Wed, 21 Nov 2018 11:52:09 +0100 [thread overview]
Message-ID: <20181121115209.4d186d7c@redhat.com> (raw)
In-Reply-To: <CAHOxX0yUuk5rR2iQwYwgWS7+HH-bzZ60VFHw1jo4eAGVkED4pg@mail.gmail.com>
On Wed, 21 Nov 2018 11:01:45 +0100
Pavel Popa <pashinho1990@gmail.com> wrote:
> For what I see, the only way to return -EFAULT is in this case
> https://elixir.bootlin.com/linux/v4.18.10/source/net/core/filter.c#L3259.
> This may explain the "to_ifindex=0" thing, as 'fwd' is initialized
> NULL. But I don't understand the meaning of the
> "xdp_map_invalid(xdp_prog, map_owner)" condition. So, if that's really
> the case, what can be inferred from this?
Are you using BPF-tail calls?
Well that code got removed in kernel 4.19:
Commit f6069b9aa993 ("bpf: fix redirect to map under tail calls")
https://git.kernel.org/torvalds/c/f6069b9aa993
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
$ git describe --contains f6069b9aa993
v4.19-rc1~86^2~6^2
next prev parent reply other threads:[~2018-11-21 21:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 14:18 qemu-kvm XDP forwarding with virtio_net Pavel Popa
2018-11-20 14:39 ` David Ahern
2018-11-20 15:47 ` Pavel Popa
2018-11-20 18:14 ` Jesper Dangaard Brouer
2018-11-20 18:19 ` David Ahern
2018-11-21 9:08 ` Pavel Popa
2018-11-21 10:01 ` Pavel Popa
2018-11-21 10:52 ` Jesper Dangaard Brouer [this message]
2018-11-21 11:50 ` Pavel Popa
2018-11-22 2:14 ` Jason Wang
2018-11-23 17:09 ` Pavel Popa
2018-11-26 6:36 ` Jason Wang
2018-11-29 5:50 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181121115209.4d186d7c@redhat.com \
--to=brouer@redhat.com \
--cc=borkmann@iogearbox.net \
--cc=dsahern@gmail.com \
--cc=jasowang@redhat.com \
--cc=pashinho1990@gmail.com \
--cc=xdp-newbies@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.