From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a5d:6089:0:0:0:0:0 with SMTP id w9csp1950414wrt; Wed, 21 Nov 2018 06:39:06 -0800 (PST) X-Google-Smtp-Source: AFSGD/X9jp7uC16/g2goze+N3bFoUhY4PimPHEJ/gvFaWepT4HBZ+jfUqt28VukULDD6sbjh1ohk X-Received: by 2002:a5b:412:: with SMTP id m18-v6mr6524013ybp.132.1542811146268; Wed, 21 Nov 2018 06:39:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542811146; cv=none; d=google.com; s=arc-20160816; b=slk5b8Wiq3Fx3EfwgRSv6CI6o5fzCaye+QWmONEqavVOibLfs+/RdYyF3Os3iPm3nT XLMTvqDsjX/wLDuBPJ2kZUIC46sQBkMhi2YmKleRcmrGBS7EN0B/R9N3V7DBzMnjGgrh iHNuRwCP50Rr61Y1d3vP11hhUhi6pijqYtq8rNbkbVsqsWmA2iv0lNIvjp5GrYx6kNiP PCIMMdHtBPkGK9nNByrFC4A/t6Avzg0v9Qljf2euae4jlc35mS+gA2T+rz0NUEpNpsOw Rl9618c2L6eCbGkabqiVsMxpkwbX2Z1B0zqfHJIXF48HQA6tcTL4gaWV8c6Qes0IbvzJ JRCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:to:from:date; bh=G9w2wsDqbpLj/fgNlV1c1bG4FRLBfTijgyhGSNIINFk=; b=NjpqjQupCKBaCLqPcMtNLofA8RzNnMpWUQTSDvSO4ytxnga5rgMuQxbbLDpLZhDSHE nd8ScJBI9UCFuHNf8O9lsSWxTK3GBNHFCvKg1rSkrmioO7YlrDXwsVoc7ke5nI1kDzwm /OhuG7FxNytmva+kDdtu8z7+JXvDbRq1HO1eqWA0baVI0q8y7nom3VF4MnfWUTjNlsfJ P4RQa9csnAUA09eykyGJzoFa448crg6Sf5v0oU8LbYdHHh+l2ut16x5vYfDww8OSfp+W lCHBuDVtfb/yg9xyXMiIYq3GzqkvhbUuyynbht3P5PilERSrZA9mA4h4iGDEIPZ574fc nfEQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id r9-v6si28513731ywc.21.2018.11.21.06.39.06 for (version=TLS1 cipher=AES128-SHA bits=128/128); Wed, 21 Nov 2018 06:39:06 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from localhost ([::1]:39517 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gPTej-0006rf-Om for alex.bennee@linaro.org; Wed, 21 Nov 2018 09:39:05 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60044) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gPTec-0006rT-JF for qemu-arm@nongnu.org; Wed, 21 Nov 2018 09:38:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gPTeY-0005P8-L8 for qemu-arm@nongnu.org; Wed, 21 Nov 2018 09:38:58 -0500 Received: from mga03.intel.com ([134.134.136.65]:5151) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gPTeY-0005OH-D9; Wed, 21 Nov 2018 09:38:54 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Nov 2018 06:38:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,261,1539673200"; d="scan'208";a="93814622" Received: from tterrive-mobl2.ger.corp.intel.com (HELO caravaggio) ([10.252.4.181]) by orsmga008.jf.intel.com with ESMTP; 21 Nov 2018 06:38:49 -0800 Date: Wed, 21 Nov 2018 15:38:16 +0100 From: Samuel Ortiz To: Igor Mammedov Message-ID: <20181121143816.GD4426@caravaggio> References: <20181105014047.26447-1-sameo@linux.intel.com> <20181116172919.43f3e27d@redhat.com> <20181119163110.2f357f40@redhat.com> <20181121072954-mutt-send-email-mst@kernel.org> <20181121151526.5785b43f@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181121151526.5785b43f@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 134.134.136.65 Subject: Re: [Qemu-arm] [Qemu-devel] [PATCH v5 00/24] ACPI reorganization for hardware-reduced API addition X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Stefano Stabellini , Eduardo Habkost , "Michael S. Tsirkin" , qemu-devel@nongnu.org, Shannon Zhao , qemu-arm@nongnu.org, Paolo Bonzini , Anthony Perard , xen-devel@lists.xenproject.org, Richard Henderson Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: yC7MExs3gthX Igor, On Wed, Nov 21, 2018 at 03:15:26PM +0100, Igor Mammedov wrote: > On Wed, 21 Nov 2018 07:35:47 -0500 > "Michael S. Tsirkin" wrote: > > > On Mon, Nov 19, 2018 at 04:31:10PM +0100, Igor Mammedov wrote: > > > On Fri, 16 Nov 2018 17:37:54 +0100 > > > Paolo Bonzini wrote: > > > > > > > On 16/11/18 17:29, Igor Mammedov wrote: > > > > > General suggestions for this series: > > > > > 1. Preferably don't do multiple changes within a patch > > > > > neither post huge patches (unless it's pure code movement). > > > > > (it's easy to squash patches later it necessary) > > > > > 2. Start small, pick a table generalize it and send as > > > > > one small patchset. Tables are often independent > > > > > and it's much easier on both author/reviewer to agree upon > > > > > changes and rewrite it if necessary. > > > > > > > > How would that be done? This series is on the bigger side, agreed, but > > > > most of it is really just code movement. It's a starting point, having > > > > a generic ACPI library is way beyond what this is trying to do. > > > I've tried to give suggestions how to restructure series > > > on per patch basis. In my opinion it quite possible to split > > > series in several smaller ones and it should really help with > > > making series cleaner and easier/faster to review/amend/merge > > > vs what we have in v5. > > > (it's more frustrating to rework large series vs smaller one) > > > > > > If something isn't clear, it's easy to reach out to me here > > > or directly (email/irc/github) for clarification/feed back. > > > > I assume the #1 goal is to add reduced HW support. So another > > option to speed up merging is to just go ahead and duplicate a > > bunch of code e.g. in pc_virt.c acpi/reduced.c or in any other > > file. > > This way it might be easier to see what's common code and what isn't. > > And I think offline Igor said he might prefer that way. Right Igor? > You mean probably 'x86 reduced hw' support. That's was what I've > already suggested for PCI AML code during patch review. Just don't > call it generic when it's not and place code in hw/i386/ directory beside > acpi-build.c. It might apply to some other tables (i.e. complex cases). > > On per patch review I gave suggestions how to amend series to make > it acceptable without doing complex refactoring and pointed out > places we probably shouldn't refactor now and just duplicate as > it's too complex or not clear how to generalize it yet. > > Problem with duplication is that a random contributor is not > around to clean code up after a feature is merged and we end up > with a bunch of messy code. > > A word to the contributors, > Don't do refactoring in silence, keep discussing approaches here, > suggest alternatives. That way it's easier to reach a compromise > and merge it with less iterations. And if you do split it in smaller > parts, the process should go even faster. > > I'll sent a small RSDP refactoring series for reference. I was already working on the RSDP changes. Let me know if I should drop that work too. Cheers, Samuel. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Samuel Ortiz Subject: Re: [Qemu-devel] [PATCH v5 00/24] ACPI reorganization for hardware-reduced API addition Date: Wed, 21 Nov 2018 15:38:16 +0100 Message-ID: <20181121143816.GD4426@caravaggio> References: <20181105014047.26447-1-sameo@linux.intel.com> <20181116172919.43f3e27d@redhat.com> <20181119163110.2f357f40@redhat.com> <20181121072954-mutt-send-email-mst@kernel.org> <20181121151526.5785b43f@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1gPTeZ-0003M7-NO for xen-devel@lists.xenproject.org; Wed, 21 Nov 2018 14:38:55 +0000 Content-Disposition: inline In-Reply-To: <20181121151526.5785b43f@redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Igor Mammedov Cc: Peter Maydell , Stefano Stabellini , Eduardo Habkost , "Michael S. Tsirkin" , qemu-devel@nongnu.org, Shannon Zhao , qemu-arm@nongnu.org, Paolo Bonzini , Anthony Perard , xen-devel@lists.xenproject.org, Richard Henderson List-Id: xen-devel@lists.xenproject.org SWdvciwKCk9uIFdlZCwgTm92IDIxLCAyMDE4IGF0IDAzOjE1OjI2UE0gKzAxMDAsIElnb3IgTWFt bWVkb3Ygd3JvdGU6Cj4gT24gV2VkLCAyMSBOb3YgMjAxOCAwNzozNTo0NyAtMDUwMAo+ICJNaWNo YWVsIFMuIFRzaXJraW4iIDxtc3RAcmVkaGF0LmNvbT4gd3JvdGU6Cj4gCj4gPiBPbiBNb24sIE5v diAxOSwgMjAxOCBhdCAwNDozMToxMFBNICswMTAwLCBJZ29yIE1hbW1lZG92IHdyb3RlOgo+ID4g PiBPbiBGcmksIDE2IE5vdiAyMDE4IDE3OjM3OjU0ICswMTAwCj4gPiA+IFBhb2xvIEJvbnppbmkg PHBib256aW5pQHJlZGhhdC5jb20+IHdyb3RlOgo+ID4gPiAgIAo+ID4gPiA+IE9uIDE2LzExLzE4 IDE3OjI5LCBJZ29yIE1hbW1lZG92IHdyb3RlOiAgCj4gPiA+ID4gPiBHZW5lcmFsIHN1Z2dlc3Rp b25zIGZvciB0aGlzIHNlcmllczoKPiA+ID4gPiA+ICAgMS4gUHJlZmVyYWJseSBkb24ndCBkbyBt dWx0aXBsZSBjaGFuZ2VzIHdpdGhpbiBhIHBhdGNoCj4gPiA+ID4gPiAgICAgIG5laXRoZXIgcG9z dCBodWdlIHBhdGNoZXMgKHVubGVzcyBpdCdzIHB1cmUgY29kZSBtb3ZlbWVudCkuCj4gPiA+ID4g PiAgICAgIChpdCdzIGVhc3kgdG8gc3F1YXNoIHBhdGNoZXMgbGF0ZXIgaXQgbmVjZXNzYXJ5KQo+ ID4gPiA+ID4gICAyLiBTdGFydCBzbWFsbCwgcGljayBhIHRhYmxlIGdlbmVyYWxpemUgaXQgYW5k IHNlbmQgYXMKPiA+ID4gPiA+ICAgICAgb25lIHNtYWxsIHBhdGNoc2V0LiBUYWJsZXMgYXJlIG9m dGVuIGluZGVwZW5kZW50Cj4gPiA+ID4gPiAgICAgIGFuZCBpdCdzIG11Y2ggZWFzaWVyIG9uIGJv dGggYXV0aG9yL3Jldmlld2VyIHRvIGFncmVlIHVwb24KPiA+ID4gPiA+ICAgICAgY2hhbmdlcyBh bmQgcmV3cml0ZSBpdCBpZiBuZWNlc3NhcnkuICAgIAo+ID4gPiA+IAo+ID4gPiA+IEhvdyB3b3Vs ZCB0aGF0IGJlIGRvbmU/ICBUaGlzIHNlcmllcyBpcyBvbiB0aGUgYmlnZ2VyIHNpZGUsIGFncmVl ZCwgYnV0Cj4gPiA+ID4gbW9zdCBvZiBpdCBpcyByZWFsbHkganVzdCBjb2RlIG1vdmVtZW50LiAg SXQncyBhIHN0YXJ0aW5nIHBvaW50LCBoYXZpbmcKPiA+ID4gPiBhIGdlbmVyaWMgQUNQSSBsaWJy YXJ5IGlzIHdheSBiZXlvbmQgd2hhdCB0aGlzIGlzIHRyeWluZyB0byBkby4gIAo+ID4gPiBJJ3Zl IHRyaWVkIHRvIGdpdmUgc3VnZ2VzdGlvbnMgaG93IHRvIHJlc3RydWN0dXJlIHNlcmllcwo+ID4g PiBvbiBwZXIgcGF0Y2ggYmFzaXMuIEluIG15IG9waW5pb24gaXQgcXVpdGUgcG9zc2libGUgdG8g c3BsaXQKPiA+ID4gc2VyaWVzIGluIHNldmVyYWwgc21hbGxlciBvbmVzIGFuZCBpdCBzaG91bGQg cmVhbGx5IGhlbHAgd2l0aAo+ID4gPiBtYWtpbmcgc2VyaWVzIGNsZWFuZXIgYW5kIGVhc2llci9m YXN0ZXIgdG8gcmV2aWV3L2FtZW5kL21lcmdlCj4gPiA+IHZzIHdoYXQgd2UgaGF2ZSBpbiB2NS4K PiA+ID4gKGl0J3MgbW9yZSBmcnVzdHJhdGluZyB0byByZXdvcmsgbGFyZ2Ugc2VyaWVzIHZzIHNt YWxsZXIgb25lKQo+ID4gPiAKPiA+ID4gSWYgc29tZXRoaW5nIGlzbid0IGNsZWFyLCBpdCdzIGVh c3kgdG8gcmVhY2ggb3V0IHRvIG1lIGhlcmUKPiA+ID4gb3IgZGlyZWN0bHkgKGVtYWlsL2lyYy9n aXRodWIpIGZvciBjbGFyaWZpY2F0aW9uL2ZlZWQgYmFjay4gIAo+ID4gCj4gPiBJIGFzc3VtZSB0 aGUgIzEgZ29hbCBpcyB0byBhZGQgcmVkdWNlZCBIVyBzdXBwb3J0LiAgU28gYW5vdGhlcgo+ID4g b3B0aW9uIHRvIHNwZWVkIHVwIG1lcmdpbmcgaXMgdG8ganVzdCBnbyBhaGVhZCBhbmQgZHVwbGlj YXRlIGEKPiA+IGJ1bmNoIG9mIGNvZGUgZS5nLiBpbiBwY192aXJ0LmMgYWNwaS9yZWR1Y2VkLmMg b3IgaW4gYW55IG90aGVyCj4gPiBmaWxlLgo+ID4gVGhpcyB3YXkgaXQgbWlnaHQgYmUgZWFzaWVy IHRvIHNlZSB3aGF0J3MgY29tbW9uIGNvZGUgYW5kIHdoYXQgaXNuJ3QuCj4gPiBBbmQgSSB0aGlu ayBvZmZsaW5lIElnb3Igc2FpZCBoZSBtaWdodCBwcmVmZXIgdGhhdCB3YXkuIFJpZ2h0IElnb3I/ Cj4gWW91IG1lYW4gcHJvYmFibHkgJ3g4NiByZWR1Y2VkIGh3JyBzdXBwb3J0LiBUaGF0J3Mgd2Fz IHdoYXQgSSd2ZQo+IGFscmVhZHkgc3VnZ2VzdGVkIGZvciBQQ0kgQU1MIGNvZGUgZHVyaW5nIHBh dGNoIHJldmlldy4gSnVzdCBkb24ndAo+IGNhbGwgaXQgZ2VuZXJpYyB3aGVuIGl0J3Mgbm90IGFu ZCBwbGFjZSBjb2RlIGluIGh3L2kzODYvIGRpcmVjdG9yeSBiZXNpZGUKPiBhY3BpLWJ1aWxkLmMu IEl0IG1pZ2h0IGFwcGx5IHRvIHNvbWUgb3RoZXIgdGFibGVzIChpLmUuIGNvbXBsZXggY2FzZXMp Lgo+IAo+IE9uIHBlciBwYXRjaCByZXZpZXcgSSBnYXZlIHN1Z2dlc3Rpb25zIGhvdyB0byBhbWVu ZCBzZXJpZXMgdG8gbWFrZQo+IGl0IGFjY2VwdGFibGUgd2l0aG91dCBkb2luZyBjb21wbGV4IHJl ZmFjdG9yaW5nIGFuZCBwb2ludGVkIG91dAo+IHBsYWNlcyB3ZSBwcm9iYWJseSBzaG91bGRuJ3Qg cmVmYWN0b3Igbm93IGFuZCBqdXN0IGR1cGxpY2F0ZSBhcwo+IGl0J3MgdG9vIGNvbXBsZXggb3Ig bm90IGNsZWFyIGhvdyB0byBnZW5lcmFsaXplIGl0IHlldC4KPiAKPiBQcm9ibGVtIHdpdGggZHVw bGljYXRpb24gaXMgdGhhdCBhIHJhbmRvbSBjb250cmlidXRvciBpcyBub3QKPiBhcm91bmQgdG8g Y2xlYW4gY29kZSB1cCBhZnRlciBhIGZlYXR1cmUgaXMgbWVyZ2VkIGFuZCB3ZSBlbmQgdXAKPiB3 aXRoIGEgYnVuY2ggb2YgbWVzc3kgY29kZS4KPiAKPiBBIHdvcmQgdG8gdGhlIGNvbnRyaWJ1dG9y cywKPiBEb24ndCBkbyByZWZhY3RvcmluZyBpbiBzaWxlbmNlLCBrZWVwIGRpc2N1c3NpbmcgYXBw cm9hY2hlcyBoZXJlLAo+IHN1Z2dlc3QgYWx0ZXJuYXRpdmVzLiBUaGF0IHdheSBpdCdzIGVhc2ll ciB0byByZWFjaCBhIGNvbXByb21pc2UKPiBhbmQgbWVyZ2UgaXQgd2l0aCBsZXNzIGl0ZXJhdGlv bnMuIEFuZCBpZiB5b3UgZG8gc3BsaXQgaXQgaW4gc21hbGxlcgo+IHBhcnRzLCB0aGUgcHJvY2Vz cyBzaG91bGQgZ28gZXZlbiBmYXN0ZXIuCj4gCj4gSSdsbCBzZW50IGEgc21hbGwgUlNEUCByZWZh Y3RvcmluZyBzZXJpZXMgZm9yIHJlZmVyZW5jZS4KSSB3YXMgYWxyZWFkeSB3b3JraW5nIG9uIHRo ZSBSU0RQIGNoYW5nZXMuIExldCBtZSBrbm93IGlmIEkgc2hvdWxkIGRyb3AKdGhhdCB3b3JrIHRv by4KCkNoZWVycywKU2FtdWVsLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJv amVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hl bi1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60069) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gPTee-0006rd-Cp for qemu-devel@nongnu.org; Wed, 21 Nov 2018 09:39:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gPTed-0005Rz-HR for qemu-devel@nongnu.org; Wed, 21 Nov 2018 09:39:00 -0500 Date: Wed, 21 Nov 2018 15:38:16 +0100 From: Samuel Ortiz Message-ID: <20181121143816.GD4426@caravaggio> References: <20181105014047.26447-1-sameo@linux.intel.com> <20181116172919.43f3e27d@redhat.com> <20181119163110.2f357f40@redhat.com> <20181121072954-mutt-send-email-mst@kernel.org> <20181121151526.5785b43f@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181121151526.5785b43f@redhat.com> Subject: Re: [Qemu-devel] [PATCH v5 00/24] ACPI reorganization for hardware-reduced API addition List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: "Michael S. Tsirkin" , Peter Maydell , Stefano Stabellini , qemu-devel@nongnu.org, Shannon Zhao , qemu-arm@nongnu.org, xen-devel@lists.xenproject.org, Anthony Perard , Paolo Bonzini , Richard Henderson , Eduardo Habkost Igor, On Wed, Nov 21, 2018 at 03:15:26PM +0100, Igor Mammedov wrote: > On Wed, 21 Nov 2018 07:35:47 -0500 > "Michael S. Tsirkin" wrote: > > > On Mon, Nov 19, 2018 at 04:31:10PM +0100, Igor Mammedov wrote: > > > On Fri, 16 Nov 2018 17:37:54 +0100 > > > Paolo Bonzini wrote: > > > > > > > On 16/11/18 17:29, Igor Mammedov wrote: > > > > > General suggestions for this series: > > > > > 1. Preferably don't do multiple changes within a patch > > > > > neither post huge patches (unless it's pure code movement). > > > > > (it's easy to squash patches later it necessary) > > > > > 2. Start small, pick a table generalize it and send as > > > > > one small patchset. Tables are often independent > > > > > and it's much easier on both author/reviewer to agree upon > > > > > changes and rewrite it if necessary. > > > > > > > > How would that be done? This series is on the bigger side, agreed, but > > > > most of it is really just code movement. It's a starting point, having > > > > a generic ACPI library is way beyond what this is trying to do. > > > I've tried to give suggestions how to restructure series > > > on per patch basis. In my opinion it quite possible to split > > > series in several smaller ones and it should really help with > > > making series cleaner and easier/faster to review/amend/merge > > > vs what we have in v5. > > > (it's more frustrating to rework large series vs smaller one) > > > > > > If something isn't clear, it's easy to reach out to me here > > > or directly (email/irc/github) for clarification/feed back. > > > > I assume the #1 goal is to add reduced HW support. So another > > option to speed up merging is to just go ahead and duplicate a > > bunch of code e.g. in pc_virt.c acpi/reduced.c or in any other > > file. > > This way it might be easier to see what's common code and what isn't. > > And I think offline Igor said he might prefer that way. Right Igor? > You mean probably 'x86 reduced hw' support. That's was what I've > already suggested for PCI AML code during patch review. Just don't > call it generic when it's not and place code in hw/i386/ directory beside > acpi-build.c. It might apply to some other tables (i.e. complex cases). > > On per patch review I gave suggestions how to amend series to make > it acceptable without doing complex refactoring and pointed out > places we probably shouldn't refactor now and just duplicate as > it's too complex or not clear how to generalize it yet. > > Problem with duplication is that a random contributor is not > around to clean code up after a feature is merged and we end up > with a bunch of messy code. > > A word to the contributors, > Don't do refactoring in silence, keep discussing approaches here, > suggest alternatives. That way it's easier to reach a compromise > and merge it with less iterations. And if you do split it in smaller > parts, the process should go even faster. > > I'll sent a small RSDP refactoring series for reference. I was already working on the RSDP changes. Let me know if I should drop that work too. Cheers, Samuel.