From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] perf: xgene: Add CPU hotplug support
Date: Wed, 21 Nov 2018 16:17:05 +0000 [thread overview]
Message-ID: <20181121161704.GC24883@arm.com> (raw)
In-Reply-To: <20181121160814.u2vrkbtdxzsz5o4j@lakrids.cambridge.arm.com>
On Wed, Nov 21, 2018 at 04:08:14PM +0000, Mark Rutland wrote:
> On Wed, Nov 07, 2018 at 07:40:58PM +0000, Hoan Tran wrote:
> > From: Hoan Tran <Hoan@os.amperecomputing.com>
> >
> > This patch adds CPU hotplug support where the PMU migrates the context to
> > another online CPU when its CPU is offline.
> >
> > It fixes the below issue where the user does offline the CPU which is assigned
> > to this PMU.
> >
> > Assuming, CPU0 is assigned for this PMU. When the user does offline CPU0
> > [root@(none) ~]# echo 0 > /sys/devices/system/cpu/cpu0/online
> > This PMU does not work anymore and shows the below error.
> > [root@(none) ~]# perf stat -a -e l3c0/cycle-count/,l3c0/write/ sleep 1
> > Error:
> > The sys_perf_event_open() syscall returned with 19 (No such device) for event (l3c0/cycle-count/).
> > /bin/dmesg may provide additional information.
> > No CONFIG_PERF_EVENTS=y kernel support configured?
> >
> > With this patch, when CPU0 is offline, PMU migrates to another online CPU and
> > works on that CPU.
> >
> > Signed-off-by: Hoan Tran <hoan.tran@amperecomputing.com>
> > ---
> > v3:
> > * Remove email footer
> > * Fix the space issue
> >
> > v2:
> > * Remove the cpuhp instance when unregistering the PMU
>
> Aside from one minor fixup below, this looks good to me, and with that
> applied:
>
> Acked-by: Mark Rutland <mark.rutland@arm.com>
>
> Will, are you happy to apply that fixup when picking the patch?
Thanks, Mark. I'll queue this up and fix the naming of the enum entry.
Will
next prev parent reply other threads:[~2018-11-21 16:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 19:40 [PATCH v3] perf: xgene: Add CPU hotplug support Hoan Tran
2018-11-21 16:08 ` Mark Rutland
2018-11-21 16:17 ` Will Deacon [this message]
2018-11-21 16:52 ` Hoan Tran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181121161704.GC24883@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.