From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v2 05/13] drm/i915: Fix latency==0 handling for level 0 watermark on skl+ Date: Wed, 21 Nov 2018 21:09:41 +0200 Message-ID: <20181121190941.GM9144@intel.com> References: <20181114210729.16185-1-ville.syrjala@linux.intel.com> <20181114210729.16185-6-ville.syrjala@linux.intel.com> <20181119231434.GM32505@mdroper-desk.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id CF0086E600 for ; Wed, 21 Nov 2018 19:09:52 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20181119231434.GM32505@mdroper-desk.amr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Matt Roper Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBOb3YgMTksIDIwMTggYXQgMDM6MTQ6MzRQTSAtMDgwMCwgTWF0dCBSb3BlciB3cm90 ZToKPiBPbiBXZWQsIE5vdiAxNCwgMjAxOCBhdCAxMTowNzoyMVBNICswMjAwLCBWaWxsZSBTeXJq YWxhIHdyb3RlOgo+ID4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4 LmludGVsLmNvbT4KPiA+IAo+ID4gSWYgdGhlIGxldmVsIDAgbGF0ZW5jeSBpcyAwIHdlIGNhbid0 IGRvIGFueXRoaW5nLiBSZXR1cm4gYW4gZXJyb3IKPiA+IHJhdGhlciB0aGFuIHN1Y2Nlc3MuCj4g PiAKPiA+IFdoaWxlIHRoaXMgY2FuJ3QgaGFwcGVuIGR1ZSB0byBXYVdtTWVtb3J5UmVhZExhdGVu Y3ksIGl0IGNhbgo+ID4gaGFwcGVuIGlmIHRoZSB1c2VyIGNsZWFycyBvdXQgdGhlIGxldmVsIDAg bGF0ZW5jeSB2aWEgZGVidWdmcy4KPiA+IAo+ID4gdjI6IENsYXJpZnkgaG93IGhvdyB3ZSBjYW4g ZW5kIGhlcmUgd2l0aCB6ZXJvIGxldmVsIDAgbGF0ZW5jeSAoTWF0dCkKPiA+IAo+ID4gQ2M6IE1h dHQgUm9wZXIgPG1hdHRoZXcuZC5yb3BlckBpbnRlbC5jb20+Cj4gPiBSZXZpZXdlZC1ieTogUm9k cmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29tPgo+ID4gU2lnbmVkLW9mZi1ieTogVmls bGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiAKPiBJIHdvbmRl ciB3aGV0aGVyIHdlIHNob3VsZCByZWFsbHkgYmUgbGV0dGluZyB1c2VycyBzaG9vdCB0aGVtc2Vs dmVzIGluCj4gdGhlIGZvb3Qgd2l0aCBkZWJ1Z2ZzIGhlcmUuIE1heWJlIHdlIHNob3VsZCBwdWxs IHRoZSBzYW5pdGl6YXRpb24gYW5kCj4gaGFyZHdhcmUgd29ya2Fyb3VuZHMgb3V0IG9mIGludGVs X3JlYWRfd21fbGF0ZW5jeSgpIGFuZCBhbHNvIGFwcGx5IGl0IHRvCj4gd2hhdGV2ZXIgZGVidWdm cyBnaXZlcyB1cy4KCkkndmUgY29uc2lkZXJlZCB0aGF0LiBCdXQgT1RPSCBpdCdzIHJhdGhlciBu aWNlIHRvIGJlIGFibGUgdG8gb3ZlcnJpZGUKdGhlIHdvcmthcm91bmRzIGFuZCBqdXN0IHRlc3Qg ZXhhY3RseSB3aGF0IHlvdSB3YW50LiBBbmQgbm8gbm9ybWFsCnVzZXIgc2hvdWxkIGJlIHBva2lu ZyBhcm91bmQgaW4gZGVidWdmcyBhbnl3YXkuIEl0J3Mgb25seSBmb3IgZGVidWdnaW5nCmFuZCBh cyBzdWNoIGlzIGdlbmVyYWxseSB1bmRlcnN0b29kIHRvIGNvbnRhaW4gc29tZSBhbW91bnQgb2Yg ZHJhZ29ucy4KCj4gCj4gVGhpcyBpcyBnb29kIGVub3VnaCBmb3Igbm93IHRob3VnaC4KPiAKPiBS ZXZpZXdlZC1ieTogTWF0dCBSb3BlciA8bWF0dGhldy5kLnJvcGVyQGludGVsLmNvbT4KPiAKPiA+ IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMgfCA2ICsrKystLQo+ID4g IDEgZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4gPiAKPiA+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+ID4gaW5kZXggMjc0OThkZWQ0OTQ5Li4yNWY1ODljNGY2 OGMgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jCj4gPiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jCj4gPiBAQCAtNDcwNCw4ICs0NzA0 LDEwIEBAIHN0YXRpYyBpbnQgc2tsX2NvbXB1dGVfcGxhbmVfd20oY29uc3Qgc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ID4gIAlib29sIGFwcGx5X21lbW9yeV9id193YSA9IHNr bF9uZWVkc19tZW1vcnlfYndfd2Eoc3RhdGUpOwo+ID4gIAl1aW50MzJfdCBtaW5fZGlzcF9idWZf bmVlZGVkOwo+ID4gIAo+ID4gLQlpZiAobGF0ZW5jeSA9PSAwIHx8Cj4gPiAtCSAgICAhaW50ZWxf d21fcGxhbmVfdmlzaWJsZShjc3RhdGUsIGludGVsX3BzdGF0ZSkpIHsKPiA+ICsJaWYgKGxhdGVu Y3kgPT0gMCkKPiA+ICsJCXJldHVybiBsZXZlbCA9PSAwID8gLUVJTlZBTCA6IDA7Cj4gPiArCj4g PiArCWlmICghaW50ZWxfd21fcGxhbmVfdmlzaWJsZShjc3RhdGUsIGludGVsX3BzdGF0ZSkpIHsK PiA+ICAJCXJlc3VsdC0+cGxhbmVfZW4gPSBmYWxzZTsKPiA+ICAJCXJldHVybiAwOwo+ID4gIAl9 Cj4gPiAtLSAKPiA+IDIuMTguMQo+ID4gCj4gCj4gLS0gCj4gTWF0dCBSb3Blcgo+IEdyYXBoaWNz IFNvZnR3YXJlIEVuZ2luZWVyCj4gSW9URyBQbGF0Zm9ybSBFbmFibGluZyAmIERldmVsb3BtZW50 Cj4gSW50ZWwgQ29ycG9yYXRpb24KPiAoOTE2KSAzNTYtMjc5NQoKLS0gClZpbGxlIFN5cmrDpGzD pApJbnRlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK