From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v2 03/13] drm/i915: Introduce crtc_state->update_planes bitmask Date: Wed, 21 Nov 2018 21:10:55 +0200 Message-ID: <20181121191055.GN9144@intel.com> References: <20181114210729.16185-1-ville.syrjala@linux.intel.com> <20181114210729.16185-4-ville.syrjala@linux.intel.com> <20181119231414.GJ32505@mdroper-desk.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 349F66E5E1 for ; Wed, 21 Nov 2018 19:10:59 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20181119231414.GJ32505@mdroper-desk.amr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Matt Roper Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBOb3YgMTksIDIwMTggYXQgMDM6MTQ6MTRQTSAtMDgwMCwgTWF0dCBSb3BlciB3cm90 ZToKPiBPbiBXZWQsIE5vdiAxNCwgMjAxOCBhdCAxMTowNzoxOVBNICswMjAwLCBWaWxsZSBTeXJq YWxhIHdyb3RlOgo+ID4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4 LmludGVsLmNvbT4KPiA+IAo+ID4gS2VlcCB0cmFjayB3aGljaCBwbGFuZXMgbmVlZCB1cGRhdGlu ZyBkdXJpbmcgdGhlIGNvbW1pdC4gRm9yIG5vdyB0aGlzCj4gPiBpcyBqdXN0ICh3YXNfdmlzaWJs ZSB8fCBpc192aXNpYmxlKSBidXQgSSdsbCBoYXZlIG5lZWQgdG8gdXBkYXRlCj4gCj4gSSBzdGls bCB0aGluayBpdCB3b3VsZCBiZSBhIGdvb2QgaWRlYSB0byBtZW50aW9uIHdhc19zbGF2ZSB8fCBp c19zbGF2ZQo+IGhlcmUgZm9yIGNvbXBsZXRlbmVzcywgYnV0IGVpdGhlciB3YXksCgpBaCwgZGlk bid0IGV2ZW4gcmVhbGl6ZSBJIGRpZG4ndCBtZW50aW9uIGl0LiBJJ2xsIGFkZCBhIGZldyBjaG9p Y2UKd29yZHMuCgo+IAo+IFJldmlld2VkLWJ5OiBNYXR0IFJvcGVyIDxtYXR0aGV3LmQucm9wZXJA aW50ZWwuY29tPgo+IAo+ID4gaW52aXNpYmxlIHBsYW5lcyBsYXRlciBvbiBmb3Igc2tsIHBsYW5l IGRkYnMgYW5kIGZvciBwcmUtc2tsIHBpcGUKPiA+IGdhbW1hL2NzYyBjb250cm9sICh3aGljaCBs aXZlcyBpbiB0aGUgcHJpbWFyeSBwbGFuZSBjb250cm9sIHJlZ2lzdGVyKS4KPiA+IAo+ID4gUmV2 aWV3ZWQtYnk6IFJvZHJpZ28gVml2aSA8cm9kcmlnby52aXZpQGludGVsLmNvbT4KPiA+IFNpZ25l ZC1vZmYtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+ Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9hdG9taWMuYyAgICAgICB8 IDEgKwo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2F0b21pY19wbGFuZS5jIHwgOCAr KysrLS0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyAgICAgIHwg NSArKysrLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oICAgICAgICAgIHwg MyArKysKPiA+ICA0IGZpbGVzIGNoYW5nZWQsIDEyIGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25z KC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9hdG9t aWMuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2F0b21pYy5jCj4gPiBpbmRleCBhNWEy YzhmZTU4YTcuLjhjYjAyZjI4ZDMwYyAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2F0b21pYy5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9h dG9taWMuYwo+ID4gQEAgLTE4NCw2ICsxODQsNyBAQCBpbnRlbF9jcnRjX2R1cGxpY2F0ZV9zdGF0 ZShzdHJ1Y3QgZHJtX2NydGMgKmNydGMpCj4gPiAgCWNydGNfc3RhdGUtPmZpZm9fY2hhbmdlZCA9 IGZhbHNlOwo+ID4gIAljcnRjX3N0YXRlLT53bS5uZWVkX3Bvc3R2YmxfdXBkYXRlID0gZmFsc2U7 Cj4gPiAgCWNydGNfc3RhdGUtPmZiX2JpdHMgPSAwOwo+ID4gKwljcnRjX3N0YXRlLT51cGRhdGVf cGxhbmVzID0gMDsKPiA+ICAKPiA+ICAJcmV0dXJuICZjcnRjX3N0YXRlLT5iYXNlOwo+ID4gIH0K PiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9hdG9taWNfcGxhbmUu YyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2F0b21pY19wbGFuZS5jCj4gPiBpbmRleCA3 ZDM2ODUwNzUyMDEuLjAxMDI2OWExMjM5MCAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2F0b21pY19wbGFuZS5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9hdG9taWNfcGxhbmUuYwo+ID4gQEAgLTEzNyw2ICsxMzcsOSBAQCBpbnQgaW50ZWxf cGxhbmVfYXRvbWljX2NoZWNrX3dpdGhfc3RhdGUoY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3Rh dGUgKm9sZF9jcnRjXwo+ID4gIAlpZiAoc3RhdGUtPnZpc2libGUgJiYgc3RhdGUtPmZiLT5mb3Jt YXQtPmZvcm1hdCA9PSBEUk1fRk9STUFUX05WMTIpCj4gPiAgCQljcnRjX3N0YXRlLT5udjEyX3Bs YW5lcyB8PSBCSVQoaW50ZWxfcGxhbmUtPmlkKTsKPiA+ICAKPiA+ICsJaWYgKHN0YXRlLT52aXNp YmxlIHx8IG9sZF9wbGFuZV9zdGF0ZS0+YmFzZS52aXNpYmxlKQo+ID4gKwkJY3J0Y19zdGF0ZS0+ dXBkYXRlX3BsYW5lcyB8PSBCSVQoaW50ZWxfcGxhbmUtPmlkKTsKPiA+ICsKPiA+ICAJcmV0dXJu IGludGVsX3BsYW5lX2F0b21pY19jYWxjX2NoYW5nZXMob2xkX2NydGNfc3RhdGUsCj4gPiAgCQkJ CQkgICAgICAgJmNydGNfc3RhdGUtPmJhc2UsCj4gPiAgCQkJCQkgICAgICAgb2xkX3BsYW5lX3N0 YXRlLAo+ID4gQEAgLTE3MSwxNCArMTc0LDExIEBAIHZvaWQgaW50ZWxfdXBkYXRlX3BsYW5lc19v bl9jcnRjKHN0cnVjdCBpbnRlbF9hdG9taWNfc3RhdGUgKm9sZF9zdGF0ZSwKPiA+ICAJCQkJIHN0 cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpvbGRfY3J0Y19zdGF0ZSwKPiA+ICAJCQkJIHN0cnVjdCBp bnRlbF9jcnRjX3N0YXRlICpuZXdfY3J0Y19zdGF0ZSkKPiA+ICB7Cj4gPiArCXUzMiB1cGRhdGVf bWFzayA9IG5ld19jcnRjX3N0YXRlLT51cGRhdGVfcGxhbmVzOwo+ID4gIAlzdHJ1Y3QgaW50ZWxf cGxhbmVfc3RhdGUgKm5ld19wbGFuZV9zdGF0ZTsKPiA+ICAJc3RydWN0IGludGVsX3BsYW5lICpw bGFuZTsKPiA+IC0JdTMyIHVwZGF0ZV9tYXNrOwo+ID4gIAlpbnQgaTsKPiA+ICAKPiA+IC0JdXBk YXRlX21hc2sgPSBvbGRfY3J0Y19zdGF0ZS0+YWN0aXZlX3BsYW5lczsKPiA+IC0JdXBkYXRlX21h c2sgfD0gbmV3X2NydGNfc3RhdGUtPmFjdGl2ZV9wbGFuZXM7Cj4gPiAtCj4gPiAgCWZvcl9lYWNo X25ld19pbnRlbF9wbGFuZV9pbl9zdGF0ZShvbGRfc3RhdGUsIHBsYW5lLCBuZXdfcGxhbmVfc3Rh dGUsIGkpIHsKPiA+ICAJCWlmIChjcnRjLT5waXBlICE9IHBsYW5lLT5waXBlIHx8Cj4gPiAgCQkg ICAgISh1cGRhdGVfbWFzayAmIEJJVChwbGFuZS0+aWQpKSkKPiA+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kaXNwbGF5LmMKPiA+IGluZGV4IDNjNzYwYTJlYWNjOC4uMDY1YzhiZWZjNmY4IDEwMDY0 NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+IEBAIC0xMDgwOCw4ICsx MDgwOCwxMCBAQCBzdGF0aWMgaW50IGljbF9jaGVja19udjEyX3BsYW5lcyhzdHJ1Y3QgaW50ZWxf Y3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSkKPiA+ICAJCQljb250aW51ZTsKPiA+ICAKPiA+ICAJCXBs YW5lX3N0YXRlLT5saW5rZWRfcGxhbmUgPSBOVUxMOwo+ID4gLQkJaWYgKHBsYW5lX3N0YXRlLT5z bGF2ZSAmJiAhcGxhbmVfc3RhdGUtPmJhc2UudmlzaWJsZSkKPiA+ICsJCWlmIChwbGFuZV9zdGF0 ZS0+c2xhdmUgJiYgIXBsYW5lX3N0YXRlLT5iYXNlLnZpc2libGUpIHsKPiA+ICAJCQljcnRjX3N0 YXRlLT5hY3RpdmVfcGxhbmVzICY9IH5CSVQocGxhbmUtPmlkKTsKPiA+ICsJCQljcnRjX3N0YXRl LT51cGRhdGVfcGxhbmVzIHw9IEJJVChwbGFuZS0+aWQpOwo+ID4gKwkJfQo+ID4gIAo+ID4gIAkJ cGxhbmVfc3RhdGUtPnNsYXZlID0gZmFsc2U7Cj4gPiAgCX0KPiA+IEBAIC0xMDg1MCw2ICsxMDg1 Miw3IEBAIHN0YXRpYyBpbnQgaWNsX2NoZWNrX252MTJfcGxhbmVzKHN0cnVjdCBpbnRlbF9jcnRj X3N0YXRlICpjcnRjX3N0YXRlKQo+ID4gIAkJbGlua2VkX3N0YXRlLT5zbGF2ZSA9IHRydWU7Cj4g PiAgCQlsaW5rZWRfc3RhdGUtPmxpbmtlZF9wbGFuZSA9IHBsYW5lOwo+ID4gIAkJY3J0Y19zdGF0 ZS0+YWN0aXZlX3BsYW5lcyB8PSBCSVQobGlua2VkLT5pZCk7Cj4gPiArCQljcnRjX3N0YXRlLT51 cGRhdGVfcGxhbmVzIHw9IEJJVChsaW5rZWQtPmlkKTsKPiA+ICAJCURSTV9ERUJVR19LTVMoIlVz aW5nICVzIGFzIFkgcGxhbmUgZm9yICVzXG4iLCBsaW5rZWQtPmJhc2UubmFtZSwgcGxhbmUtPmJh c2UubmFtZSk7Cj4gPiAgCX0KPiA+ICAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gPiBp bmRleCAxOGI0MTlmN2Y3ZmUuLmIwYTI0YTgxNzgwYSAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kcnYuaAo+ID4gQEAgLTkyNSw2ICs5MjUsOSBAQCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0 ZSB7Cj4gPiAgCXU4IGFjdGl2ZV9wbGFuZXM7Cj4gPiAgCXU4IG52MTJfcGxhbmVzOwo+ID4gIAo+ ID4gKwkvKiBiaXRtYXNrIG9mIHBsYW5lcyB0aGF0IHdpbGwgYmUgdXBkYXRlZCBkdXJpbmcgdGhl IGNvbW1pdCAqLwo+ID4gKwl1OCB1cGRhdGVfcGxhbmVzOwo+ID4gKwo+ID4gIAkvKiBIRE1JIHNj cmFtYmxpbmcgc3RhdHVzICovCj4gPiAgCWJvb2wgaGRtaV9zY3JhbWJsaW5nOwo+ID4gIAo+ID4g LS0gCj4gPiAyLjE4LjEKPiA+IAo+ID4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KPiA+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiA+IEludGVsLWdmeEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKPiA+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cj4gCj4gLS0gCj4gTWF0dCBSb3Blcgo+IEdyYXBoaWNz IFNvZnR3YXJlIEVuZ2luZWVyCj4gSW9URyBQbGF0Zm9ybSBFbmFibGluZyAmIERldmVsb3BtZW50 Cj4gSW50ZWwgQ29ycG9yYXRpb24KPiAoOTE2KSAzNTYtMjc5NQoKLS0gClZpbGxlIFN5cmrDpGzD pApJbnRlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK