From: Michael Straube <straube.linux@gmail.com>
To: gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Michael Straube <straube.linux@gmail.com>
Subject: [PATCH 02/10] staging: rtl8188eu: cleanup comments in rtl8188eu_led.c
Date: Wed, 21 Nov 2018 20:49:29 +0100 [thread overview]
Message-ID: <20181121194937.1852-2-straube.linux@gmail.com> (raw)
In-Reply-To: <20181121194937.1852-1-straube.linux@gmail.com>
Remove comments in rtl8188eu_led.c. The function names are well
descriptive.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
drivers/staging/rtl8188eu/hal/rtl8188eu_led.c | 16 +---------------
1 file changed, 1 insertion(+), 15 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188eu_led.c b/drivers/staging/rtl8188eu/hal/rtl8188eu_led.c
index 411649a0b070..535ada474164 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188eu_led.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188eu_led.c
@@ -10,11 +10,6 @@
#include <rtl8188e_hal.h>
#include <usb_ops_linux.h>
-/* LED object. */
-
-/* LED_819xUsb routines. */
-/* Description: */
-/* Turn on LED according to LedPin specified. */
void SwLedOn(struct adapter *padapter, struct LED_871x *pLed)
{
u8 LedCfg;
@@ -22,12 +17,10 @@ void SwLedOn(struct adapter *padapter, struct LED_871x *pLed)
if (padapter->bSurpriseRemoved || padapter->bDriverStopped)
return;
LedCfg = usb_read8(padapter, REG_LEDCFG2);
- usb_write8(padapter, REG_LEDCFG2, (LedCfg&0xf0) | BIT(5) | BIT(6)); /* SW control led0 on. */
+ usb_write8(padapter, REG_LEDCFG2, (LedCfg&0xf0) | BIT(5) | BIT(6));
pLed->bLedOn = true;
}
-/* Description: */
-/* Turn off LED according to LedPin specified. */
void SwLedOff(struct adapter *padapter, struct LED_871x *pLed)
{
u8 LedCfg;
@@ -47,11 +40,6 @@ void SwLedOff(struct adapter *padapter, struct LED_871x *pLed)
pLed->bLedOn = false;
}
-/* Interface to manipulate LED objects. */
-/* Default LED behavior. */
-
-/* Description: */
-/* Initialize all LED_871x objects. */
void rtw_hal_sw_led_init(struct adapter *padapter)
{
struct led_priv *pledpriv = &padapter->ledpriv;
@@ -59,8 +47,6 @@ void rtw_hal_sw_led_init(struct adapter *padapter)
InitLed871x(padapter, &pledpriv->SwLed0);
}
-/* Description: */
-/* DeInitialize all LED_819xUsb objects. */
void rtw_hal_sw_led_deinit(struct adapter *padapter)
{
struct led_priv *ledpriv = &padapter->ledpriv;
--
2.19.1
next prev parent reply other threads:[~2018-11-21 19:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-21 19:49 [PATCH 01/10] staging: rtl8188eu: remove unnecessary parentheses in rtl8188eu_led.c Michael Straube
2018-11-21 19:49 ` Michael Straube [this message]
2018-11-21 19:49 ` [PATCH 03/10] staging: rtl8188eu: add spaces around '&' " Michael Straube
2018-11-21 19:49 ` [PATCH 04/10] staging: rtl8188eu: rename LedCfg to avoid CamelCase Michael Straube
2018-11-21 19:49 ` [PATCH 05/10] staging: rtl8188eu: rename SwLedOn " Michael Straube
2018-11-21 19:49 ` [PATCH 06/10] staging: rtl8188eu: rename SwLedOff " Michael Straube
2018-11-21 19:49 ` [PATCH 07/10] staging: rtl8188eu: rename BlinkHandler " Michael Straube
2018-11-21 19:49 ` [PATCH 08/10] staging: rtl8188eu: cleanup a function comment Michael Straube
2018-11-21 19:49 ` [PATCH 09/10] staging: rtl8188eu: rename LedControl8188eu to avoid CamelCase Michael Straube
2018-11-21 19:49 ` [PATCH 10/10] staging: rtl8188eu: rename SwLed0 " Michael Straube
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181121194937.1852-2-straube.linux@gmail.com \
--to=straube.linux@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.