From: Samuel Thibault <samuel.thibault@gnu.org>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: qemu-devel@nongnu.org, Zhang Chen <zhangckid@gmail.com>,
Li Zhijian <lizhijian@cn.fujitsu.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
Jason Wang <jasowang@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 for-3.2 v2 17/30] slirp: replace a DEBUG block with WITH_ICMP_ERROR_MSG
Date: Wed, 21 Nov 2018 23:31:24 +0100 [thread overview]
Message-ID: <20181121223124.nt6q3fdtk7ytnlg4@function> (raw)
In-Reply-To: <20181121220647.18844-18-marcandre.lureau@redhat.com>
Marc-André Lureau, le jeu. 22 nov. 2018 02:06:34 +0400, a ecrit:
> icmp_send_error() doesnt actually log messages when DEBUG is enabled.
> Let's use a different define that describes better the tweaked
> behaviour of the function, and avoid uncompiled code.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Applied to my tree, thanks!
next prev parent reply other threads:[~2018-11-21 22:32 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-21 22:06 [Qemu-devel] [PATCH v2 for-3.2 v2 00/30] slirp: make it again a standalone project Marc-André Lureau
2018-11-21 22:06 ` [Qemu-devel] [PATCH v2 for-3.2 v2 01/30] fixup! net: do not depend on slirp internals Marc-André Lureau
2018-11-21 22:10 ` Samuel Thibault
2018-11-22 7:14 ` Marc-André Lureau
2018-11-21 22:06 ` [Qemu-devel] [PATCH v2 for-3.2 v2 02/30] slirp: drop <Vista compatibility Marc-André Lureau
2018-11-21 22:15 ` Samuel Thibault
2018-11-22 10:22 ` Marc-André Lureau
2018-11-21 22:06 ` [Qemu-devel] [PATCH v2 for-3.2 v2 03/30] glib-compat: add g_spawn_async_with_fds() fallback Marc-André Lureau
2018-11-21 22:16 ` Samuel Thibault
2018-11-21 22:06 ` [Qemu-devel] [PATCH v2 for-3.2 v2 04/30] slirp: simplify fork_exec() Marc-André Lureau
2018-11-21 22:16 ` Samuel Thibault
2018-11-21 22:06 ` [Qemu-devel] [PATCH v2 for-3.2 v2 05/30] slirp: rename exec_list Marc-André Lureau
2018-11-21 22:18 ` Samuel Thibault
2018-11-21 22:06 ` [Qemu-devel] [PATCH v2 for-3.2 v2 06/30] slirp: factor out guestfwd addition checks Marc-André Lureau
2018-11-21 22:47 ` Samuel Thibault
2018-11-21 22:06 ` [Qemu-devel] [PATCH v2 for-3.2 v2 07/30] slirp: generalize guestfwd with a callback based approach Marc-André Lureau
2018-11-21 22:06 ` [Qemu-devel] [PATCH v2 for-3.2 v2 08/30] net/slirp: simplify checking for cmd: prefix Marc-André Lureau
2018-11-21 22:06 ` [Qemu-devel] [PATCH v2 for-3.2 v2 09/30] net/slirp: fix a few memory leaks Marc-André Lureau
2018-11-21 22:06 ` [Qemu-devel] [PATCH v2 for-3.2 v2 10/30] slirp: use virtual time for packet expiration Marc-André Lureau
2018-11-21 22:23 ` Samuel Thibault
2018-11-21 22:06 ` [Qemu-devel] [PATCH v2 for-3.2 v2 11/30] slirp: add clock_get_ns() callback Marc-André Lureau
2018-11-21 22:49 ` Samuel Thibault
2018-11-21 22:06 ` [Qemu-devel] [PATCH v2 for-3.2 v2 12/30] slirp: add callbacks for timer Marc-André Lureau
2018-11-21 22:06 ` [Qemu-devel] [PATCH v2 for-3.2 v2 13/30] build-sys: use a seperate slirp-obj-y && slirp.mo Marc-André Lureau
2018-11-21 22:53 ` Samuel Thibault
2018-11-21 22:06 ` [Qemu-devel] [PATCH v2 for-3.2 v2 14/30] slirp: set G_LOG_DOMAIN Marc-André Lureau
2018-11-21 22:54 ` Samuel Thibault
2018-11-21 22:06 ` [Qemu-devel] [PATCH v2 for-3.2 v2 15/30] slirp: replace error_report() and a fprintf with g_critical() Marc-André Lureau
2018-11-21 22:28 ` Samuel Thibault
2018-11-21 22:06 ` [Qemu-devel] [PATCH v2 for-3.2 v2 16/30] slirp: replace some fprintf() with DEBUG_MISC Marc-André Lureau
2018-11-21 22:29 ` Samuel Thibault
2018-11-21 22:06 ` [Qemu-devel] [PATCH v2 for-3.2 v2 17/30] slirp: replace a DEBUG block with WITH_ICMP_ERROR_MSG Marc-André Lureau
2018-11-21 22:31 ` Samuel Thibault [this message]
2018-11-21 22:06 ` [Qemu-devel] [PATCH v2 for-3.2 v2 18/30] slirp: no need to make DPRINTF conditional on DEBUG Marc-André Lureau
2018-11-21 22:32 ` Samuel Thibault
2018-11-21 22:06 ` [Qemu-devel] [PATCH v2 for-3.2 v2 19/30] slirp: always build with debug statements Marc-André Lureau
2018-11-21 22:35 ` Samuel Thibault
2018-11-21 22:06 ` [Qemu-devel] [PATCH v2 for-3.2 v2 20/30] slirp: introduce SLIRP_DEBUG environment variable Marc-André Lureau
2018-11-21 22:36 ` Samuel Thibault
2018-11-21 22:06 ` [Qemu-devel] [PATCH v2 for-3.2 v2 21/30] slirp: use %p for pointers format Marc-André Lureau
2018-11-21 22:37 ` Samuel Thibault
2018-11-21 22:06 ` [Qemu-devel] [PATCH v2 for-3.2 v2 22/30] slirp: remove remaining DEBUG blocks Marc-André Lureau
2018-11-21 22:38 ` Samuel Thibault
2018-11-21 22:06 ` [Qemu-devel] [PATCH v2 for-3.2 v2 23/30] slirp: replace DEBUG_ARGS with DEBUG_ARG Marc-André Lureau
2018-11-21 22:43 ` Samuel Thibault
2018-11-21 22:06 ` [Qemu-devel] [PATCH v2 for-3.2 v2 24/30] slirp: call into g_debug() for DEBUG macros Marc-André Lureau
2018-11-21 22:58 ` Samuel Thibault
2018-11-21 22:06 ` [Qemu-devel] [PATCH v2 for-3.2 v2 25/30] slirp: replace trace functions with DEBUG calls Marc-André Lureau
2018-11-21 23:00 ` Samuel Thibault
2018-11-22 7:45 ` Gerd Hoffmann
2018-11-21 22:06 ` [Qemu-devel] [PATCH v2 for-3.2 v2 26/30] slirp: add a set_nonblock() callback Marc-André Lureau
2018-11-21 22:06 ` [Qemu-devel] [PATCH v2 for-3.2 v2 27/30] slirp: replace qemu_notify_event() with a callback Marc-André Lureau
2018-11-21 22:06 ` [Qemu-devel] [PATCH v2 for-3.2 v2 28/30] slirp: move QEMU state saving to a separate unit Marc-André Lureau
2018-11-21 22:06 ` [Qemu-devel] [PATCH v2 for-3.2 v2 29/30] slirp: replace remaining QEMU dependency Marc-André Lureau
2018-12-06 12:03 ` Marc-André Lureau
2018-11-21 22:06 ` [Qemu-devel] [PATCH v2 for-3.2 v2 30/30] build-sys: add a basic meson build Marc-André Lureau
2018-11-22 9:21 ` [Qemu-devel] [PATCH v2 for-3.2 v2 00/30] slirp: make it again a standalone project Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181121223124.nt6q3fdtk7ytnlg4@function \
--to=samuel.thibault@gnu.org \
--cc=jan.kiszka@siemens.com \
--cc=jasowang@redhat.com \
--cc=lizhijian@cn.fujitsu.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zhangckid@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.