From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Evan Green <evgreen@chromium.org>
Cc: Rob Herring <robh@kernel.org>, Andy Gross <andy.gross@linaro.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
Douglas Anderson <dianders@chromium.org>,
Stephen Boyd <swboyd@chromium.org>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
David Brown <david.brown@linaro.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-soc@vger.kernel.org
Subject: Re: [PATCH v5 5/5] arm64: dts: qcom: sdm845: Add USB PHY lane two
Date: Wed, 21 Nov 2018 23:07:51 -0800 [thread overview]
Message-ID: <20181122070751.GK2225@minitux> (raw)
In-Reply-To: <20181026173544.136037-6-evgreen@chromium.org>
On Fri 26 Oct 10:35 PDT 2018, Evan Green wrote:
> Add the second lane registers for the USB PHY, now that the
> QMP phy bindings have been updated. This way the driver can stop
> reaching beyond its register region to get at the second lane.
>
> Signed-off-by: Evan Green <evgreen@chromium.org>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
>
> Changes in v5: None
> Changes in v4: None
> Changes in v3:
> - Removed erroneous fixup for USB UniPro PHY, which is not dual lane (Doug)
>
> Changes in v2: None
>
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index 9c72edb678ec..ff2db36ec4fa 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -1188,10 +1188,12 @@
> <&gcc GCC_USB3_PHY_PRIM_BCR>;
> reset-names = "phy", "common";
>
> - usb_1_ssphy: lane@88e9200 {
> + usb_1_ssphy: lanes@88e9200 {
> reg = <0x88e9200 0x128>,
> <0x88e9400 0x200>,
> <0x88e9c00 0x218>,
> + <0x88e9600 0x128>,
> + <0x88e9800 0x200>,
> <0x88e9a00 0x100>;
> #phy-cells = <0>;
> clocks = <&gcc GCC_USB3_PRIM_PHY_PIPE_CLK>;
> --
> 2.16.4
>
prev parent reply other threads:[~2018-11-22 7:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-26 17:35 [PATCH v5 0/5] arm64: dts: qcom: sdm845: Add UFS DT nodes Evan Green
2018-10-26 17:35 ` [PATCH v5 1/5] dt-bindings: phy-qcom-qmp: Fix register underspecification Evan Green
2018-11-04 2:40 ` Stephen Boyd
2018-11-04 2:40 ` Stephen Boyd
2018-11-05 16:52 ` Doug Anderson
2018-11-10 0:53 ` Stephen Boyd
2018-10-26 17:35 ` [PATCH v5 2/5] phy: qcom-qmp: Utilize fully-specified DT registers Evan Green
2018-10-26 17:35 ` [PATCH v5 3/5] arm64: dts: qcom: sdm845: add UFS controller Evan Green
2018-11-22 7:18 ` Bjorn Andersson
2018-11-28 23:43 ` Evan Green
2018-10-26 17:35 ` [PATCH v5 4/5] arm64: dts: qcom: sdm845: Add UFS nodes for sdm845-mtp Evan Green
2018-11-19 19:19 ` Stephen Boyd
2018-11-19 19:19 ` Stephen Boyd
2018-11-19 19:25 ` Doug Anderson
2018-11-19 19:42 ` Stephen Boyd
2018-11-22 7:04 ` Bjorn Andersson
2018-11-28 2:31 ` Stephen Boyd
2018-10-26 17:35 ` [PATCH v5 5/5] arm64: dts: qcom: sdm845: Add USB PHY lane two Evan Green
2018-11-22 7:07 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181122070751.GK2225@minitux \
--to=bjorn.andersson@linaro.org \
--cc=andy.gross@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=evgreen@chromium.org \
--cc=kishon@ti.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.