From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1gPjNh-00083P-2b for mharc-grub-devel@gnu.org; Thu, 22 Nov 2018 02:26:33 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55559) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gPjNe-0007uY-Nx for grub-devel@gnu.org; Thu, 22 Nov 2018 02:26:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gPjNa-0008Kd-NA for grub-devel@gnu.org; Thu, 22 Nov 2018 02:26:30 -0500 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]:34249) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gPjNW-0008BP-Qk for grub-devel@gnu.org; Thu, 22 Nov 2018 02:26:24 -0500 Received: by mail-wm1-x341.google.com with SMTP id y185so4838886wmd.1 for ; Wed, 21 Nov 2018 23:26:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=NjsJNJf/huItfdXnR5tJi9wEG3R4ckqXvwBAAfbREDA=; b=AnKeZSS22KevTPbT0oLLOKeSMyF2pzhHhJtlGjDXii8Yagvtasixbt99k5UxkLBpaw yPXoF2mc9MYWOfp799PuKA/9q0UHbMvaltgr9X9SPCBG7jGDRcdxtEpj1le8uzQBPPNr ct0B/ZBp7H9yRnvB6HX71Pv1xljMjJkitk/Rs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=NjsJNJf/huItfdXnR5tJi9wEG3R4ckqXvwBAAfbREDA=; b=Dtxs30ef8PIL8S6aWxkxqbWJcsHw8z066cdHDp8S7K1c7DQvYKwdyav3VBaEEPsko3 y31wTi3rhqDWO7qDktVHmF8Z05177MDqJK0EDIFyH+3lY+vpgLZqH1Lh8kW7belXrh2H rc29vivIQnK2IShNjwQu/SXIXVIZ6sHLCOFMKdR7cODDvvqsWqjBvgzwe7NN9YOOavcV LF5D0mivMR23ivUdnD0JXE/VkD+Gcde9YE7FbY4vifaa+1vN87tbvAnzrLdVPnP4IksX dzlCDzHvlGwQIWA8gwL37HujBEgFrw4+YAet6Yvc7oKFzuQGK3CdUJcIbMaST4gTJYhg LXCg== X-Gm-Message-State: AGRZ1gK+rwJPEw/JL5n8FX0UJWRCi7KHNECyRjYYp/TLlvxxpbVrfwfC jK2tIRcGLwVt6NmLXad/xYO5IQ== X-Google-Smtp-Source: AFSGD/VJjAwIjtSbfJD0qqFLMWbNFPXZXt5AKVvRsQrDrXjAZ2xwDpaE6qwBMmK2EAPHft009qGOpg== X-Received: by 2002:a7b:cd97:: with SMTP id y23mr8053498wmj.129.1542871574016; Wed, 21 Nov 2018 23:26:14 -0800 (PST) Received: from dell ([2.27.35.241]) by smtp.gmail.com with ESMTPSA id j33sm16732146wre.91.2018.11.21.23.26.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 21 Nov 2018 23:26:13 -0800 (PST) Date: Thu, 22 Nov 2018 07:26:11 +0000 From: Lee Jones To: Daniel Kiper Cc: Fu Wei Fu , Leif Lindholm , The development of GNU GRUB , Julien Grall Subject: Re: arm64/xen: Fix too few =?utf-8?Q?argum?= =?utf-8?Q?ents_to_function_=E2=80=98grub=5Fcreate=5Floader=5Fcmdline?= =?utf-8?B?4oCZ?= Message-ID: <20181122072611.GE4541@dell> References: <20181114192919.24655-1-leif.lindholm@linaro.org> <20181116140737.wuox7v63y6lt2ymt@tomti.i.net-space.pl> <20181120104504.GM3513@dell> <20181121141234.yr7jkki3wngy4r5a@tomti.i.net-space.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20181121141234.yr7jkki3wngy4r5a@tomti.i.net-space.pl> User-Agent: Mutt/1.9.4 (2018-02-28) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::341 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Nov 2018 07:26:31 -0000 On Wed, 21 Nov 2018, Daniel Kiper wrote: > On Tue, Nov 20, 2018 at 10:45:04AM +0000, Lee Jones wrote: > > From: Lee Jones > > > > arm64/xen: Fix too few arguments to function ‘grub_create_loader_cmdline’ > > > > Without this fix, building xen_boot.c omits: > > > > loader/arm64/xen_boot.c: In function ‘xen_boot_binary_load’: > > loader/arm64/xen_boot.c:370:7: error: too few arguments to function ‘grub_create_loader_cmdline’ > > grub_create_loader_cmdline (argc - 1, argv + 1, binary->cmdline, > > ^~~~~~~~~~~~~~~~~~~~~~~~~~ > > In file included from loader/arm64/xen_boot.c:36:0: > > ../include/grub/lib/cmdline.h:29:12: note: declared here > > grub_err_t grub_create_loader_cmdline (int argc, char *argv[], char *buf, > > > > Signed-off-by: Lee Jones > > Pushed despite it had malformed tabs. Next time please use "git format-patch" > and "git send-email" to build and send the patches. I normally do this (for my kernel work), but Leif asked me to reply directly to this mail (since I am not set-up for Grub). If I continue to contribute, I'll set something up more enduring. Thank you for your help. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog