From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gPmx0-00015g-TC for kexec@lists.infradead.org; Thu, 22 Nov 2018 11:15:18 +0000 Received: by mail-wm1-x343.google.com with SMTP id r11-v6so8535112wmb.2 for ; Thu, 22 Nov 2018 03:15:04 -0800 (PST) Date: Thu, 22 Nov 2018 12:14:58 +0100 From: Ingo Molnar Subject: Re: [PATCH] x86: fix -Wmissing-prototypes warning Message-ID: <20181122111458.GA107823@gmail.com> References: <20181122084815.GA84118@gmail.com> <201811221904598072830@zte.com.cn> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <201811221904598072830@zte.com.cn> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: wang.yi59@zte.com.cn Cc: linux-efi@vger.kernel.org, anton@enomsg.org, kvm@vger.kernel.org, rkrcmar@redhat.com, peterz@infradead.org, jan.kiszka@siemens.com, virtualization@lists.linux-foundation.org, pravin.shedge4linux@gmail.com, namit@vmware.com, hpa@zytor.com, frowand.list@gmail.com, akataria@vmware.com, prarit@redhat.com, robh@kernel.org, zhong.weidong@zte.com.cn, bhe@redhat.com, devicetree@vger.kernel.org, x86@kernel.org, pasha.tatashin@oracle.com, takahiro.akashi@linaro.org, andy.shevchenko@gmail.com, mingo@redhat.com, linux-pci@vger.kernel.org, dyoung@redhat.com, m.mizuma@jp.fujitsu.com, jailhouse-dev@googlegroups.com, jroedel@suse.de, keescook@chromium.org, konrad.wilk@oracle.com, rostedt@goodmis.org, rajvi.jingar@intel.com, tony.luck@intel.com, bp@alien8.de, luto@kernel.org, oleg@redhat.com, bhelgaas@google.com, tglx@linutronix.de, frank.rowand@sony.com, jgross@suse.com, douly.fnst@cn.fujitsu.com, thomas.lendacky@amd.com, zhe.he@windriver.com, ard.biesheuvel@linaro.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, ebiederm@xmission.com, ccross@android.com, pbonzini@redhat.com, akpm@linux-foundation.org, up2wing@gmail.com, dwmw@amazon.co.uk, ivan.gorinov@intel.com Ciogd2FuZy55aTU5QHp0ZS5jb20uY24gPHdhbmcueWk1OUB6dGUuY29tLmNuPiB3cm90ZToKCj4g SGkgSW5nbywKPiAKPiA+ICogWWkgV2FuZyA8d2FuZy55aTU5QHp0ZS5jb20uY24+IHdyb3RlOgo+ ID4KPiA+ID4gV2UgbWF5IGdldCAtV21pc3NpbmctcHJvdG90eXBlcyB3YXJuaW5ncyB3aGVuIGJ1 aWxkaW5nCj4gPiA+IGtlcm5lbCB3aXRoIFc9MSwgaXQncyBiZXR0ZXIgdG8gZml4IHRoZW0gYXMg Z2xvYmFsIGZ1bmN0aW9uCj4gPiA+IHNpZ25hdHVyZSBjYW4gYmUgY2hhbmdlZCBhbmQgY2FsbGVy IHdobyB1c2UgdGhlIG9sZCB1bmNoYW5nZWQKPiA+ID4gcHJvdG90eXBlcyB3aWxsIGJlIGhvc2Vk Lgo+ID4gPgo+ID4gPiBUaGlzIHBhdGNoIGZpeGVzIG1vc3Qgb2YgLVdtaXNzaW5nLXByb3RvdHlw ZXMgd2FybmluZ3Mgd2hpY2gKPiA+ID4gYXJlIGluIHRoZSByb290IGRpcmVjdG9yeSBvZiBhcmNo L3g4Ni9rZXJuZWwsIG5vdCBpbmNsdWRpbmcKPiA+ID4gdGhlIHN1YmRpcmVjdG9yaWVzLgo+ID4g Pgo+ID4gPiBUaGVzZSBhcmUgdGhlIHdhcm5pbmdzIGZpeGVkIGluIHRoaXMgcGF0Y2g6Cj4gPiA+ IGFyY2gveDg2L2tlcm5lbC9zaWduYWwuYzo4NjU6MTc6IHdhcm5pbmc6IG5vIHByZXZpb3VzIHBy b3RvdHlwZSBmb3Ig4oCYc3lzMzJfeDMyX3J0X3NpZ3JldHVybuKAmSBbLVdtaXNzaW5nLXByb3Rv dHlwZXNdCj4gCj4gLi4uLi4uCj4gCj4gPiA+ICBpbmNsdWRlL2xpbnV4L2Z0cmFjZS5oICAgICAg ICAgICAgIHwgMyArKysKPiA+ID4gIGluY2x1ZGUvbGludXgva2V4ZWMuaCAgICAgICAgICAgICAg fCAxICsKPiA+ID4gIGluY2x1ZGUvbGludXgvb2ZfZmR0LmggICAgICAgICAgICAgfCAxICsKPiA+ ID4gIGluY2x1ZGUvbGludXgvcHRyYWNlLmggICAgICAgICAgICAgfCAxICsKPiA+ID4gIDI0IGZp bGVzIGNoYW5nZWQsIDU1IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCj4gPgo+ID4gQnJl YWtzIDMyLWJpdCBjb21waWxhdGlvbjoKPiA+Cj4gPiAuLi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9z ZXR1cC5oOiBBc3NlbWJsZXIgbWVzc2FnZXM6Cj4gPiAuLi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9z ZXR1cC5oOjMwOiBFcnJvcjogbm8gc3VjaCBpbnN0cnVjdGlvbjogYHVuc2lnbmVkIGxvbmcgX19z dGFydHVwXzY0KHVuc2lnbmVkIGxvbmcgcGh5c2FkZHIsc3RydWN0IGJvb3RfcGFyYW1zICpicCkn Cj4gPgo+ID4gSSdsbCBza2lwIHRoZSBzZXR1cC5oIGJpdHMgLSBsZXQncyBob3BlIHRoYXQncyB0 aGUgb25seSBidWcuCj4gCj4gU29ycnkgZm9yIHRoZSBpbmNvbnZlbmllbmNlLCB0aG91Z2ggSSBo YXZlIGNoZWNrZWQgY2FyZWZ1bGx5IDotKQo+IAo+IEhvdyBkbyB5b3UgcHJvZHVjZSB0aGlzIGVy cm9yPyBJIHRlc3RlZCB0aGlzIHdheSBidXQgZGlkIG5vdCByZXByb2R1Y2UKPiB0aGF0IGVycm9y Ogo+ICMgbWFrZSBhbGxtb2Rjb25maWcKPiAjIG1ha2UgLWo4Cj4gCj4gVGhhbmtzIGZvciB5b3Vy IHRpbWUgYWdhaW4hCgpJIGRvbid0IHJlbWVtYmVyIHRoZSBleGFjdCBjb25maWcsIGJ1dCB5b3Ug Y291bGQgdHJ5IHRoZSAzMi1iaXQgCmFsbG5vY29uZmlnIGFuZCBkZWZjb25maWcuCgpOb3RlIHRo YXQgdGhlIGNvbW1hbmRzIHlvdSB1c2VkIGFib3ZlIHdpbGwgdXNlIHRoZSA2NC1iaXQga2VybmVs LCBub3QgdGhlIAozMi1iaXQga2VybmVsLgoKVGhhbmtzLAoKCUluZ28KCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmtleGVjIG1haWxpbmcgbGlzdAprZXhl Y0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4v bGlzdGluZm8va2V4ZWMK From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCH] x86: fix -Wmissing-prototypes warning Date: Thu, 22 Nov 2018 12:14:58 +0100 Message-ID: <20181122111458.GA107823@gmail.com> References: <20181122084815.GA84118@gmail.com> <201811221904598072830@zte.com.cn> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Return-path: Sender: Ingo Molnar Content-Disposition: inline In-Reply-To: <201811221904598072830@zte.com.cn> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: wang.yi59@zte.com.cn Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, x86@kernel.org, linux-kernel@vger.kernel.org, ard.biesheuvel@linaro.org, linux-efi@vger.kernel.org, pbonzini@redhat.com, rkrcmar@redhat.com, kvm@vger.kernel.org, jgross@suse.com, akataria@vmware.com, virtualization@lists.linux-foundation.org, m.mizuma@jp.fujitsu.com, peterz@infradead.org, prarit@redhat.com, douly.fnst@cn.fujitsu.com, dwmw@amazon.co.uk, luto@kernel.org, pasha.tatashin@oracle.com, rajvi.jingar@intel.com, zhe.he@windriver.com, akpm@linux-foundation.org, dyoung@redhat.com, takahiro.akashi@linaro.org, ebiederm@xmission.com, bhe@redhat.com, ivan.gorinov@intel.com, robh@kernel.org, andy.shevchenko@gmail.com, frank.rowand@sony.com, jan.kiszka@siemens.com, jailhouse-dev@googlegroups.com, konrad.wilk@oracle.com, thomas.lendacky@amd.com, pravin.shedge4linux@gmail.com, namit@vmware.com, jroedel@sus List-Id: linux-efi@vger.kernel.org * wang.yi59@zte.com.cn wrote: > Hi Ingo, >=20 > > * Yi Wang wrote: > > > > > We may get -Wmissing-prototypes warnings when building > > > kernel with W=3D1, it's better to fix them as global function > > > signature can be changed and caller who use the old unchanged > > > prototypes will be hosed. > > > > > > This patch fixes most of -Wmissing-prototypes warnings which > > > are in the root directory of arch/x86/kernel, not including > > > the subdirectories. > > > > > > These are the warnings fixed in this patch: > > > arch/x86/kernel/signal.c:865:17: warning: no previous prototype for = =E2=80=98sys32_x32_rt_sigreturn=E2=80=99 [-Wmissing-prototypes] >=20 > ...... >=20 > > > include/linux/ftrace.h | 3 +++ > > > include/linux/kexec.h | 1 + > > > include/linux/of_fdt.h | 1 + > > > include/linux/ptrace.h | 1 + > > > 24 files changed, 55 insertions(+), 3 deletions(-) > > > > Breaks 32-bit compilation: > > > > ../arch/x86/include/asm/setup.h: Assembler messages: > > ../arch/x86/include/asm/setup.h:30: Error: no such instruction: `unsign= ed long __startup_64(unsigned long physaddr,struct boot_params *bp)' > > > > I'll skip the setup.h bits - let's hope that's the only bug. >=20 > Sorry for the inconvenience, though I have checked carefully :-) >=20 > How do you produce this error? I tested this way but did not reproduce > that error: > # make allmodconfig > # make -j8 >=20 > Thanks for your time again! I don't remember the exact config, but you could try the 32-bit=20 allnoconfig and defconfig. Note that the commands you used above will use the 64-bit kernel, not the= =20 32-bit kernel. Thanks, Ingo --=20 You received this message because you are subscribed to the Google Groups "= Jailhouse" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to jailhouse-dev+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: * X-Spam-Status: No, score=1.7 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, FSL_HELO_FAKE,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3156BC43441 for ; Thu, 22 Nov 2018 11:15:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E497D2081C for ; Thu, 22 Nov 2018 11:15:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZEU/BCJ9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E497D2081C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-pci-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394639AbeKVVyB (ORCPT ); Thu, 22 Nov 2018 16:54:01 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:52256 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726862AbeKVVyA (ORCPT ); Thu, 22 Nov 2018 16:54:00 -0500 Received: by mail-wm1-f66.google.com with SMTP id r11-v6so8535107wmb.2; Thu, 22 Nov 2018 03:15:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=dRiYMIUednuIfQfeppP8giB2MXTsNS8bx6NiRVsNR6M=; b=ZEU/BCJ9GcItUr/ENvduuRnJtH4SVnseFdpWMKTukpThLozU3z11pVjbIm9/o1vbke k8iFVgqMx25OX/LmP/DAe8/srjIDPqsswXFzy3a5aF1zjlE+2MKcniSHmnh9v8Oyw7ND VmVwebhy4QLolpbeUPVltauitdJYC0oztTpgWPG0t5qvaa7e8ZiqrjBs0GBUpfcPghU/ cePhbcyZymqCMSUEqnSV3zqrQtriVYjavgmSEu3AXZcAksDnZn+l9SznyU12KJRAaip4 mbR2f66UxzKdLAgYnqg1TMMcZAVZ6fHp6967Zt8WQDETeaDwiz01J9hiEDKcIIByAh/d SF3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=dRiYMIUednuIfQfeppP8giB2MXTsNS8bx6NiRVsNR6M=; b=YSdgDZvfDnqxMSpBmC+5XPnACaU0XNY/M2IA3nlir91V1XJfZp1Me+WhxTyPj6s50e NmdOzqzzBu46NxOKK29mULrWODaaGwnUb0+7pyDenbNvC20d56rNY+I9m/Yi0GERQgkR gqrlgAK7GcRz7beM3mKas0Jb0KoYRHVr+Lw39EsmyzmbdVay8iB5QPa2n8v3gYNoxY8i D4kddslaEtpw5iYVs6BvuQRlWgolsZV/pDdEglzbWESW7vOMU+OhbAFt1iPBwIHY9VxW c57bp4/OgCihFakVQxUjpaMk9wV44/WwHFik1G7siolWc4/WmQt/6bwmoEmzo4YH2Pm9 6eGQ== X-Gm-Message-State: AGRZ1gIEz/m+XIOafilV7VhdZi/TjmMgCHUIH1PH4CEwBBaOdaQj1YuU aQyF0ThSHRXhMyJq8nZVClkjpWgH X-Google-Smtp-Source: AFSGD/VNhlgzKaj5S6HXSrYoZacDu5lipCtOPhlQMW9IJ5+O78dCGKK8rsokvlJvJ9GpGGKahDmlxg== X-Received: by 2002:a1c:702:: with SMTP id 2-v6mr9355747wmh.113.1542885303023; Thu, 22 Nov 2018 03:15:03 -0800 (PST) Received: from gmail.com (2E8B0CD5.catv.pool.telekom.hu. [46.139.12.213]) by smtp.gmail.com with ESMTPSA id n15sm20926974wrt.21.2018.11.22.03.15.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 22 Nov 2018 03:15:02 -0800 (PST) Date: Thu, 22 Nov 2018 12:14:58 +0100 From: Ingo Molnar To: wang.yi59@zte.com.cn Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, x86@kernel.org, linux-kernel@vger.kernel.org, ard.biesheuvel@linaro.org, linux-efi@vger.kernel.org, pbonzini@redhat.com, rkrcmar@redhat.com, kvm@vger.kernel.org, jgross@suse.com, akataria@vmware.com, virtualization@lists.linux-foundation.org, m.mizuma@jp.fujitsu.com, peterz@infradead.org, prarit@redhat.com, douly.fnst@cn.fujitsu.com, dwmw@amazon.co.uk, luto@kernel.org, pasha.tatashin@oracle.com, rajvi.jingar@intel.com, zhe.he@windriver.com, akpm@linux-foundation.org, dyoung@redhat.com, takahiro.akashi@linaro.org, ebiederm@xmission.com, bhe@redhat.com, ivan.gorinov@intel.com, robh@kernel.org, andy.shevchenko@gmail.com, frank.rowand@sony.com, jan.kiszka@siemens.com, jailhouse-dev@googlegroups.com, konrad.wilk@oracle.com, thomas.lendacky@amd.com, pravin.shedge4linux@gmail.com, namit@vmware.com, jroedel@suse.de, bhelgaas@google.com, linux-pci@vger.kernel.org, keescook@chromium.org, anton@enomsg.org, ccross@android.com, tony.luck@intel.com, rostedt@goodmis.org, kexec@lists.infradead.org, robh+dt@kernel.org, frowand.list@gmail.com, devicetree@vger.kernel.org, oleg@redhat.com, zhong.weidong@zte.com.cn, up2wing@gmail.com Subject: Re: [PATCH] x86: fix -Wmissing-prototypes warning Message-ID: <20181122111458.GA107823@gmail.com> References: <20181122084815.GA84118@gmail.com> <201811221904598072830@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <201811221904598072830@zte.com.cn> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org * wang.yi59@zte.com.cn wrote: > Hi Ingo, > > > * Yi Wang wrote: > > > > > We may get -Wmissing-prototypes warnings when building > > > kernel with W=1, it's better to fix them as global function > > > signature can be changed and caller who use the old unchanged > > > prototypes will be hosed. > > > > > > This patch fixes most of -Wmissing-prototypes warnings which > > > are in the root directory of arch/x86/kernel, not including > > > the subdirectories. > > > > > > These are the warnings fixed in this patch: > > > arch/x86/kernel/signal.c:865:17: warning: no previous prototype for ‘sys32_x32_rt_sigreturn’ [-Wmissing-prototypes] > > ...... > > > > include/linux/ftrace.h | 3 +++ > > > include/linux/kexec.h | 1 + > > > include/linux/of_fdt.h | 1 + > > > include/linux/ptrace.h | 1 + > > > 24 files changed, 55 insertions(+), 3 deletions(-) > > > > Breaks 32-bit compilation: > > > > ../arch/x86/include/asm/setup.h: Assembler messages: > > ../arch/x86/include/asm/setup.h:30: Error: no such instruction: `unsigned long __startup_64(unsigned long physaddr,struct boot_params *bp)' > > > > I'll skip the setup.h bits - let's hope that's the only bug. > > Sorry for the inconvenience, though I have checked carefully :-) > > How do you produce this error? I tested this way but did not reproduce > that error: > # make allmodconfig > # make -j8 > > Thanks for your time again! I don't remember the exact config, but you could try the 32-bit allnoconfig and defconfig. Note that the commands you used above will use the 64-bit kernel, not the 32-bit kernel. Thanks, Ingo