From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
Wei Liu <wei.liu2@citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] x86/mwait-idle: Graceful probe failure when MWAIT is disabled
Date: Thu, 22 Nov 2018 13:09:49 +0100 [thread overview]
Message-ID: <20181122120949.jsx3ceeqynteejml@mac> (raw)
In-Reply-To: <5BF67DAB02000078001FEC32@prv1-mh.provo.novell.com>
On Thu, Nov 22, 2018 at 02:58:03AM -0700, Jan Beulich wrote:
> When MWAIT is disabled, intel_idle refuses to probe.
> But it may mis-lead the user by blaming this on the model number:
>
> intel_idle: does not run on family 6 modesl 79
>
> So defer the check for MWAIT until after the model# white-list check succeeds,
> and if the MWAIT check fails, tell the user how to fix it:
>
> intel_idle: Please enable MWAIT in BIOS SETUP
>
> Signed-off-by: Len Brown <len.brown@intel.com>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> [Linux commit: a4c447533a18ee86e07232d6344ba12b1f9c5077]
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
Thanks.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-11-22 12:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-22 9:58 [PATCH] x86/mwait-idle: Graceful probe failure when MWAIT is disabled Jan Beulich
2018-11-22 12:09 ` Roger Pau Monné [this message]
2018-11-22 13:52 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181122120949.jsx3ceeqynteejml@mac \
--to=roger.pau@citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.